From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A39FC1B6C3 for ; Thu, 10 Jan 2019 15:01:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 06:01:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,461,1539673200"; d="scan'208";a="117064445" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.85.183]) ([10.251.85.183]) by orsmga003.jf.intel.com with ESMTP; 10 Jan 2019 06:01:08 -0800 To: Bruce Richardson , dev@dpdk.org Cc: David Marchand , Thomas Monjalon References: <20190110111104.56464-1-bruce.richardson@intel.com> <20190110134732.57052-1-bruce.richardson@intel.com> From: "Burakov, Anatoly" Message-ID: <9f27dcbd-4b4b-7d10-fba0-9ebb14267f92@intel.com> Date: Thu, 10 Jan 2019 14:01:07 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190110134732.57052-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] compat: merge compat library into EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 14:01:11 -0000 On 10-Jan-19 1:47 PM, Bruce Richardson wrote: > Since compat library is only a single header, we can easily move it into > the EAL common headers instead of tracking it separately. The downside of > this is that it becomes a little more difficult to have any libs that are > built before EAL depend on it. Thankfully, this is not a major problem as > the only library which uses rte_compat.h and is built before EAL (kvargs) > already has the path to the compat.h header file explicitly called out as > an include path. > > However, to ensure that we don't later hit problems later with this, we can > add EAL common headers folder to the global include list in the meson build > which means that all common headers can be safely used by all libraries, no > matter what their build order. > > As a side-effect, this patch also fixes an issue with building on BSD using > meson, due to compat lib no longer needing to be listed as a dependency. > > Fixes: a8499f65a1d1 ("log: add missing experimental tag") > > Signed-off-by: Bruce Richardson > > --- > V2: Clean up a few missed references to the compat library in our > documentation and MAINTAINERS file. > Added in fixes tag, as this patch should also fix build issues > with BSD. > --- I can confirm that this fixes current FreeBSD meson build issues. Tested-by: Anatoly Burakov -- Thanks, Anatoly