From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>, zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio-user: fix packed vq option parsing
Date: Thu, 3 Jan 2019 10:52:23 +0100 [thread overview]
Message-ID: <9f3e2197-270e-21be-3b41-457337994d4a@redhat.com> (raw)
In-Reply-To: <20190103024007.18007-2-tiwei.bie@intel.com>
On 1/3/19 3:40 AM, Tiwei Bie wrote:
> Add the RING_PACKED feature to dev->unsupported_features
> when it's disabled, and add the missing packed vq param
> string. And also revert the unexpected change to MAC option
> introduced when adding packed vq option.
>
> Fixes: 34f3966c7f81 ("net/virtio-user: add option to use packed queues")
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.c | 11 ++++-------
> drivers/net/virtio/virtio_user_ethdev.c | 7 ++++---
> 2 files changed, 8 insertions(+), 10 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2019-01-03 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 2:40 [dpdk-dev] [PATCH 0/2] Some fixes for virtio-user/packed-ring Tiwei Bie
2019-01-03 2:40 ` [dpdk-dev] [PATCH 1/2] net/virtio-user: fix packed vq option parsing Tiwei Bie
2019-01-03 9:52 ` Maxime Coquelin [this message]
2019-01-03 2:40 ` [dpdk-dev] [PATCH 2/2] net/virtio-user: fix supported features list Tiwei Bie
2019-01-03 9:53 ` Maxime Coquelin
2019-01-04 18:00 ` [dpdk-dev] [PATCH 0/2] Some fixes for virtio-user/packed-ring Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f3e2197-270e-21be-3b41-457337994d4a@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).