From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D758B2986 for ; Thu, 3 Jan 2019 10:52:28 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2FE475A1FF; Thu, 3 Jan 2019 09:52:28 +0000 (UTC) Received: from [10.36.112.24] (ovpn-112-24.ams2.redhat.com [10.36.112.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6E9715D9CB; Thu, 3 Jan 2019 09:52:26 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org References: <20190103024007.18007-1-tiwei.bie@intel.com> <20190103024007.18007-2-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <9f3e2197-270e-21be-3b41-457337994d4a@redhat.com> Date: Thu, 3 Jan 2019 10:52:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20190103024007.18007-2-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 03 Jan 2019 09:52:28 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio-user: fix packed vq option parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 09:52:29 -0000 On 1/3/19 3:40 AM, Tiwei Bie wrote: > Add the RING_PACKED feature to dev->unsupported_features > when it's disabled, and add the missing packed vq param > string. And also revert the unexpected change to MAC option > introduced when adding packed vq option. > > Fixes: 34f3966c7f81 ("net/virtio-user: add option to use packed queues") > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 11 ++++------- > drivers/net/virtio/virtio_user_ethdev.c | 7 ++++--- > 2 files changed, 8 insertions(+), 10 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime