Re: [dpdk-dev] [PATCH 4/4] vdpa/mlx5: set default event mode to polling

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 12/3/20 12:36 AM, Xueming Li wrote:
> For better performance and latency, this patch sets default event
> handling mode to polling mode which uses dedicate thread per device to
> poll and process event.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  doc/guides/vdpadevs/mlx5.rst  | 2 +-
>  drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/vdpadevs/mlx5.rst b/doc/guides/vdpadevs/mlx5.rst
> index 20254257c9..730e171ba3 100644
> --- a/doc/guides/vdpadevs/mlx5.rst
> +++ b/doc/guides/vdpadevs/mlx5.rst
> @@ -116,7 +116,7 @@ Driver options
>    - 2, Completion queue scheduling will be managed by interrupts. Each CQ burst
>      arms the CQ in order to get an interrupt event in the next traffic burst.
>  
> -  - Default mode is 0.
> +  - Default mode is 1.
>  
>  - ``event_us`` parameter [int]
>  
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c
> index 1f92c529c9..5d954d48ce 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c
> @@ -647,7 +647,7 @@ mlx5_vdpa_config_get(struct rte_devargs *devargs, struct mlx5_vdpa_priv *priv)
>  {
>  	struct rte_kvargs *kvlist;
>  
> -	priv->event_mode = MLX5_VDPA_EVENT_MODE_DYNAMIC_TIMER;
> +	priv->event_mode = MLX5_VDPA_EVENT_MODE_FIXED_TIMER;
>  	priv->event_us = 0;
>  	priv->event_core = -1;
>  	priv->no_traffic_time_s = MLX5_VDPA_DEFAULT_NO_TRAFFIC_TIME_S;
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime