From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06744A0524; Thu, 7 Jan 2021 11:34:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AF85140F1C; Thu, 7 Jan 2021 11:34:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 0F88E140F1B for ; Thu, 7 Jan 2021 11:34:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610015654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UVwKDokcgqfOQJWmFjIT1wPptNH/z2r4TIcQ3DQZsSU=; b=KHrWkLsWCklwiKWaDJmlOR/E6FIOl2wBUS0v0BRYsQ3QDH1Yn/bZxa29Obm4REkj/OE2GF 6Nge3OoDEVBa22cknMDPtRTHj2uE1dXpHFhbK5MR4uutcggqWRoXIaaeiCOqHv4MLv5WTr 8mqo+E1ZcusdVF/vTic0O1/q7Jd0b+k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-vALyzBstM9OvMQq8cAgfeA-1; Thu, 07 Jan 2021 05:34:10 -0500 X-MC-Unique: vALyzBstM9OvMQq8cAgfeA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 77E6C800D62; Thu, 7 Jan 2021 10:34:09 +0000 (UTC) Received: from [10.36.110.9] (unknown [10.36.110.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 00C3E10021AA; Thu, 7 Jan 2021 10:34:07 +0000 (UTC) To: Xueming Li , Matan Azrad , Viacheslav Ovsiienko Cc: dev@dpdk.org, Asaf Penso References: <1606952203-23310-1-git-send-email-xuemingl@nvidia.com> <1606952203-23310-4-git-send-email-xuemingl@nvidia.com> From: Maxime Coquelin Message-ID: <9f404cd5-513f-3f1c-beef-d84581241f6a@redhat.com> Date: Thu, 7 Jan 2021 11:34:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <1606952203-23310-4-git-send-email-xuemingl@nvidia.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 4/4] vdpa/mlx5: set default event mode to polling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/3/20 12:36 AM, Xueming Li wrote: > For better performance and latency, this patch sets default event > handling mode to polling mode which uses dedicate thread per device to > poll and process event. > > Signed-off-by: Xueming Li > Acked-by: Matan Azrad > --- > doc/guides/vdpadevs/mlx5.rst | 2 +- > drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/vdpadevs/mlx5.rst b/doc/guides/vdpadevs/mlx5.rst > index 20254257c9..730e171ba3 100644 > --- a/doc/guides/vdpadevs/mlx5.rst > +++ b/doc/guides/vdpadevs/mlx5.rst > @@ -116,7 +116,7 @@ Driver options > - 2, Completion queue scheduling will be managed by interrupts. Each CQ burst > arms the CQ in order to get an interrupt event in the next traffic burst. > > - - Default mode is 0. > + - Default mode is 1. > > - ``event_us`` parameter [int] > > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c > index 1f92c529c9..5d954d48ce 100644 > --- a/drivers/vdpa/mlx5/mlx5_vdpa.c > +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c > @@ -647,7 +647,7 @@ mlx5_vdpa_config_get(struct rte_devargs *devargs, struct mlx5_vdpa_priv *priv) > { > struct rte_kvargs *kvlist; > > - priv->event_mode = MLX5_VDPA_EVENT_MODE_DYNAMIC_TIMER; > + priv->event_mode = MLX5_VDPA_EVENT_MODE_FIXED_TIMER; > priv->event_us = 0; > priv->event_core = -1; > priv->no_traffic_time_s = MLX5_VDPA_DEFAULT_NO_TRAFFIC_TIME_S; > Reviewed-by: Maxime Coquelin Thanks, Maxime