From: Kevin Traynor <ktraynor@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, john.mcnamara@intel.com,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc: add pmdinfogen rewrite to release notes
Date: Fri, 12 Feb 2021 14:36:36 +0000 [thread overview]
Message-ID: <9f50fafb-7b2d-64ae-7255-244b3cbeda52@redhat.com> (raw)
In-Reply-To: <20210212142956.GC970@bricha3-MOBL.ger.corp.intel.com>
On 12/02/2021 14:29, Bruce Richardson wrote:
> On Fri, Feb 12, 2021 at 03:17:39PM +0100, Thomas Monjalon wrote:
>> From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>>
>> The build tool pmdinfogen was rewritten in DPDK 21.02,
>> adding Windows support.
>> There is a new build-time dependency: pyelftools.
>>
>> Fixes: f0f93a7adfee ("buildtools: use Python pmdinfogen")
>> Fixes: 6b19edcb663c ("build: enable pmdinfogen for Windows")
>>
>> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> One additional suggestion below if you want to take it too.
>
>> ---
>> doc/guides/rel_notes/release_21_02.rst | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst
>> index 64e220f2ac..99a559479b 100644
>> --- a/doc/guides/rel_notes/release_21_02.rst
>> +++ b/doc/guides/rel_notes/release_21_02.rst
>> @@ -20,6 +20,12 @@ DPDK Release 21.02
>> make doc-guides-html
>> xdg-open build/doc/html/guides/rel_notes/release_21_02.html
>>
>> +.. note::
>> +
>> + A dependency has been added for building DPDK on Linux or FreeBSD:
>> + the Python module pyelftools (version 0.22 or greater),
>> + often packaged as python3-pyelftools, is required.
> This module can also be installed using pip for python3 e.g.
> "pip3 install pyelftools".
>
yep, just about to send a doc patch for that.
>> +
>>
>> New Features
>> ------------
>> @@ -180,6 +186,13 @@ New Features
>> tests and output graphed results to PDF files.
>> See the :doc:`../tools/cryptoperf` guide for more details.
>>
>> +* **Added Windows support to pmdinfogen.**
>> +
>> + PMD information strings were added for Windows as well as for other OS.
>> + Extracting them from Windows DLL is not yet supported.
>> + The build-time tool pmdinfogen was rewritten in Python,
>> + thus libelf dependency was replaced with pyelftools as new build dependency.
>> +
>> * **Added support for build-time checking of header includes.**
>>
>> A new build option ``check_includes`` has been added, which, when enabled,
>> --
>> 2.30.0
>>
>
next prev parent reply other threads:[~2021-02-12 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 11:04 [dpdk-dev] [PATCH] " Thomas Monjalon
2021-02-12 14:17 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2021-02-12 14:29 ` Bruce Richardson
2021-02-12 14:36 ` Kevin Traynor [this message]
2021-02-12 15:15 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2021-02-14 9:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f50fafb-7b2d-64ae-7255-244b3cbeda52@redhat.com \
--to=ktraynor@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=john.mcnamara@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).