From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <hemant.agrawal@nxp.com>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
(mail-bn3nam01on0078.outbound.protection.outlook.com [104.47.33.78])
by dpdk.org (Postfix) with ESMTP id AC5A41B406
for <dev@dpdk.org>; Fri, 22 Dec 2017 17:27:37 +0100 (CET)
Received: from BN6PR03CA0086.namprd03.prod.outlook.com (10.164.122.152) by
CY4PR03MB2694.namprd03.prod.outlook.com (10.173.43.137) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
15.20.323.15; Fri, 22 Dec 2017 16:27:36 +0000
Received: from BL2FFO11FD031.protection.gbl (2a01:111:f400:7c09::140) by
BN6PR03CA0086.outlook.office365.com (2603:10b6:405:6f::24) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
15.20.345.14 via Frontend Transport; Fri, 22 Dec 2017 16:27:36 +0000
Authentication-Results: spf=fail (sender IP is 192.88.168.50)
smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com;
Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not
designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com;
client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;
Received: from tx30smr01.am.freescale.net (192.88.168.50) by
BL2FFO11FD031.mail.protection.outlook.com (10.173.160.71) with Microsoft SMTP
Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.302.6
via Frontend Transport; Fri, 22 Dec 2017 16:27:20 +0000
Received: from [10.214.249.127] ([10.214.249.127])
by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vBMGPkcp030184;
Fri, 22 Dec 2017 09:26:08 -0700
To: "Wiles, Keith" <keith.wiles@intel.com>, Thomas Monjalon
<thomas@monjalon.net>
References: <1513922231-15554-1-git-send-email-hemant.agrawal@nxp.com>
<4919393.KhUSbVM1LT@xps> <E554161E-F956-4883-924F-9AA38F446C0C@intel.com>
<10030168.6hk24mNXSe@xps> <E4333AE7-0C8B-4695-BE32-3F9C6FBD15B3@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Message-ID: <9f9841c6-dee4-99ec-5cab-0667ccddc04b@nxp.com>
Date: Fri, 22 Dec 2017 21:55:40 +0530
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <E4333AE7-0C8B-4695-BE32-3F9C6FBD15B3@intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-Matching-Connectors: 131584336407622664;
(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()
X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;
SFV:NSPM;
SFS:(10009020)(336005)(346002)(39380400002)(396003)(39860400002)(376002)(2980300002)(1110001)(1109001)(339900001)(3190300001)(24454002)(189003)(199004)(85426001)(6246003)(23676004)(106466001)(65826007)(36756003)(498600001)(53936002)(8676002)(2870700001)(2906002)(316002)(110136005)(67846002)(76176011)(64126003)(31696002)(86362001)(81156014)(83506002)(54906003)(2486003)(50466002)(6666003)(97736004)(58126008)(81166006)(2950100002)(105606002)(93886005)(104016004)(53546011)(47776003)(65956001)(5660300001)(8936002)(68736007)(65806001)(77096006)(356003)(305945005)(4326008)(229853002)(31686004);
DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2694; H:tx30smr01.am.freescale.net;
FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en;
X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD031;
1:3idOfHIiRA8CBdPMoYwtiTDFOUbHAqvMRPZE6AGNMxgJe042S1iquEmOdzbs0m3tg8W6MJgzaSf67vnvVai+pRLHB1qd1q1D5quTc/Bbv3AuYIEAlaey8j4xw81HBsLW
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e00593d2-9ce7-4085-f408-08d54958e00b
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(5600026)(4604075)(4534020)(4628075)(201703131517081)(2017052603307);
SRVR:CY4PR03MB2694;
X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694;
3:j14aQDnzKRse/7JySULPbxIBd8ol9BOBfn1vybAXkIRyQERr65YUufi+PV9qr9XEmsYervQeM0Yzy7rsqkxEOOMdyFuMM9okjhGkB9pdWaGoD04TJTvjbvH99UnuO/MYUk81Vqt8utloiwuOuO5OYrD2ldO2aG0EZP2u6EJHuPRSuhnxUHb3urU+1GMCxp9gDSvApWcd1KT6svL+9DeSMwHoiLUwF0JwCLS5ulfPVs6qnuIVXbMAGsQEKR/SKckIRqlJx8bBpQxp8Eu4FxUbBE+GtreoJUystQnB3qxouC/SQ8D+CFi3V+w0z/UjtpYyvXVIPkn6XayjnjCIsR3ph9SewVK4iCeSOBKEt6u/EHQ=;
25:e+syplS3J+6e9A3EAUHeUEV15ZOy6AHRyj6QJug3ou2/4UOFIFOK1m1YIoSaSi/Ipv073MnYNprNHCwHp5+TNrPhe0U883nA7bsBDz8KL3THsvPL8Hd8YSQNJM9CLIDOuTUmLY/DDw8jwkAg0tngFr1yu6N886XJo6UxTSNemxs6tGRaY2PAM8nqiYwlnE3eB9qDAUdHY5uR0IKsDeZNxPs9CaTPowQjZeFj/QQftToKqQR+uP0sUw09dWmNKhvSYaAdk4ghdcvpM+cH5ZnquxNFIj3yVoV1aU+h2b7y/FgsXpEWRb6/Kq6HUcMnnwxLftovaq6DiG2zmAoTwWmquw==
X-MS-TrafficTypeDiagnostic: CY4PR03MB2694:
X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694;
31:r51J07ctR9GplehV37mOU/IgNWUxuVNfg43i1t7z5BFufxFoPsCMoBx/xcfzEoqjeK+9UDkgT8AfQdInf9JUGlg7RjhQsSTPIKozzf+Vfgr1QZ7tdIOfRGxqvzRwPBivULuV+xAXehV+G0pBNPyqn+Gva/HSlPr+bIPvuxdEpAy1Mbmm5k7EEzb/tjeUHPa0J/uMu34xhntszz5YAALwy/zY9hqTL3xlaukUx3AwGyw=;
4:yxKmBodQ52QX/ZSfudEXUFA9Yo2RZwJnKNogrPirVIX8ieEm1IwZePZ3BpVy/IknQ6agXYB1NK2wCrBmQcNGlI4vyvtw1xEwGAV0x8cC54cfAZkRpJT2FI7QQ/kiZny6gJhh6XD8Po9yk9/HAi8GJc8SXiTr5s8l/bIKXCUXJ00EqX28sxxJyE5b74PwEPdt58bJlHVZS57e+wqLEr5QVAXDcJcC4mpvzMEOnfI/6PD+RhS0fL+O+kWsUdo0q6vbe1OIfm5ly2gAbt3vitLSzw==
X-Microsoft-Antispam-PRVS: <CY4PR03MB2694E2308F4A326C5DAEC20189020@CY4PR03MB2694.namprd03.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6095135)(2401047)(8121501046)(5005006)(3231023)(944510045)(944921045)(946801045)(946901045)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(20161123556025)(20161123559100)(20161123563025)(20161123561025)(20161123565025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(201708071742011);
SRVR:CY4PR03MB2694; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006);
SRVR:CY4PR03MB2694;
X-Forefront-PRVS: 05299D545B
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjAzTUIyNjk0OzIzOjdOKzhYZGFWVzNubjBCZ0JmNHdFSm5tdTJW?=
=?utf-8?B?cytnMEMrUkZZZnVnQXhHRC9JcS92RHRJN3lRS0FOR3NIRlNlYXFzWlFWbWIz?=
=?utf-8?B?K2lvZk9LZlBYcThnSGVLWlJXSlFTWmVueEFwYmttb1Z6UzhVUlpaNzB3M3JB?=
=?utf-8?B?V0d4ZGViSENEa1dOOHdpdFdrUDh2RGIraEQrNC94dFVTZHk4UHJKV0ROZHVG?=
=?utf-8?B?U1pDSGNZeERqNG5tL3N4T0Fwc2ptU25YZFduWTAxZEt0djRSYnpEdkhOcmln?=
=?utf-8?B?YXJFYm5EQnA3S1lKYVFGVjdFWjNienZka3g1aU5Da2JBYktnK1ltekMrRDRZ?=
=?utf-8?B?ZTg0RlV4VnVnbXZhbTlNQkZsY1hlNzlTTzh6OEV3cFlDdE1aRVYwWFlXaEVk?=
=?utf-8?B?Z2Z0TWw4VE5HNGxZODZ6eCsrbzhFQVEvSWZmY2N3SjhFNEhLVWZBV1ZFMENp?=
=?utf-8?B?YWhnSGEveEFDczJJTWZ0VkF1S0tlYUdMWUhIM0NXQWtsbWxZbkVOZi8xRGRv?=
=?utf-8?B?U3poZW1FaFFyYVJ4MkFqcTZ5UXh5dXVraFpTdll6aDdGYkVRUDdRMFNnT3Za?=
=?utf-8?B?QVpadXNyaSs2Y0x1OGxHWUt2ZGxwYnVZdDJvUDVya3p3MjlQUWloMHRZNGxi?=
=?utf-8?B?RmxqaVBKeWlRcHo5VkJwRkZWdGtMMFd2UEdXbXRaMm1mYVV6VkhGb1J2RmxI?=
=?utf-8?B?blZ1ZWFnUXdCOHp2dUdLTXhZQTlzNTBNQTVEb0pSTUlRRUVvSmNUeUJrbmx5?=
=?utf-8?B?Rk5vblB6SUFOaFl1R3VQUmdLeWJnRGpuSjNudmJBWEJHUVp5VFc4dFBMM2Vl?=
=?utf-8?B?S2poTlJ6NWg0bVUvYzV4NGpjWHRJVERCNmxPRENTR1Q1MjNCRjlxTkdRZ013?=
=?utf-8?B?U2hjUERkUWFRWkJrS0NBOEhybWhhaU93N3FNYkRqRlJHQ2RibThHeDE4RkNV?=
=?utf-8?B?anZlMHlJOEJPcnRKSW02SEZsbmZ3VWZWeW5DYUlLQ0Q5dkVUQjhwT0xEL05C?=
=?utf-8?B?SXk0NlBtWEdoWEYzd0lTTHJkRGlucWNhNThaeXFHaUJrTWNPaGtmWXEyYUhP?=
=?utf-8?B?VWo4ekpOenU1YVNoOXBtei9nTHdJNndVU05tTDUrbk9xN0xsejRLeXFGcVNn?=
=?utf-8?B?ZUI2SXovM3FaNnhrL2ZHdDcxSFg1VU9Pb0dUNDF0dndJYXBrampjdy82Wmlo?=
=?utf-8?B?WEhGVHg4ZlRSRlVDd29zeGpZVjEySHMyTmY0b3JKN2ZXUjF5SHRaT2Jjd3ph?=
=?utf-8?B?aEFUVHMwL2RsazdrdHBSRXJIaTEyZFVnT2o4VU0zMWdKTUJKdUlRbFpmTXZN?=
=?utf-8?B?ZldwZGdzaEEzTWJDbHYvNko1U0VQcEN0MTVrSDNDYzdHV2tOVGowMVJ4Um1h?=
=?utf-8?B?MERGcVVUOWp5NVZPZjM5LzIwblJvMTQ1WGxmTFFBZmJZV2NteGxnQjRwUHQv?=
=?utf-8?B?ek10S2N0Z3ZHaFFUQUJGRENMREg4SGw0eUViVGY1QjhZL1ZqOEdMSUxUd3hJ?=
=?utf-8?B?blpPU0xCempzUTBDU2R4SmsrTE9aMHdXeW5zQWRXM0tmNXNWMVZUNUdZdktp?=
=?utf-8?B?R0pUeTVPTmpxTm1JN2NmTVNDbElYZURNR2dSTFVLVzhTYnp1MUdEZStPZUs0?=
=?utf-8?B?UlplT1kvaVBvZkNGdVI5Z2YzSk1KUUNueDVWbVAvUzd4WHBvayt5UVJyQUNm?=
=?utf-8?B?ZUU3SFpLdjRVNCtCb2poQzB6cmVqaGJ4YUgrajZ0VU9BeUs2MENYWHVQUzgz?=
=?utf-8?B?NWpqSTU4VGNwdW9Oa3VwbkVRVVdHT2RHUWx6UmhIdVZiM0cxWmVPcVFRKzZW?=
=?utf-8?B?dnFZUUVpTkhFYjh1SEZJNTZqYmRKT3h3UXBVZzkramJOTlE9PQ==?=
X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694;
6:jxtQ2uzuZng9/urV7AaFYAjTDw3f09U5qp5Ty9vOZi5x17UkfUjDQuNrRfU8URhYOEHJP758LUCZeRvclwoktq7fiOIVzF1kq3Y5l2PgTYeusTbVffoije09cotWr7bs0v8pALaypsGUwGlaBQz5O/ysk0avuw0XUvFGoyIENmrF4FVHBFtnJcjSg+9s5UKooSB+ANauzpQA+wjb9Pj382+P8mXDAYMJ5PI/aZ3um/l3DxQZ4pIAFrI8o5MKYOsLG7vKs5S8rqm/R23ULqVFXGtyxxnZd/pCbbDGr/Mp0vC4AH4cELgmWQ16CUVfITPflztlX0nQc8yg+TqKgoO5hMKjflFXmUcdgA6a3Mvchq8=;
5:aA7CRlXY443X6xsZ8Ab1Mht0Za4cfNWFIrNZ2KHHISbB+937m6AYVfTDwFuAaIhbPwv+Zlhw7vC/R4ce4WtXO1QeRBpPhaPIrOjOSOhOx5kIsW6w5odo4QRUG0v/f4JBoXF1VXwW/9omcyZ7FDhZ04c7JPWYcmkJAknJzpnFmc8=;
24:BSpc4KFoCG6V23CNXZnGgYEa0HWLcCyoZaARj2HoJCZMFKGTtqv0Ud/4//2UsyHy4RLjVU3rOHJ5a8AbkfSxF5E8yFqqwz5Rn9pY0FrrW/A=;
7:L/Ppqdj0jGLZKceGvGBOMNpeHXPNGTEPuyEcnEAWKqzhfvm7m//osaZySu/jCQAFqMrPUSlm/bB5smSiGrLHDSG4PonvO239t0WgFfLz0lz9J1y9GpwuiVdic+SpDnoT2cdLzt+P+3WMRuIoSctBSjBzTRAn/JcPWTTeusjQVPngkG2/xjjwQvdXKwBvkJ/VTsVnt/D0OsBTm4wLy5BFSQHd76c0ViiTOa2P75FTUoCMIhrm3RWy+Y/GIfsOMny2
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2017 16:27:20.5594 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e00593d2-9ce7-4085-f408-08d54958e00b
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50];
Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2694
Subject: Re: [dpdk-dev] [PATCH] Create kern folder for Linux kernel modules
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Dec 2017 16:27:38 -0000
On 12/22/2017 8:21 PM, Wiles, Keith wrote:
>
>
>> On Dec 22, 2017, at 8:17 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
>>
>> 22/12/2017 14:59, Wiles, Keith:
>>>
>>>> On Dec 22, 2017, at 5:38 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
>>>>
>>>> 22/12/2017 11:04, Hemant Agrawal:
>>>>> On 12/22/2017 2:13 PM, Thomas Monjalon wrote:
>>>>>> These modules are Linux modules, so they should be in the linuxapp dir.
>>>>>
>>>>>
>>>>> This is a cleaner separation w.r.t userspace/kernel space code.
>>>>> *kern* is a better placefolder for LKMs.
>>>>
>>>> I prefer "kernel" name.
>>>
>>> The name should be related to Linux in some way, like linux_kern or linux_kernel or linux_modules (this is the one I prefer) this way it make it clear which OS they are designed for.
>>
>> If such top-level directory is created, the BSD modules must be moved there too.
>> That's why "kernel/" or "kernel/linux/" is appropriate.
>
> OK seems reasonable, what about kernel/{freebsd,Linux, …}/modules/(module-name e.g. kni, igb_uio, nic_uio, …)
>
> Kernel is misleading IMO, but I can live with it as long as we break down the different kernel related items. This is why I add modules in the path, as we could have other OSes like Windows with items that are not modules or VMs or containers…
>
> I can live with kernel/{freebsd, linux, …}/{igb_uio, kni, nic_uio, ..} but I would like to make sure it does not change in the future with adding windows.
Your suggestion seems reasonable.
I am not sure about windows.
May be some working on DPDK-on-windows can comment
>
>>
>>>>> Also eal is not getting overloaded.
>>>>>
>>>>> linuxapp is part of librte_eal. KNI is not related to EAL, but still
>>>>> the kni kernel code is added to librte_eal under linuxapp.
>>>>
>>>> Yes it makes sense.
>>>>
>>>> More opinions/votes?
>>>>
>>>>>> There are also some kernel modules in the bsdapp directory.
>>>>>
>>>>> We can move them as well.
>>
>
> Regards,
> Keith
>