From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A78271B19 for ; Fri, 21 Sep 2018 15:22:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2018 06:22:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,285,1534834800"; d="scan'208";a="71830092" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga007.fm.intel.com with ESMTP; 21 Sep 2018 06:22:27 -0700 To: Gagandeep Singh , dev@dpdk.org Cc: pankaj.chauhan@nxp.com References: <20180906055449.21731-1-g.singh@nxp.com> <20180913094201.17098-1-g.singh@nxp.com> <20180913094201.17098-2-g.singh@nxp.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <9fb310b0-9ee4-7e9a-f4fe-ccfd702ae4dd@intel.com> Date: Fri, 21 Sep 2018 14:22:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180913094201.17098-2-g.singh@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/3] doc: add usage doc for ENETC PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 13:22:42 -0000 On 9/13/2018 10:41 AM, Gagandeep Singh wrote: > Add enetc usage document to compile and run the > DPDK application on enetc supported platform. > This document introduces the enetc driver, supported > platforms and supported features. > > Signed-off-by: Gagandeep Singh > --- > MAINTAINERS | 5 + > doc/guides/nics/enetc.rst | 153 +++++++++++++++++++++++++++++ > doc/guides/nics/features/enetc.ini | 8 ++ > doc/guides/nics/index.rst | 1 + Please also add a release note update. And a web page patch to supported device list: https://core.dpdk.org/supported/ <...> > +Driver compilation and testing > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +#. Please refer the document :ref:`compiling and testing a PMD for a NIC ` > + to compile the driver. Use target "arm64-armv8a-linuxapp-gcc" in make command > + > +#. Refer to the document :ref:`cross build dpdk for arm64 ` to > + disable flags and for cross compilation > + > +#. To compile in performance mode, please set ``CONFIG_RTE_CACHE_LINE_SIZE=64`` > + > +#. Running l2fwd: > + > + Follow instructions available in the document > + :ref:`compiling and testing a PMD for a NIC ` > + to run l2fwd. > + > + - First unbind the ports from kernel > + > + - echo vfio-pci > /sys/bus/pci/devices/0000\:00\:00.1/driver_override > + - echo 0000:00:00.1 > /sys/bus/pci/drivers/fsl_enetc/unbind > + - echo vfio-pci > /sys/bus/pci/devices/0000\:00\:00.0/driver_override > + - echo 0000:00:00.0 > /sys/bus/pci/drivers/fsl_enetc/unbind > + - Then bind them to VFIO, so that DPDK application can use them > + > + - echo 0000:00:00.1 > /sys/bus/pci/drivers/vfio-pci/bind > + - echo 0000:00:00.0 > /sys/bus/pci/drivers/vfio-pci/bind > + - Mount Hugepages > + > + - mkdir /mnt/hugepages > + - mount -t hugetlbfs none /mnt/hugepages > + - Run l2fwd application We moved common part of documentation into " compiling and testing a PMD for a NIC" section, check other PMD docs for usage, for example ena PMD, "Usage example" section. It is good to keep example output if it has PMD specific logs, but not required to have generic output.