From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E0B8A0540; Mon, 22 Aug 2022 17:08:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DFFC40A81; Mon, 22 Aug 2022 17:08:34 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2044.outbound.protection.outlook.com [40.107.220.44]) by mails.dpdk.org (Postfix) with ESMTP id 08FF440694 for ; Mon, 22 Aug 2022 17:08:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LR2Ci+O0KmP5isplqTI/TBB9p7JMGE71+heQ8xuNwGkp6z+iXXvnm7jbif29hyHElrTrORVELF0p63mNgr/4NNWtZW4f9msakEMUds1z5SJsJSrtLKKnuzTvsy9KCfL3RrYT8pJOBGHw+xiWEwvFbdcyDGgMyPeSt19mp4gp5UQCN5ocPmtCoAvHtpkHKaSn05iYDzZVcbblK7+HRoH5q5vZDZKQKIcVYJP5q7C0LtsvuxFrrgF057ao1x4bYIkYNu5GvEwn+7mnlNb8DhhnVupC+XbkUfUS4SL30Tyltd1tTZ3GfthMTOXa1mjP4LYyffloICzGSq7smUVbmSIZww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UlokCdEYM8yMTKFXrgAkUm/Q5RjZLYJPOeEWQH0Pm5o=; b=T6IyAf/s4t071ITp+ReuXKoRAP90dPmqTCQlqUh/0QJhvNmfqxHrQGd3U3xEyzNYDPVugrtJjo12ZL9yyOqnWXSdVoNG6Fn7go0AVYxe6+Kz8uSu3zs/NwyJ+Rwt5CRK6ka+p2UlgwUatBbJB67QPQ1S0fvIfNufoDlXsnqj863XYzMCeFFzLKEsglZvw5r2FOxyl8Rb/SBMUw5Kpy+a3GOYVkdT+J0KlOxTpAX8Zgr8XkkBqVq1DW3ERhpoCHNUqlMzKO/jyh34u6HrM9aEl2u6AoedjeFbLE/B7XtbTABwQCRXOoFTQaQu/llr4HfgjnL48lfSHm9y+kLommZmMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=microsoft.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UlokCdEYM8yMTKFXrgAkUm/Q5RjZLYJPOeEWQH0Pm5o=; b=fAU/QhVDZ5ggJJ1wkHuF1uZZO60O0zZ8SA9F2rdqheppYwXj4dRxnIsanIrNApv6sNEA9B3BUQt5/l7/fZ4M8gAYwzKIQgrLJ0sDpIb0KKNU35dCYD0E9J72Dw+Nmfd7r9d+UHU3DYrz83Ep3bVp1RneSpI/wehfMV21v671rJc= Received: from BN9PR03CA0105.namprd03.prod.outlook.com (2603:10b6:408:fd::20) by PH0PR02MB7464.namprd02.prod.outlook.com (2603:10b6:510:d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.19; Mon, 22 Aug 2022 15:08:29 +0000 Received: from BN1NAM02FT040.eop-nam02.prod.protection.outlook.com (2603:10b6:408:fd:cafe::cf) by BN9PR03CA0105.outlook.office365.com (2603:10b6:408:fd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.18 via Frontend Transport; Mon, 22 Aug 2022 15:08:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT040.mail.protection.outlook.com (10.13.2.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5546.15 via Frontend Transport; Mon, 22 Aug 2022 15:08:28 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 22 Aug 2022 16:08:27 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Mon, 22 Aug 2022 16:08:27 +0100 Envelope-to: longli@microsoft.com, dev@dpdk.org, sharmaajay@microsoft.com, sthemmin@microsoft.com Received: from [10.71.194.74] (port=63559) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oQ92R-0002uy-66; Mon, 22 Aug 2022 16:08:27 +0100 Message-ID: <9fc85998-0802-f1f4-fa97-86114a511e76@xilinx.com> Date: Mon, 22 Aug 2022 16:08:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [Patch v4 17/17] net/mana: add function to report queue stats Content-Language: en-US To: CC: , Ajay Sharma , Stephen Hemminger References: <1657324171-31369-1-git-send-email-longli@linuxonhyperv.com> <1657324171-31369-18-git-send-email-longli@linuxonhyperv.com> From: Ferruh Yigit In-Reply-To: <1657324171-31369-18-git-send-email-longli@linuxonhyperv.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ea9cfda-9111-45e0-b689-08da84502b86 X-MS-TrafficTypeDiagnostic: PH0PR02MB7464:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8Mzp7Eo+Ku1Z/TqPomMjdeMq96RmjYKMwU85EyiaIx+ON99yVFykaSnqAcYpf7zdZIkJLkcQ0KmIVMF2vzTERWYoeZy2aXwumez+FlgKxG/r0GRI/JXL7vPteK/MKmTQujR8PHDs5fVDAf3MstT0LzVPHWlCQi8OftwWZbxrfZNZO8xEIKPOmI5E5JPncQ2hICTEibSNkfwou656gQW0cgDCPC0+v4wHGvSoUSczP7HJL14YgBynvN7VnTk97vNcTvvnZNO3sq6PTsE6/ok76W2dIWW2zCecf8ojsV0TtuLrEpA2bhBO0362CYJnT3SN+7PhMkyl4qyuOIXraj7IaoLrMn+ULCbpMZp3uE+bxhxuoIKLWB3Kb6jJlZIP4KjELYkAtcJ0h3/zaew8npgWXoxe++QAfd+3/uMqrncjShJ9+QZbu9N2U3j9JOnrgvYPMfe+FkURXfd4fLekrK67JB/kyFNOuwsDiWxZKCi1NBbKLZAGONGv20ciMWaNUSjM5o4FOkNdXvVcGURKdLt08wpTb3bAHEipsonnsTwHHCD+FThJyl0QliCYmF8IgzlaCrCprDJBNBd7Mcn/aWxKRhlSf3av01OyDqL3rtV5v/+j3P9VImnE+ZPBt3Ivs5w1zFpcYNEdLoTx5lG01pRP1u4NIM9UbU5YUNdDwdwUbhFyyEG6ohUmPa/rzwc8iWwXfhtsHTKlp1bGaTu085XxJII6uOqTOdHafN3vu263oiJ+aD/tt0PKJ1MjmfLBo8B88rc9/WB0hU5XwGyInWG/0G+KWlf1BWiyT7ZSmOGtmI+J+qJrkxOnhoSwqiCLFOdq X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(396003)(39860400002)(346002)(136003)(40470700004)(46966006)(36840700001)(82310400005)(2906002)(53546011)(31696002)(36860700001)(40460700003)(26005)(9786002)(44832011)(478600001)(41300700001)(8936002)(5660300002)(426003)(47076005)(336012)(186003)(356005)(83380400001)(82740400003)(7636003)(4744005)(2616005)(40480700001)(4326008)(316002)(6916009)(8676002)(70206006)(70586007)(36756003)(45080400002)(31686004)(54906003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 15:08:28.7126 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ea9cfda-9111-45e0-b689-08da84502b86 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT040.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7464 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/9/2022 12:49 AM, longli@linuxonhyperv.com wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > From: Long Li > > Report packet statistics. > > Signed-off-by: Long Li <...> > +static int mana_dev_stats_get(struct rte_eth_dev *dev, > + struct rte_eth_stats *stats) > +{ > + unsigned int i; > + > + for (i = 0; i < dev->data->nb_tx_queues; i++) { > + struct mana_txq *txq = dev->data->tx_queues[i]; > + > + if (!txq) > + continue; > + > + stats->opackets = txq->stats.packets; > + stats->obytes = txq->stats.bytes; > + stats->oerrors = txq->stats.errors; Shouldn't these be "+=" ? Same for below Rx block.