From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 79E2D1B84C for ; Tue, 10 Apr 2018 11:40:37 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1CE2B7C6DC; Tue, 10 Apr 2018 09:40:37 +0000 (UTC) Received: from [10.36.112.60] (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 152456F9E6; Tue, 10 Apr 2018 09:40:35 +0000 (UTC) To: Fan Zhang , dev@dpdk.org Cc: ferruh.yigit@intel.com References: <20180409163832.85611-1-roy.fan.zhang@intel.com> <20180409175740.86858-1-roy.fan.zhang@intel.com> From: Maxime Coquelin Message-ID: <9fdd3dea-8646-91c3-da29-46ba16aae136@redhat.com> Date: Tue, 10 Apr 2018 11:40:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180409175740.86858-1-roy.fan.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 10 Apr 2018 09:40:37 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 10 Apr 2018 09:40:37 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 09:40:37 -0000 On 04/09/2018 07:57 PM, Fan Zhang wrote: > Fixes: 2ce5bd8c442d ("examples/vhost_crypto: add vhost crypto sample application") > > This patch fixes the parsing of cryptodev id in the cmdline. > > Signed-off-by: Fan Zhang > --- > examples/vhost_crypto/main.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c > index bc867240d..860200e29 100644 > --- a/examples/vhost_crypto/main.c > +++ b/examples/vhost_crypto/main.c > @@ -95,11 +95,6 @@ parse_cryptodev_id(const char *q_arg) > > /* parse decimal string */ > pm = strtoul(q_arg, &end, 10); > - if ((pm == '\0') || (end == NULL) || (*end != '\0')) { > - RTE_LOG(ERR, USER1, "Invalid Cryptodev ID %s\n", q_arg); > - return -1; > - } > - > if (pm > rte_cryptodev_count()) { > RTE_LOG(ERR, USER1, "Invalid Cryptodev ID %s\n", q_arg); > return -1; > Acked-by: Maxime Coquelin I'll squash it with faulty commit if not yet merged by Ferruh. Thanks, Maxime