From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by dpdk.org (Postfix) with ESMTP id 8BA08156 for ; Thu, 7 Nov 2013 23:15:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1383862585; x=1415398585; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+qtKtcSyT0K7QVrFeWvrJYz9M1L475B47HqZPul4tTs=; b=QoI5/5+hF4D4j5PCoehACR8PfThOiW2ldmnQCgUl5UIBNQVSwyLFPSjr zDvuD47y7jO+vZjaZoqtGDOXJ0X9QrE8emKuEtv9Yh4mXM9/XiB6hD3OD n1sPIGJMGgXV06iDPzXzMTfOs/8tZa4pyX0MyAhFtTl/rOzj4lSYk3SsA Q=; X-IronPort-AV: E=Sophos;i="4.93,654,1378857600"; d="scan'208";a="436790" Received: from smtp-in-31001.sea31.amazon.com ([10.184.168.27]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 07 Nov 2013 21:53:58 +0000 Received: from ex10-hub-36002.ant.amazon.com (ex10-hub-36002.sea32.amazon.com [10.250.1.7]) by smtp-in-31001.sea31.amazon.com (8.14.7/8.14.7) with ESMTP id rA7LrkMv016194 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=OK); Thu, 7 Nov 2013 21:53:47 GMT Received: from EX10-MBX-36002.ant.amazon.com ([fe80::cd97:16ef:48e8:b9f5]) by ex10-hub-36002.ant.amazon.com ([::1]) with mapi id 14.02.0342.003; Thu, 7 Nov 2013 13:53:41 -0800 From: "Benson, Bryan" To: "dev@dpdk.org" Thread-Topic: [dpdk-dev] RX checksum offloading Thread-Index: Ac7bS6VHDEWA3z2uR/6QWCn3UF0daAAGLuCOAAHFf9wAHA4ygAAFhh+AAAR8bqc= Date: Thu, 7 Nov 2013 21:53:41 +0000 Message-ID: References: <201311071006.24033.thomas.monjalon@6wind.com>, <201311071244.33166.thomas.monjalon@6wind.com> In-Reply-To: <201311071244.33166.thomas.monjalon@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.17.1.118] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] RX checksum offloading X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Nov 2013 22:15:31 -0000 All,=0A= below is the validation of the submitted patch - I used the default rx free= thresh (0) and 64 & it now works for both cases.=0A= =0A= Thank you!=0A= Bryan Benson=0A= =0A= -- Validation --=0A= =0A= [bmbenson]~/1.3.1.1/DPDK% sudo ./x86_64-default-linuxapp-gcc/app/testpmd -c= 0xFF00FF00 -n 4 -b 0000:06:00.0 -- --portmask=3D0x3 --nb-cores=3D2 --enabl= e-rx-cksum --disable-hw-vlan --disable-rss --crc-strip --rxd=3D1024 --txd= =3D1024 -i=0A= ... ...=0A= testpmd> set fwd csum=0A= Set csum packet forwarding mode=0A= testpmd> start=0A= csum packet forwarding - CRC stripping enabled - packets/burst=3D16=0A= nb forwarding cores=3D2 - nb forwarding ports=3D2=0A= RX queues=3D1 - RX desc=3D1024 - RX free threshold=3D0=0A= RX threshold registers: pthresh=3D8 hthresh=3D8 wthresh=3D4=0A= TX queues=3D1 - TX desc=3D1024 - TX free threshold=3D0=0A= TX threshold registers: pthresh=3D36 hthresh=3D0 wthresh=3D0=0A= TX RS bit threshold=3D0 - TXQ flags=3D0x0=0A= testpmd> stop=0A= =0A= Telling cores to stop...=0A= Waiting for lcores to finish...=0A= =0A= ---------------------- Forward statistics for port 0 -------------------= ---=0A= RX-packets: 505103 RX-dropped: 0 RX-total: 505103=0A= Bad-ipcsum: 505088 Bad-l4csum: 0 =0A= TX-packets: 508688 TX-dropped: 0 TX-total: 508688=0A= -------------------------------------------------------------------------= ---=0A= =0A= ---------------------- Forward statistics for port 1 -------------------= ---=0A= RX-packets: 508944 RX-dropped: 0 RX-total: 508944=0A= Bad-ipcsum: 0 Bad-l4csum: 508672 =0A= TX-packets: 505103 TX-dropped: 0 TX-total: 505103=0A= -------------------------------------------------------------------------= ---=0A= =0A= +++++++++++++++ Accumulated forward statistics for all ports+++++++++++++= ++=0A= RX-packets: 1014047 RX-dropped: 0 RX-total: 1014047=0A= TX-packets: 1013791 TX-dropped: 0 TX-total: 1013791=0A= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++=0A= =0A= Done.=0A= testpmd> quit=0A= =0A= =0A= [bmbenson]~/1.3.1.1/DPDK% sudo ./x86_64-default-linuxapp-gcc/app/testpmd -c= 0xFF00FF00 -n 4 -b 0000:06:00.0 -- --portmask=3D0x3 --nb-cores=3D2 --enabl= e-rx-cksum --disable-hw-vlan --disable-rss --crc-strip --rxd=3D1024 --txd= =3D1024 --rxfreet=3D64 -i=0A= ... ...=0A= testpmd> set fwd csum=0A= Set csum packet forwarding mode=0A= testpmd> start=0A= csum packet forwarding - CRC stripping enabled - packets/burst=3D16=0A= nb forwarding cores=3D2 - nb forwarding ports=3D2=0A= RX queues=3D1 - RX desc=3D1024 - RX free threshold=3D64=0A= RX threshold registers: pthresh=3D8 hthresh=3D8 wthresh=3D4=0A= TX queues=3D1 - TX desc=3D1024 - TX free threshold=3D0=0A= TX threshold registers: pthresh=3D36 hthresh=3D0 wthresh=3D0=0A= TX RS bit threshold=3D0 - TXQ flags=3D0x0=0A= testpmd> stop=0A= Telling cores to stop...=0A= Waiting for lcores to finish...=0A= =0A= ---------------------- Forward statistics for port 0 -------------------= ---=0A= RX-packets: 314382 RX-dropped: 0 RX-total: 314382=0A= Bad-ipcsum: 314368 Bad-l4csum: 0 =0A= TX-packets: 317453 TX-dropped: 0 TX-total: 317453=0A= -------------------------------------------------------------------------= ---=0A= =0A= ---------------------- Forward statistics for port 1 -------------------= ---=0A= RX-packets: 317492 RX-dropped: 0 RX-total: 317492=0A= Bad-ipcsum: 0 Bad-l4csum: 317440 =0A= TX-packets: 314382 TX-dropped: 0 TX-total: 314382=0A= -------------------------------------------------------------------------= ---=0A= =0A= +++++++++++++++ Accumulated forward statistics for all ports+++++++++++++= ++=0A= RX-packets: 631874 RX-dropped: 0 RX-total: 631874=0A= TX-packets: 631835 TX-dropped: 0 TX-total: 631835=0A= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++=0A= =0A= =0A= ________________________________________=0A= From: Thomas Monjalon [thomas.monjalon@6wind.com]=0A= Sent: Thursday, November 07, 2013 3:44 AM=0A= To: Benson, Bryan=0A= Cc: dev@dpdk.org; LiuFeng=0A= Subject: Re: [dpdk-dev] RX checksum offloading=0A= =0A= 07/11/2013 10:06, Thomas Monjalon :=0A= > 07/11/2013 04:44, Benson, Bryan :=0A= > > RX queues=3D1 - RX desc=3D1024 - RX free threshold=3D16=0A= > >=0A= > > ---------------------- Forward statistics for port 0=0A= > >=0A= > > RX-total: 543761 Bad-ipcsum: 543558 Bad-l4csum: 0=0A= > >=0A= > > ---------------------- Forward statistics for port 1=0A= > >=0A= > > RX-total: 542226 Bad-ipcsum: 0 Bad-l4csum: 542005=0A= > >=0A= > > RX queues=3D1 - RX desc=3D1024 - RX free threshold=3D32=0A= > >=0A= > > ---------------------- Forward statistics for port 0=0A= > >=0A= > > RX-total: 378894 Bad-ipcsum: 0 Bad-l4csum: 0=0A= > >=0A= > > ---------------------- Forward statistics for port 1=0A= > >=0A= > > RX-total: 381197 Bad-ipcsum: 0 Bad-l4csum: 0=0A= >=0A= > Excellent report, thank you !=0A= >=0A= > We need to fix it now :)=0A= =0A= LiuFeng had seen this issue with additonal comments:=0A= http://www.dpdk.org/ml/archives/dev/2013-September/000529.html=0A= =0A= --=0A= Thomas=0A=