From: "Jain, Deepak K" <deepak.k.jain@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Griffin, John" <john.griffin@intel.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/4] cryptodev: add rte_crypto_op_bulk_free function
Date: Mon, 20 Jun 2016 14:30:14 +0000 [thread overview]
Message-ID: <A09C9DDE180C7E429EC68E2BFB95C903393C49EE@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <5472998.Ej0WxNay6E@xps13>
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, June 20, 2016 10:46 AM
> To: Jain, Deepak K <deepak.k.jain@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org; Griffin, John <john.griffin@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 1/4] cryptodev: add
> rte_crypto_op_bulk_free function
>
> 2016-06-16 20:49, Jain, Deepak K:
> > From: Declan Doherty <declan.doherty@intel.com>
> >
> > Adding rte_crypto_op_bulk_free to free up the ops in bulk so as to
> > expect improvement in performance.
> >
> > Signed-off-by: Declan Doherty <declan.doherty@intel.com>
>
> I wonder why these changes are dropped so late?
I agree that these changes got late due to more than expected dubugging time spent on performance code.
I will send v2 of the patches without addition of rte_crypto_op_bulk_free.
>
> > /**
> > + * free crypto operation structure
> > + * If operation has been allocate from a rte_mempool, then the
> > + operation will
> > + * be returned to the mempool.
> > + *
> > + * @param op symmetric crypto operation
> > + */
>
> Please check punctuation, grammar and document every parameters.
Will not need any changes as in v2, this function will be removed.
>
> > +static inline void
> > +rte_crypto_op_bulk_free(struct rte_mempool *mpool, struct
> rte_crypto_op **ops,
> > + uint16_t nb_ops)
next prev parent reply other threads:[~2016-06-20 14:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 19:48 [dpdk-dev] [PATCH 0/4] Extending cryptodev Performance tests Jain, Deepak K
2016-06-16 19:49 ` [dpdk-dev] [PATCH 1/4] cryptodev: add rte_crypto_op_bulk_free function Jain, Deepak K
2016-06-20 9:45 ` Thomas Monjalon
2016-06-20 14:30 ` Jain, Deepak K [this message]
2016-06-16 19:49 ` [dpdk-dev] [PATCH 2/4] app/test: adding Snow3g performance test Jain, Deepak K
2016-06-16 19:49 ` [dpdk-dev] [PATCH 3/4] app/test: updating AES SHA " Jain, Deepak K
2016-06-16 19:49 ` [dpdk-dev] [PATCH 4/4] app/test: typo fixing Jain, Deepak K
2016-06-16 22:13 ` [dpdk-dev] [PATCH 0/4] Extending cryptodev Performance tests De Lara Guarch, Pablo
2016-06-20 14:32 ` [dpdk-dev] [PATCH v2 0/3] " Jain, Deepak K
2016-06-20 14:32 ` [dpdk-dev] [PATCH v2 1/3] app/test: adding Snow3g performance test Jain, Deepak K
2016-06-20 14:32 ` [dpdk-dev] [PATCH v2 2/3] app/test: updating AES SHA " Jain, Deepak K
2016-06-20 14:32 ` [dpdk-dev] [PATCH v2 3/3] app/test: typo fixing Jain, Deepak K
2016-06-20 15:08 ` [dpdk-dev] [PATCH v3 0/3] Extending cryptodev Performance tests Jain, Deepak K
2016-06-20 15:08 ` [dpdk-dev] [PATCH v3 1/3] app/test: adding Snow3g performance test Jain, Deepak K
2016-06-20 15:08 ` [dpdk-dev] [PATCH v3 2/3] app/test: updating AES SHA " Jain, Deepak K
2016-06-20 15:08 ` [dpdk-dev] [PATCH v3 3/3] app/test: typo fixing Jain, Deepak K
2016-06-20 15:24 ` [dpdk-dev] [PATCH v3 0/3] Extending cryptodev Performance tests Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A09C9DDE180C7E429EC68E2BFB95C903393C49EE@IRSMSX107.ger.corp.intel.com \
--to=deepak.k.jain@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=john.griffin@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).