From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9A1B468D1 for ; Mon, 20 Jun 2016 16:30:18 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 20 Jun 2016 07:30:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,498,1459839600"; d="scan'208";a="125340452" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga004.fm.intel.com with ESMTP; 20 Jun 2016 07:30:17 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 20 Jun 2016 15:30:15 +0100 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.96]) by irsmsx155.ger.corp.intel.com ([169.254.14.34]) with mapi id 14.03.0248.002; Mon, 20 Jun 2016 15:30:15 +0100 From: "Jain, Deepak K" To: Thomas Monjalon , "Doherty, Declan" CC: "dev@dpdk.org" , "Griffin, John" , "Trahe, Fiona" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH 1/4] cryptodev: add rte_crypto_op_bulk_free function Thread-Index: AQHRyAgrUed4BA7PtUahz1w6kMhEIp/yECaAgABfc1A= Date: Mon, 20 Jun 2016 14:30:14 +0000 Deferred-Delivery: Mon, 20 Jun 2016 14:30:03 +0000 Message-ID: References: <1466106543-209204-1-git-send-email-deepak.k.jain@intel.com> <1466106543-209204-2-git-send-email-deepak.k.jain@intel.com> <5472998.Ej0WxNay6E@xps13> In-Reply-To: <5472998.Ej0WxNay6E@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzQ2NjYwMDItYjE3Yy00MTY5LWJlNDgtOTEzZDZmZjFjNzk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlFwTDNwNnZmNnJ6RlorNE9KYzJDZVA3SlhPak9Ud09IUWkrWjlUS0xVUnc9In0= x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/4] cryptodev: add rte_crypto_op_bulk_free function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 14:30:19 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, June 20, 2016 10:46 AM > To: Jain, Deepak K ; Doherty, Declan > > Cc: dev@dpdk.org; Griffin, John ; Trahe, Fiona > ; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH 1/4] cryptodev: add > rte_crypto_op_bulk_free function >=20 > 2016-06-16 20:49, Jain, Deepak K: > > From: Declan Doherty > > > > Adding rte_crypto_op_bulk_free to free up the ops in bulk so as to > > expect improvement in performance. > > > > Signed-off-by: Declan Doherty >=20 > I wonder why these changes are dropped so late? I agree that these changes got late due to more than expected dubugging ti= me spent on performance code. I will send v2 of the patches without addition of rte_crypto_op_bulk_free. >=20 > > /** > > + * free crypto operation structure > > + * If operation has been allocate from a rte_mempool, then the > > + operation will > > + * be returned to the mempool. > > + * > > + * @param op symmetric crypto operation > > + */ >=20 > Please check punctuation, grammar and document every parameters. Will not need any changes as in v2, this function will be removed. >=20 > > +static inline void > > +rte_crypto_op_bulk_free(struct rte_mempool *mpool, struct > rte_crypto_op **ops, > > + uint16_t nb_ops)