From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 55B1FFA7A; Thu, 9 Feb 2017 18:18:16 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 09 Feb 2017 09:18:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,137,1484035200"; d="scan'208";a="1105226957" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga001.fm.intel.com with ESMTP; 09 Feb 2017 09:18:14 -0800 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.3]) by IRSMSX108.ger.corp.intel.com ([169.254.11.173]) with mapi id 14.03.0248.002; Thu, 9 Feb 2017 17:18:13 +0000 From: "Jain, Deepak K" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] crypto: fix incorrect key setting Thread-Index: AQHSgZSFoaFYHbWh7kKbuDY0+277sKFg7SfA Date: Thu, 9 Feb 2017 17:18:12 +0000 Deferred-Delivery: Thu, 9 Feb 2017 17:17:57 +0000 Message-ID: References: <1486507798-47652-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1486507798-47652-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTgxZTE0ZWQtOTk3Ni00ODcwLWEzMzYtMjUyYWUwODk5MTdlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJUMVBsS21ZQW9ZMUFEV0RCS2JPYTRVVmNNaFJycHl6SW9SenFxRGFHcUNvPSJ9 x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto: fix incorrect key setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 17:18:17 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, February 7, 2017 10:50 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > stable@dpdk.org > Subject: [dpdk-dev] [PATCH] crypto: fix incorrect key setting >=20 > When ciphering and authenticating in the same operation (cipher-then-auth > or auth-then-cipher), the cipher key and authentication key was set with = the > same key, in SNOW3G, KASUMI and ZUC PMDs. > They were using the key of the first transform structure, instead of usin= g the > keys of the two different transform structures. >=20 > This is not a big issue, since usually, the same key is used for cipherin= g and > authentication, but keys may be different. >=20 > Fixes: 3aafc423cf4d ("snow3g: add driver for SNOW 3G library") > Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library") > Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library") >=20 > CC: stable@dpdk.org > Signed-off-by: Pablo de Lara > --- > drivers/crypto/kasumi/rte_kasumi_pmd.c | 4 ++-- > drivers/crypto/snow3g/rte_snow3g_pmd.c | 4 ++-- > drivers/crypto/zuc/rte_zuc_pmd.c | 6 ++++-- > 3 files changed, 8 insertions(+), 6 deletions(-) >=20 > -- > 2.7.4 Acked-by: Deepak Kumar Jain