From: Andrew Boyer <aboyer@pensando.io> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, Alfredo Cardigliano <cardigliano@ntop.org> Subject: Re: [dpdk-dev] [PATCH v3 3/9] net/ionic: update documentation and MAINTAINERS Date: Wed, 9 Dec 2020 09:36:53 -0500 Message-ID: <A206FCA0-2FF3-4672-AC00-8C89E1214FFD@pensando.io> (raw) In-Reply-To: <8c32bc91-6583-cd3d-a1e6-979bda122eb3@intel.com> Please respond to my questions this time. I have ~70 more patches to post by December 20. > On Dec 9, 2020, at 7:03 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > On 12/4/2020 8:16 PM, Andrew Boyer wrote: >> The UNMAINTAINED flag will be removed in a future patch. >> Signed-off-by: Andrew Boyer <aboyer@pensando.io> >> --- >> MAINTAINERS | 3 ++- >> doc/guides/nics/features/ionic.ini | 2 ++ >> doc/guides/nics/ionic.rst | 13 +++++++------ >> 3 files changed, 11 insertions(+), 7 deletions(-) >> diff --git a/MAINTAINERS b/MAINTAINERS >> index eafe9f8c4..6534983c1 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -841,7 +841,8 @@ F: drivers/net/pfe/ >> F: doc/guides/nics/features/pfe.ini >> Pensando ionic - UNMAINTAINED >> -M: Alfredo Cardigliano <cardigliano@ntop.org> >> +M: Andrew Boyer <aboyer@pensando.io> >> +M: Pensando Drivers <drivers@pensando.io> > > Same comment from previous version, please don't add group as maintainer, only actual people. I responded to your original comment about this back in November. Is there an official DPDK policy against doing this? Is it your preference? We would very much prefer to have this in the file as a fallback. As long as there is still at least one person listed, what is the harm? >> F: drivers/net/ionic/ >> F: doc/guides/nics/ionic.rst >> F: doc/guides/nics/features/ionic.ini >> diff --git a/doc/guides/nics/features/ionic.ini b/doc/guides/nics/features/ionic.ini >> index 083c7bd99..dd29dbed6 100644 >> --- a/doc/guides/nics/features/ionic.ini >> +++ b/doc/guides/nics/features/ionic.ini >> @@ -8,6 +8,7 @@ Speed capabilities = Y >> Link status = Y >> Link status event = Y >> Queue start/stop = Y >> +Lock-free Tx queue = Y > > Are you sure this is supported? > Since it is not advertised as capability, I think this can't be claimed as supported, but still even after this is added as capability, can you please confirm your device supports multiple core enqueue to same queue without locks? I misunderstood the meaning of this flag, will remove. >> MTU update = Y >> Jumbo frame = Y >> Scattered Rx = Y >> @@ -19,6 +20,7 @@ Unicast MAC filter = Y >> RSS hash = Y >> RSS key update = Y >> RSS reta update = Y >> +SR-IOV = Y > > Can you please explain what is exactly supported? Like can DPDK drive both PF & VF? Yes. The PMD does not distinguish between PFs and VFs. > > <...> > >> @@ -7,15 +7,16 @@ IONIC Driver >> The ionic driver provides support for Pensando server adapters. >> It currently supports the below models: >> -- `Naples DSC-25 <https://pensando.io/assets/documents/Naples-25_ProductBrief_10-2019.pdf <https://pensando.io/assets/documents/Naples-25_ProductBrief_10-2019.pdf>>`_ >> -- `Naples DSC-100 <https://pensando.io/assets/documents/Naples_100_ProductBrief-10-2019.pdf <https://pensando.io/assets/documents/Naples_100_ProductBrief-10-2019.pdf>>`_ >> +- DSC-25 dual-port 25G Distributed Services Card >> +- DSC-100 dual-port 100G Distributed Services Card >> > > Same comment from previous version, can you provide link for these devices, it is hard to find the devices from the main site. And my same response from your previous comment. I do not control the website and do not wish to put stale PDF links in this document, which will live forever. The text includes the URL of the page containing links to the PDFs. Why is this not acceptable? -Andrew
next prev parent reply other threads:[~2020-12-09 14:37 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-02 18:35 [dpdk-dev] [PATCH 0/8] net/ionic: minor updates and documentation Andrew Boyer 2020-11-02 18:35 ` [dpdk-dev] [PATCH 1/8] ionic: update documentation and MAINTAINERS Andrew Boyer 2020-11-03 12:35 ` Ferruh Yigit 2020-11-03 14:43 ` Andrew Boyer 2020-11-02 18:35 ` [dpdk-dev] [PATCH 2/8] ionic: connect to the meson build system Andrew Boyer 2020-11-02 18:35 ` [dpdk-dev] [PATCH 3/8] ionic: update ionic_if.h to the latest version Andrew Boyer 2020-11-03 12:44 ` Ferruh Yigit 2020-11-03 14:36 ` Andrew Boyer 2020-11-03 15:55 ` Ferruh Yigit 2020-11-02 18:35 ` [dpdk-dev] [PATCH 4/8] ionic: check for devcmd/admincmd completion more frequently Andrew Boyer 2020-11-02 18:35 ` [dpdk-dev] [PATCH 5/8] ionic: remove some unused fields Andrew Boyer 2020-11-02 18:35 ` [dpdk-dev] [PATCH 6/8] ionic: convert 'deferred' boolean to a flag bit Andrew Boyer 2020-11-02 18:35 ` [dpdk-dev] [PATCH 7/8] ionic: warn if RTE tries to enable loopback mode Andrew Boyer 2020-11-03 12:52 ` Ferruh Yigit 2020-11-02 18:35 ` [dpdk-dev] [PATCH 8/8] ionic: nits - whitespace, logging, helper variables Andrew Boyer 2020-11-03 13:06 ` Ferruh Yigit 2020-11-03 14:00 ` Andrew Boyer 2020-11-03 14:02 ` Ferruh Yigit 2020-11-03 13:11 ` [dpdk-dev] [PATCH 0/8] net/ionic: minor updates and documentation Ferruh Yigit 2020-11-03 14:45 ` Andrew Boyer 2020-12-03 20:34 ` [dpdk-dev] [PATCH v2 0/9] " Andrew Boyer 2020-12-04 20:16 ` [dpdk-dev] [PATCH v3 " Andrew Boyer 2020-12-10 2:07 ` [dpdk-dev] [PATCH v4 " Andrew Boyer 2020-12-10 2:57 ` [dpdk-dev] [PATCH v5 " Andrew Boyer 2020-12-10 12:31 ` Ferruh Yigit 2020-12-10 14:44 ` [dpdk-dev] Patchworks " Andrew Boyer 2020-12-10 15:06 ` Ferruh Yigit 2020-12-10 2:57 ` [dpdk-dev] [PATCH v5 1/9] net/ionic: connect ionic to the build system Andrew Boyer 2020-12-10 2:57 ` [dpdk-dev] [PATCH v5 2/9] net/ionic: update interface file to the latest version Andrew Boyer 2020-12-10 2:57 ` [dpdk-dev] [PATCH v5 3/9] net/ionic: update documentation and MAINTAINERS Andrew Boyer 2020-12-10 12:01 ` Ferruh Yigit 2020-12-10 2:57 ` [dpdk-dev] [PATCH v5 4/9] net/ionic: check for cmd completion more frequently Andrew Boyer 2020-12-10 2:57 ` [dpdk-dev] [PATCH v5 5/9] net/ionic: remove some unused fields Andrew Boyer 2020-12-10 2:57 ` [dpdk-dev] [PATCH v5 6/9] net/ionic: convert 'deferred' boolean to a flag bit Andrew Boyer 2020-12-10 2:57 ` [dpdk-dev] [PATCH v5 7/9] net/ionic: warn if loopback mode is requested Andrew Boyer 2020-12-10 2:57 ` [dpdk-dev] [PATCH v5 8/9] net/ionic: minor refactorings and helper variables Andrew Boyer 2020-12-10 2:57 ` [dpdk-dev] [PATCH v5 9/9] net/ionic: minor logging fixups Andrew Boyer 2020-12-10 2:07 ` [dpdk-dev] [PATCH v4 1/9] net/ionic: connect ionic to the build system Andrew Boyer 2020-12-10 2:07 ` [dpdk-dev] [PATCH v4 2/9] net/ionic: update interface file to the latest version Andrew Boyer 2020-12-10 2:07 ` [dpdk-dev] [PATCH v4 3/9] net/ionic: update documentation and MAINTAINERS Andrew Boyer 2020-12-10 2:07 ` [dpdk-dev] [PATCH v4 4/9] net/ionic: check for cmd completion more frequently Andrew Boyer 2020-12-10 2:07 ` [dpdk-dev] [PATCH v4 5/9] net/ionic: remove some unused fields Andrew Boyer 2020-12-10 2:07 ` [dpdk-dev] [PATCH v4 6/9] net/ionic: convert 'deferred' boolean to a flag bit Andrew Boyer 2020-12-10 2:07 ` [dpdk-dev] [PATCH v4 7/9] net/ionic: warn if loopback mode is requested Andrew Boyer 2020-12-10 2:07 ` [dpdk-dev] [PATCH v4 8/9] net/ionic: minor refactorings and helper variables Andrew Boyer 2020-12-10 2:07 ` [dpdk-dev] [PATCH v4 9/9] net/ionic: minor logging fixups Andrew Boyer 2020-12-04 20:16 ` [dpdk-dev] [PATCH v3 1/9] net/ionic: connect ionic to the build system Andrew Boyer 2020-12-04 20:16 ` [dpdk-dev] [PATCH v3 2/9] net/ionic: update interface file to the latest version Andrew Boyer 2020-12-04 20:16 ` [dpdk-dev] [PATCH v3 3/9] net/ionic: update documentation and MAINTAINERS Andrew Boyer 2020-12-09 12:03 ` Ferruh Yigit 2020-12-09 14:36 ` Andrew Boyer [this message] 2020-12-09 15:24 ` Ferruh Yigit 2020-12-09 16:24 ` Andrew Boyer 2020-12-09 17:15 ` Ferruh Yigit 2020-12-09 19:05 ` Andrew Boyer 2020-12-10 9:23 ` Ferruh Yigit 2020-12-04 20:16 ` [dpdk-dev] [PATCH v3 4/9] net/ionic: check for cmd completion more frequently Andrew Boyer 2020-12-04 20:16 ` [dpdk-dev] [PATCH v3 5/9] net/ionic: remove some unused fields Andrew Boyer 2020-12-04 20:16 ` [dpdk-dev] [PATCH v3 6/9] net/ionic: convert 'deferred' boolean to a flag bit Andrew Boyer 2020-12-04 20:16 ` [dpdk-dev] [PATCH v3 7/9] net/ionic: warn if loopback mode is requested Andrew Boyer 2020-12-04 20:16 ` [dpdk-dev] [PATCH v3 8/9] net/ionic: minor refactorings and helper variables Andrew Boyer 2020-12-09 13:04 ` Ferruh Yigit 2020-12-09 14:39 ` Andrew Boyer 2020-12-09 15:25 ` Ferruh Yigit 2020-12-04 20:16 ` [dpdk-dev] [PATCH v3 9/9] net/ionic: minor logging fixups Andrew Boyer 2020-12-09 13:47 ` Ferruh Yigit 2020-12-09 14:45 ` Andrew Boyer 2020-12-09 15:42 ` Ferruh Yigit 2020-12-09 19:26 ` Andrew Boyer 2020-12-10 9:58 ` Ferruh Yigit 2020-12-03 20:34 ` [dpdk-dev] [PATCH v2 1/9] net/ionic: connect ionic to the build system Andrew Boyer 2020-12-03 20:34 ` [dpdk-dev] [PATCH v2 2/9] net/ionic: update interface file to the latest version Andrew Boyer 2020-12-03 20:34 ` [dpdk-dev] [PATCH v2 3/9] net/ionic: update documentation and MAINTAINERS Andrew Boyer 2020-12-03 20:34 ` [dpdk-dev] [PATCH v2 4/9] net/ionic: check for cmd completion more frequently Andrew Boyer 2020-12-03 20:34 ` [dpdk-dev] [PATCH v2 5/9] net/ionic: remove some unused fields Andrew Boyer 2020-12-03 20:34 ` [dpdk-dev] [PATCH v2 6/9] net/ionic: convert 'deferred' boolean to a flag bit Andrew Boyer 2020-12-03 20:34 ` [dpdk-dev] [PATCH v2 7/9] net/ionic: warn if loopback mode is requested Andrew Boyer 2020-12-03 20:34 ` [dpdk-dev] [PATCH v2 8/9] net/ionic: minor refactorings and helper variables Andrew Boyer 2020-12-03 20:34 ` [dpdk-dev] [PATCH v2 9/9] net/ionic: minor logging fixups Andrew Boyer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=A206FCA0-2FF3-4672-AC00-8C89E1214FFD@pensando.io \ --to=aboyer@pensando.io \ --cc=cardigliano@ntop.org \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git