From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34173A04E6; Wed, 9 Dec 2020 15:37:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 67119C92A; Wed, 9 Dec 2020 15:36:59 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by dpdk.org (Postfix) with ESMTP id 4C907C924 for ; Wed, 9 Dec 2020 15:36:56 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id iq13so979338pjb.3 for ; Wed, 09 Dec 2020 06:36:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=NHPQ+VdqdjuQwNFC3JeoWDif0FmakJzbIwFFidYMY00=; b=H+0JxHdrlXcQYIw5b1874IARGEpSDeW+RR5NPg/z+5JDWIqONaDRIUDowamUg/rNh9 ohwSWHJ3+FlSxmaao92cV71e661+OTbI78yL/HGE+J0GlqFeP8dNEPaRyO/Vz/Domm5Q ks0rj+TvyM5h4pWCdNmJ0dnn4hUjZGfQ8nKyzXHKi2CQGZWX8z1A6TEuPNx3YnCm3afn HIynuct4JvHJN4VbL/3NtS/5wfhv9RPoe9il4oXytZLDxi7Vu/B2riAY0st5prxF/We9 3SmLrnhoDFGqbrJgv6FvB/WfQV/pa6mAJ/MG7qHKc8PxTehZm44BeLSqSiI2ZiBhdnTK A/Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=NHPQ+VdqdjuQwNFC3JeoWDif0FmakJzbIwFFidYMY00=; b=qO5VQHwicKazC8BiBQG6GTK1XVigDDr/zYlGswH2BCbVOI4JZtv35VPk6857rqD4YE 2f9C/9KuvB4h8U8RgBYUrrHrbxgptsShYbOXAJep/prsTTr1Qti16vxNOYVe1v/6l/4w Rg66ukYil/5vW0lwTFPQD/3OTJmnQiEBc6uFaTf+kxUPn4n+w/X9h/D9Gz4pyuY4GrEp upr9ruGM9g9Wcyu0p4F6RnCWLfAoAiz0LAbZLHKvJhz/QqztBE16InOaPXQa/1szQ8FR QDMJOcmp9s7K8FLeWaufLClyLHAX+oRptrqJMmyZdv9zvAGyoIEp2fQNjPhMwWFTwKCC iU1A== X-Gm-Message-State: AOAM530brjvV5LUX9XN2YfqdCXBPQ0QGZa2YYsRFyneVAUGP6CsiQXDF buzl7Ynz77WGHelM2ukY3cO0ug== X-Google-Smtp-Source: ABdhPJwdICRArLu8wBRniddB9FNs5p3fKK4PKfzpflsATToAyCEBFy5RIphgEt+haCDzvazP426zIw== X-Received: by 2002:a17:902:7001:b029:da:bbb6:c7e2 with SMTP id y1-20020a1709027001b02900dabbb6c7e2mr2281667plk.50.1607524615355; Wed, 09 Dec 2020 06:36:55 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:a173:9ff1:703a:6171? ([2600:1700:6b0:fde0:a173:9ff1:703a:6171]) by smtp.gmail.com with ESMTPSA id v186sm2935701pfb.152.2020.12.09.06.36.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2020 06:36:54 -0800 (PST) From: Andrew Boyer Message-Id: Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Date: Wed, 9 Dec 2020 09:36:53 -0500 In-Reply-To: <8c32bc91-6583-cd3d-a1e6-979bda122eb3@intel.com> Cc: dev@dpdk.org, Alfredo Cardigliano To: Ferruh Yigit References: <20201203203418.15064-1-aboyer@pensando.io> <20201204201646.51746-4-aboyer@pensando.io> <8c32bc91-6583-cd3d-a1e6-979bda122eb3@intel.com> X-Mailer: Apple Mail (2.3608.120.23.2.4) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 3/9] net/ionic: update documentation and MAINTAINERS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Please respond to my questions this time. I have ~70 more patches to = post by December 20. > On Dec 9, 2020, at 7:03 AM, Ferruh Yigit = wrote: >=20 > On 12/4/2020 8:16 PM, Andrew Boyer wrote: >> The UNMAINTAINED flag will be removed in a future patch. >> Signed-off-by: Andrew Boyer >> --- >> MAINTAINERS | 3 ++- >> doc/guides/nics/features/ionic.ini | 2 ++ >> doc/guides/nics/ionic.rst | 13 +++++++------ >> 3 files changed, 11 insertions(+), 7 deletions(-) >> diff --git a/MAINTAINERS b/MAINTAINERS >> index eafe9f8c4..6534983c1 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -841,7 +841,8 @@ F: drivers/net/pfe/ >> F: doc/guides/nics/features/pfe.ini >> Pensando ionic - UNMAINTAINED >> -M: Alfredo Cardigliano >> +M: Andrew Boyer >> +M: Pensando Drivers >=20 > Same comment from previous version, please don't add group as = maintainer, only actual people. I responded to your original comment about this back in November. Is = there an official DPDK policy against doing this? Is it your preference? = We would very much prefer to have this in the file as a fallback. As = long as there is still at least one person listed, what is the harm? >> F: drivers/net/ionic/ >> F: doc/guides/nics/ionic.rst >> F: doc/guides/nics/features/ionic.ini >> diff --git a/doc/guides/nics/features/ionic.ini = b/doc/guides/nics/features/ionic.ini >> index 083c7bd99..dd29dbed6 100644 >> --- a/doc/guides/nics/features/ionic.ini >> +++ b/doc/guides/nics/features/ionic.ini >> @@ -8,6 +8,7 @@ Speed capabilities =3D Y >> Link status =3D Y >> Link status event =3D Y >> Queue start/stop =3D Y >> +Lock-free Tx queue =3D Y >=20 > Are you sure this is supported? > Since it is not advertised as capability, I think this can't be = claimed as supported, but still even after this is added as capability, = can you please confirm your device supports multiple core enqueue to = same queue without locks? I misunderstood the meaning of this flag, will remove. >> MTU update =3D Y >> Jumbo frame =3D Y >> Scattered Rx =3D Y >> @@ -19,6 +20,7 @@ Unicast MAC filter =3D Y >> RSS hash =3D Y >> RSS key update =3D Y >> RSS reta update =3D Y >> +SR-IOV =3D Y >=20 > Can you please explain what is exactly supported? Like can DPDK drive = both PF & VF? Yes. The PMD does not distinguish between PFs and VFs. >=20 > <...> >=20 >> @@ -7,15 +7,16 @@ IONIC Driver >> The ionic driver provides support for Pensando server adapters. >> It currently supports the below models: >> -- `Naples DSC-25 = >= `_ >> -- `Naples DSC-100 = = >`_ >> +- DSC-25 dual-port 25G Distributed Services Card >> +- DSC-100 dual-port 100G Distributed Services Card >> =20 >=20 > Same comment from previous version, can you provide link for these = devices, it is hard to find the devices from the main site. And my same response from your previous comment. I do not control the = website and do not wish to put stale PDF links in this document, which = will live forever. The text includes the URL of the page containing = links to the PDFs. Why is this not acceptable? -Andrew