From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 51AC02B8C for ; Tue, 11 Oct 2016 03:47:57 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP; 10 Oct 2016 18:47:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,327,1473145200"; d="scan'208";a="18229993" Received: from kmsmsx155.gar.corp.intel.com ([172.21.73.106]) by fmsmga006.fm.intel.com with ESMTP; 10 Oct 2016 18:47:55 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.149]) by KMSMSX155.gar.corp.intel.com ([169.254.15.114]) with mapi id 14.03.0248.002; Tue, 11 Oct 2016 09:47:54 +0800 From: "Zhao1, Wei" To: Adrien Mazarguil CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC v2] Generic flow director/filtering/classification API Thread-Index: AdIi2dDqP9BHS9xsQjK03nj+YHXhnf//uBuA//6q7HA= Date: Tue, 11 Oct 2016 01:47:53 +0000 Message-ID: References: <20161010131927.GK17252@6wind.com> In-Reply-To: <20161010131927.GK17252@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDQxYTViNWUtNWY3MS00MjZiLWExY2ItMTY3NTQ0OWI1MDc3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9aaVwvQko0UUxDZzRJM2JMN1FMWW4zSjdzUVV6cEdoV3h2Z1RUS2txZXNBPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC v2] Generic flow director/filtering/classification API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 01:47:57 -0000 Hi Adrien Mazarguil, There is a struct rte_flow_action_rss in rte_flow.txt, the member rss= _conf is a pointer type, is there any convenience in using pointer? Why not using struct rte_eth_rss_conf rss_conf type, as rte_flow_item_ipv4= / rte_flow_item_ipv6 struct member? Thank you. struct rte_flow_action_rss { struct rte_eth_rss_conf *rss_conf; /**< RSS parameters. */ uint16_t queues; /**< Number of entries in queue[]. */ uint16_t queue[]; /**< Queues indices to use. */ }; > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Monday, October 10, 2016 9:19 PM > To: Zhao1, Wei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC v2] Generic flow director/filtering/classifi= cation > API >=20 > Hi Wei, >=20 > On Mon, Oct 10, 2016 at 09:42:53AM +0000, Zhao1, Wei wrote: > > Hi Adrien Mazarguil, > > > > In your v2 version of rte_flow.txt , there is an action type > RTE_FLOW_ACTION_TYPE_MARK, but there is no definition of struct > rte_flow_action_mark. > > And there is an definition of struct rte_flow_action_id. Is it a typo = or other > usage? > > > > Thank you. > > > > struct rte_flow_action_id { > > uint32_t id; /**< 32 bit value to return with packets. */ }; >=20 > That is indeed a mistake, this struct should be named > "rte_flow_action_mark". I'll fix it for the next update, thanks. >=20 > -- > Adrien Mazarguil > 6WIND