From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "olivier.matz@6wind.com" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in comment
Date: Tue, 15 Nov 2016 06:54:44 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA01FECD4D@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20264E21B@IRSMSX103.ger.corp.intel.com>
Hi, john
> -----Original Message-----
> From: Mcnamara, John
> Sent: Monday, November 14, 2016 6:30 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: olivier.matz@6wind.com; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in
> comment
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> > Sent: Monday, November 14, 2016 2:47 AM
> > To: dev@dpdk.org
> > Cc: olivier.matz@6wind.com; Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in
> > comment
> >
> > From: zhao wei <wei.zhao1@intel.com>
>
> I think you need to add your name to gitconfig file on the sending machine to
> avoid this "From:"
>
> >
> > There is a redundant repetition word "for" in commnet line the file
> > rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE.
> > The word "for"appear twice in line 359 and 360.One of them is
> > redundant, so delete it.
> >
> > Fixes: 449c49b93a6b ("lib/librte_mempool: mempool: support handler
> > operations")
> >
> > Signed-off-by: zhao wei <wei.zhao1@intel.com>
>
> /commnet/comment/
>
> And same comment as before about the title. Apart from that:
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
>
>
Thank you for your suggestion, I will change as your comment in following patch!
next prev parent reply other threads:[~2016-11-15 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 2:47 Wei Zhao
2016-11-14 10:29 ` Mcnamara, John
2016-11-15 6:54 ` Zhao1, Wei [this message]
2016-11-18 14:15 ` Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA01FECD4D@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).