From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wei.zhao1@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id D7C4210CCE
 for <dev@dpdk.org>; Thu, 22 Dec 2016 10:21:34 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga104.jf.intel.com with ESMTP; 22 Dec 2016 01:21:33 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,387,1477983600"; d="scan'208";a="205667058"
Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14])
 by fmsmga004.fm.intel.com with ESMTP; 22 Dec 2016 01:21:33 -0800
Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.252]) by
 KMSMSX154.gar.corp.intel.com ([169.254.12.58]) with mapi id 14.03.0248.002;
 Thu, 22 Dec 2016 17:19:26 +0800
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filter
Thread-Index: AQHSTIl1UqOHvKDzk0WcYUuowCyJo6EQpf0AgAMpDAA=
Date: Thu, 22 Dec 2016 09:19:25 +0000
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA0200DDDD@PGSMSX103.gar.corp.intel.com>
References: <1480675394-59179-1-git-send-email-wei.zhao1@intel.com>
 <1480675394-59179-16-git-send-email-wei.zhao1@intel.com>
 <fd2a2254-3243-b5eb-6011-4180eb121cdc@intel.com>
In-Reply-To: <fd2a2254-3243-b5eb-6011-4180eb121cdc@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.30.20.206]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Dec 2016 09:21:35 -0000

Hi, Yigit

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, December 21, 2016 1:01 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filt=
er
>=20
> On 12/2/2016 10:43 AM, Wei Zhao wrote:
> > From: wei zhao1 <wei.zhao1@intel.com>
> >
> > check if the rule is a flow director rule, and get the flow director in=
fo.
> >
> > Signed-off-by: wei zhao1 <wei.zhao1@intel.com>
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > ---
>=20
> <...>
>=20
> > +	PATTERN_SKIP_VOID(rule, struct ixgbe_fdir_rule,
> > +			  RTE_FLOW_ERROR_TYPE_ITEM_NUM);
> > +	if (item->type !=3D RTE_FLOW_ITEM_TYPE_ETH &&
> > +	    item->type !=3D RTE_FLOW_ITEM_TYPE_IPV4 &&
> > +	    item->type !=3D RTE_FLOW_ITEM_TYPE_IPV6 &&
> > +	    item->type !=3D RTE_FLOW_ITEM_TYPE_UDP &&
> > +	    item->type !=3D RTE_FLOW_ITEM_TYPE_VXLAN &&
> > +	    item->type !=3D RTE_FLOW_ITEM_TYPE_NVGRE) {
>=20
> This gives build error [1], there are a few more same usage:
>=20
> .../drivers/net/ixgbe/ixgbe_ethdev.c:9238:17: error: comparison of consta=
nt
> 241 with expression of type 'const enum rte_flow_item_type' is always tru=
e
> [-Werror,-Wtautological-constant-out-of-range-compare]
>             item->type !=3D RTE_FLOW_ITEM_TYPE_NVGRE) {
>=20
>=20
>=20

Ok, I will add two type definition RTE_FLOW_ITEM_TYPE_NVGRE and RTE_FLOW_IT=
EM_TYPE_E_TAG  into const enum rte_flow_item_type to eliminate this problem=
.
Thank you.