From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wei.zhao1@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 97B9210DE1
 for <dev@dpdk.org>; Fri, 23 Dec 2016 07:27:32 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga104.jf.intel.com with ESMTP; 22 Dec 2016 22:27:31 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,392,1477983600"; d="scan'208";a="206025280"
Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88])
 by fmsmga004.fm.intel.com with ESMTP; 22 Dec 2016 22:27:30 -0800
Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.52]) by
 KMSMSX153.gar.corp.intel.com ([172.21.73.88]) with mapi id 14.03.0248.002;
 Fri, 23 Dec 2016 14:26:19 +0800
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH 16/18] net/ixgbe: create consistent filter
Thread-Index: AQHSTIl0z5E1Fg8e8UueE6OUeZJynaEQrNyAgASESAA=
Date: Fri, 23 Dec 2016 06:26:18 +0000
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA0201632D@PGSMSX103.gar.corp.intel.com>
References: <1480675394-59179-1-git-send-email-wei.zhao1@intel.com>
 <1480675394-59179-17-git-send-email-wei.zhao1@intel.com>
 <75f8b5f7-d640-6fca-8a94-613f92c527c1@intel.com>
In-Reply-To: <75f8b5f7-d640-6fca-8a94-613f92c527c1@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.30.20.205]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 16/18] net/ixgbe: create consistent filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Dec 2016 06:27:33 -0000

Hi, Yigit

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, December 21, 2016 1:25 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 16/18] net/ixgbe: create consistent filter
>=20
> On 12/2/2016 10:43 AM, Wei Zhao wrote:
> > From: wei zhao1 <wei.zhao1@intel.com>
> >
> > This patch adds a function to create the flow directory filter.
> >
> > Signed-off-by: wei zhao1 <wei.zhao1@intel.com>
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>=20
> <...>
>=20
> > +/**
> > + * Create or destroy a flow rule.
> > + * Theorically one rule can match more than one filters.
> > + * We will let it use the filter which it hitt first.
> > + * So, the sequence matters.
> > + */
> > +struct ixgbe_flow *
> > +ixgbe_flow_create(struct rte_eth_dev *dev,
> > +		  const struct rte_flow_attr *attr,
> > +		  const struct rte_flow_item pattern[],
> > +		  const struct rte_flow_action actions[],
> > +		  struct rte_flow_error *error)
> > +{
> > +	int ret;
> > +	struct rte_eth_ntuple_filter ntuple_filter;
> <...>
> > +	error->type =3D ret;
>=20
> This also returns same ICC error, there are a few more same usage:
>=20
> .../drivers/net/ixgbe/ixgbe_ethdev.c(9764): error #188: enumerated type
> mixed with another type
>         error->type =3D ret;
>                     ^
>=20
>=20
>=20
Thank you for warning,  I will use ICC and gcc two kinds of tool to build m=
y patch in v2 later.=20