From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 86FF82C8 for ; Mon, 26 Dec 2016 02:48:00 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP; 25 Dec 2016 17:47:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,404,1477983600"; d="scan'208";a="22775287" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by orsmga002.jf.intel.com with ESMTP; 25 Dec 2016 17:47:58 -0800 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 26 Dec 2016 09:47:57 +0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.52]) by PGSMSX109.gar.corp.intel.com ([169.254.14.172]) with mapi id 14.03.0248.002; Mon, 26 Dec 2016 09:47:57 +0800 From: "Zhao1, Wei" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter Thread-Index: AQHSTIlmEad9/8ZRgEee5RaOdfYQ2qEQpJwAgAj1uVA= Date: Mon, 26 Dec 2016 01:47:56 +0000 Message-ID: References: <1480675394-59179-1-git-send-email-wei.zhao1@intel.com> <1480675394-59179-2-git-send-email-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2016 01:48:01 -0000 Hi, Ferruh > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, December 21, 2016 12:56 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter >=20 > On 12/2/2016 10:42 AM, Wei Zhao wrote: > > From: wei zhao1 > > > > Add support for storing SYN filter in SW. >=20 > Do you think does it makes more clear to refer as TCP SYN filter? Or SYN = filter > is clear enough? >=20 > > > > Signed-off-by: Wenzhuo Lu > > Signed-off-by: wei zhao1 >=20 > Can you please update sign-off to your actual name? >=20 > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++++++++++-- > > drivers/net/ixgbe/ixgbe_ethdev.h | 2 ++ > > 2 files changed, 12 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index edc9b22..7f10cca 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -1287,6 +1287,8 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev) > > memset(filter_info->fivetuple_mask, 0, > > sizeof(uint32_t) * IXGBE_5TUPLE_ARRAY_SIZE); > > > > + /* initialize SYN filter */ > > + filter_info->syn_info =3D 0; >=20 > can it be an option to memset all filter_info? (and of course move list i= nit > after memset) >=20 > > return 0; > > } > > > > @@ -5509,15 +5511,19 @@ ixgbe_syn_filter_set(struct rte_eth_dev *dev, > > bool add) > > { > > struct ixgbe_hw *hw =3D > > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > + struct ixgbe_filter_info *filter_info =3D > > + IXGBE_DEV_PRIVATE_TO_FILTER_INFO(dev->data- > >dev_private); > > + uint32_t syn_info; > > uint32_t synqf; > > > > if (filter->queue >=3D IXGBE_MAX_RX_QUEUE_NUM) > > return -EINVAL; > > > > + syn_info =3D filter_info->syn_info; > > synqf =3D IXGBE_READ_REG(hw, IXGBE_SYNQF); > > > > if (add) { > > - if (synqf & IXGBE_SYN_FILTER_ENABLE) > > + if (syn_info & IXGBE_SYN_FILTER_ENABLE) >=20 > If these checks will be done on syn_info, shouldn't syn_info be assigned = to > synqf before this. Specially for first usage, synqf may be different than= hw > register. >=20 > Or perhaps can keep continue to use synqf. Since synqf assigned to > filter_info->syn_info after updated. >=20 ok, this code is alittle vague, in "add" branch synqf will be assigned a ne= w value, so "synqf =3D IXGBE_READ_REG(hw, IXGBE_SYNQF)" is useless. synqf read from hw only to be used in "else" branch.so I will make a little= code change here. Thank you for your suggestion. =20 > > return -EINVAL; > > synqf =3D (uint32_t)(((filter->queue << > IXGBE_SYN_FILTER_QUEUE_SHIFT) & > > IXGBE_SYN_FILTER_QUEUE) | > IXGBE_SYN_FILTER_ENABLE); @@ -5527,10 > > +5533,12 @@ ixgbe_syn_filter_set(struct rte_eth_dev *dev, > > else > > synqf &=3D ~IXGBE_SYN_FILTER_SYNQFP; > > } else { > > - if (!(synqf & IXGBE_SYN_FILTER_ENABLE)) > > + if (!(syn_info & IXGBE_SYN_FILTER_ENABLE)) > > return -ENOENT; > > synqf &=3D ~(IXGBE_SYN_FILTER_QUEUE | > IXGBE_SYN_FILTER_ENABLE); > > } > > + > > + filter_info->syn_info =3D synqf; > > IXGBE_WRITE_REG(hw, IXGBE_SYNQF, synqf); > > IXGBE_WRITE_FLUSH(hw); > > return 0; > <...> >=20