From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wei.zhao1@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 6E0002B86
 for <dev@dpdk.org>; Mon, 26 Dec 2016 04:32:15 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP; 25 Dec 2016 19:32:15 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,404,1477983600"; d="scan'208";a="916132525"
Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78])
 by orsmga003.jf.intel.com with ESMTP; 25 Dec 2016 19:32:14 -0800
Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.52]) by
 PGSMSX101.gar.corp.intel.com ([169.254.1.119]) with mapi id 14.03.0248.002;
 Mon, 26 Dec 2016 11:32:13 +0800
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH 04/18] net/ixgbe: restore n-tuple filter
Thread-Index: AQHSTIlpIJci9U6xxk+FY3T+ffnJj6EQpYYAgAj3QfA=
Date: Mon, 26 Dec 2016 03:32:13 +0000
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA02018DE2@PGSMSX103.gar.corp.intel.com>
References: <1480675394-59179-1-git-send-email-wei.zhao1@intel.com>
 <1480675394-59179-5-git-send-email-wei.zhao1@intel.com>
 <c74df55b-d488-c9b3-89e9-37bbffc74d0b@intel.com>
In-Reply-To: <c74df55b-d488-c9b3-89e9-37bbffc74d0b@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.30.20.205]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 04/18] net/ixgbe: restore n-tuple filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Dec 2016 03:32:16 -0000

Hi,  Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, December 21, 2016 12:59 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 04/18] net/ixgbe: restore n-tuple filter
>=20
> On 12/2/2016 10:43 AM, Wei Zhao wrote:
> > From: wei zhao1 <wei.zhao1@intel.com>
> >
> > Add support for restoring n-tuple filter in SW.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > Signed-off-by: wei zhao1 <wei.zhao1@intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 131 +++++++++++++++++++++++++--
> ------------
> >  1 file changed, 83 insertions(+), 48 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> <...>
> > @@ -2482,6 +2496,7 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
> >
> >  	/* resume enabled intr since hw reset */
> >  	ixgbe_enable_intr(dev);
> > +	ixgbe_filter_restore(dev);
>=20
> Just to double check, when you stop the device does 5tuple_filter reset?
> If not reset, will adding same filters cause any problem?

yes, there is reset the NIC function of ixgbe_pf_reset_hw(hw) in dev stop p=
rocess.

>=20
> >
> >  	return 0;
> >
> <...>