From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 14/18] net/ixgbe: parse L2 tunnel filter
Date: Thu, 5 Jan 2017 03:12:01 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA0201B648@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <20170103140759.GA12822@6wind.com>
Hi, adrien
> -----Original Message-----
> From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com]
> Sent: Tuesday, January 3, 2017 10:08 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 14/18] net/ixgbe: parse L2 tunnel filter
>
> Hi Wei,
>
> On Fri, Dec 30, 2016 at 03:53:06PM +0800, Wei Zhao wrote:
> > check if the rule is a L2 tunnel rule, and get the L2 tunnel info.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> >
> > ---
> >
> > v2:
> > --add new error set function
> > --change return value type of parser function
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 269
> +++++++++++++++++++++++++++++++++++----
> > lib/librte_ether/rte_flow.h | 32 +++++
> > 2 files changed, 273 insertions(+), 28 deletions(-)
> [...]
> > diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h
> > index 98084ac..e9e6220 100644
> > --- a/lib/librte_ether/rte_flow.h
> > +++ b/lib/librte_ether/rte_flow.h
> > @@ -268,6 +268,13 @@ enum rte_flow_item_type {
> > * See struct rte_flow_item_vxlan.
> > */
> > RTE_FLOW_ITEM_TYPE_VXLAN,
> > +
> > + /**
> > + * Matches a E_TAG header.
> > + *
> > + * See struct rte_flow_item_e_tag.
> > + */
> > + RTE_FLOW_ITEM_TYPE_E_TAG,
> > };
> >
> > /**
> > @@ -454,6 +461,31 @@ struct rte_flow_item_vxlan { };
> >
> > /**
> > + * RTE_FLOW_ITEM_TYPE_E_TAG.
> > + *
> > + * Matches a E-tag header.
> > + */
> > +struct rte_flow_item_e_tag {
> > + struct ether_addr dst; /**< Destination MAC. */
> > + struct ether_addr src; /**< Source MAC. */
> > + uint16_t e_tag_ethertype; /**< E-tag EtherType, 0x893F. */
> > + uint16_t e_pcp:3; /**< E-PCP */
> > + uint16_t dei:1; /**< DEI */
> > + uint16_t in_e_cid_base:12; /**< Ingress E-CID base */
> > + uint16_t rsv:2; /**< reserved */
> > + uint16_t grp:2; /**< GRP */
> > + uint16_t e_cid_base:12; /**< E-CID base */
> > + uint16_t in_e_cid_ext:8; /**< Ingress E-CID extend */
> > + uint16_t e_cid_ext:8; /**< E-CID extend */
> > + uint16_t type; /**< MAC type. */
> > + unsigned int tags; /**< Number of 802.1Q/ad tags defined. */
> > + struct {
> > + uint16_t tpid; /**< Tag protocol identifier. */
> > + uint16_t tci; /**< Tag control information. */
> > + } tag[]; /**< 802.1Q/ad tag definitions, outermost first. */ };
> [...]
>
> See my previous reply [1], this definition is not endian-safe and comprises
> protocols defined as independent items (namely ETH and VLAN). Here is an
> untested suggestion:
>
> struct rte_flow_item_e_tag {
> uint16_t tpid; /**< Tag protocol identifier (0x893F). */
> /** E-Tag control information (E-TCI). */
> uint16_t epcp_edei_in_ecid_b; /**< E-PCP (3b), E-DEI (1b), ingress E-CID
> base (12b). */
> uint16_t rsvd_grp_ecid_b; /**< Reserved (2b), GRP (2b), E-CID base (12b).
> */
> uint8_t in_ecid_e; /**< Ingress E-CID ext. */
> uint8_t ecid_e; /**< E-CID ext. */
> };
>
> Applications are responsibile for breaking down and filling individual fields
> properly. Ethernet header would be provided as its own item as shown in
> this testpmd flow command example:
>
> flow create 0 ingress pattern eth / e_tag in_ecid_base is 42 / end actions
> drop / end
>
In this case , is eth an option or mandatory?
I think it is optional, because user may do not have any parameter in ETH config.
> Note, all multibyte values are in network order like other protocol header
> definitions.
>
> [1] http://dpdk.org/ml/archives/dev/2016-December/053181.html
> Message ID: 20161223081310.GH10340@6wind.com
>
> --
> Adrien Mazarguil
> 6WIND
next prev parent reply other threads:[~2017-01-05 3:12 UTC|newest]
Thread overview: 149+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 7:52 [dpdk-dev] [PATCH v2 00/18] net/ixgbe: Consistent filter API Wei Zhao
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 01/18] net/ixgbe: store SYN filter Wei Zhao
2017-01-03 14:33 ` Dai, Wei
2017-01-04 1:46 ` Zhao1, Wei
2017-01-06 16:28 ` Ferruh Yigit
2017-01-10 5:33 ` Zhao1, Wei
2017-01-12 8:12 ` [dpdk-dev] [PATCH v3 00/18] net/ixgbe: Consistent filter API Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 04/18] net/ixgbe: restore n-tuple filter Add support for restoring n-tuple filter in SW Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 4/9] " Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 13/18] net/ixgbe: parse TCP SYN filter check if the rule is a TCP SYN rule, and get the SYN info Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 14/18] net/ixgbe: parse L2 tunnel filter check if the rule is a L2 tunnel rule, and get the L2 tunnel info Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 00/18] net/ixgbe: Consistent filter API Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 04/18] net/ixgbe: restore n-tuple filter Add support for restoring n-tuple filter in SW Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 13/18] net/ixgbe: parse TCP SYN filter check if the rule is a TCP SYN rule, and get the SYN info Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 14/18] net/ixgbe: parse L2 tunnel filter check if the rule is a L2 tunnel rule, and get the L2 tunnel info Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 00/18] net/ixgbe: Consistent filter API Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 04/18] net/ixgbe: restore n-tuple filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-12 15:40 ` Ferruh Yigit
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-12 15:39 ` Ferruh Yigit
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 13/18] net/ixgbe: parse TCP SYN filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 14/18] net/ixgbe: parse L2 tunnel filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-12 11:38 ` [dpdk-dev] [PATCH v5 00/18] net/ixgbe: Consistent filter API Xing, Beilei
2017-01-13 6:27 ` Dai, Wei
2017-01-12 15:43 ` Ferruh Yigit
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 " Wei Zhao
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 04/18] net/ixgbe: restore n-tuple filter Wei Zhao
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 13/18] net/ixgbe: parse TCP SYN filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 14/18] net/ixgbe: parse L2 tunnel filter Wei Zhao
2017-01-13 11:18 ` Ferruh Yigit
2017-01-16 13:03 ` Adrien Mazarguil
2017-01-16 16:39 ` Ferruh Yigit
2017-01-16 18:26 ` Adrien Mazarguil
2017-01-17 9:27 ` Zhao1, Wei
2017-01-17 10:03 ` Ferruh Yigit
2017-01-18 1:59 ` Zhao1, Wei
2017-01-18 17:49 ` Ferruh Yigit
2017-01-25 12:17 ` Ferruh Yigit
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-13 15:54 ` [dpdk-dev] [PATCH v6 00/18] net/ixgbe: Consistent filter API Ferruh Yigit
2017-01-15 2:44 ` Lu, Wenzhuo
2017-01-18 11:04 ` Thomas Monjalon
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-02 9:59 ` Xing, Beilei
2017-01-03 3:14 ` Zhao1, Wei
2017-01-03 14:28 ` Dai, Wei
2017-01-04 2:03 ` Zhao1, Wei
2017-01-06 16:31 ` Ferruh Yigit
2017-01-10 5:30 ` Zhao1, Wei
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-02 10:06 ` Xing, Beilei
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 04/18] net/ixgbe: restore n-tuple filter Wei Zhao
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 05/18] net/ixgbe: restore ether type filter Wei Zhao
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 07/18] net/ixgbe: restore flow director filter Wei Zhao
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-02 10:18 ` Xing, Beilei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-06 16:40 ` Ferruh Yigit
2017-01-11 7:51 ` Zhao1, Wei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-02 10:41 ` Xing, Beilei
2017-01-02 10:45 ` Xing, Beilei
2017-01-06 16:55 ` Ferruh Yigit
2017-01-11 8:27 ` Zhao1, Wei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-06 17:11 ` Ferruh Yigit
2017-01-11 8:54 ` Zhao1, Wei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter Wei Zhao
2017-01-06 17:19 ` Ferruh Yigit
2017-01-10 5:46 ` Zhao1, Wei
2017-01-11 9:11 ` Zhao1, Wei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 14/18] net/ixgbe: parse L2 tunnel filter Wei Zhao
2017-01-03 14:07 ` Adrien Mazarguil
2017-01-05 3:12 ` Zhao1, Wei [this message]
2017-01-05 8:52 ` Adrien Mazarguil
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-02 15:24 ` Xing, Beilei
2017-01-03 3:05 ` Zhao1, Wei
2017-01-03 3:19 ` Zhao1, Wei
2017-01-03 14:08 ` Adrien Mazarguil
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-03 2:04 ` Xing, Beilei
2017-01-03 3:11 ` Zhao1, Wei
[not found] ` <94479800C636CB44BD422CB454846E013158D036@SHSMSX101.ccr.corp.intel.com>
2017-01-03 3:09 ` Zhao1, Wei
2017-01-03 5:24 ` Xing, Beilei
2017-01-06 17:26 ` Ferruh Yigit
2017-01-10 5:50 ` Zhao1, Wei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 17/18] net/ixgbe: destroy " Wei Zhao
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 18/18] net/ixgbe: flush all the filter list Wei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA0201B648@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).