From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 382441094 for ; Tue, 10 Jan 2017 07:48:14 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 09 Jan 2017 22:48:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,342,1477983600"; d="scan'208";a="1110391897" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by fmsmga002.fm.intel.com with ESMTP; 09 Jan 2017 22:48:12 -0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.52]) by PGSMSX104.gar.corp.intel.com ([169.254.3.132]) with mapi id 14.03.0248.002; Tue, 10 Jan 2017 14:48:10 +0800 From: "Zhao1, Wei" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter Thread-Index: AQHSTIlmEad9/8ZRgEee5RaOdfYQ2qEQpJwAgAMu0rCAF4CIgIAGLbMw Date: Tue, 10 Jan 2017 06:48:10 +0000 Message-ID: References: <1480675394-59179-1-git-send-email-wei.zhao1@intel.com> <1480675394-59179-2-git-send-email-wei.zhao1@intel.com> <6ec950b1-f4e2-7343-8ba1-60c849695205@intel.com> In-Reply-To: <6ec950b1-f4e2-7343-8ba1-60c849695205@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 06:48:15 -0000 Hi, yigit > -----Original Message----- > From: Yigit, Ferruh > Sent: Saturday, January 7, 2017 12:26 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter >=20 > On 12/22/2016 9:48 AM, Zhao1, Wei wrote: > > Hi, Yigit > > > >> -----Original Message----- > >> From: Yigit, Ferruh > >> Sent: Wednesday, December 21, 2016 12:56 AM > >> To: Zhao1, Wei ; dev@dpdk.org > >> Cc: Lu, Wenzhuo > >> Subject: Re: [dpdk-dev] [PATCH 01/18] net/ixgbe: store SYN filter > >> > >> On 12/2/2016 10:42 AM, Wei Zhao wrote: > >>> From: wei zhao1 > >>> > >>> Add support for storing SYN filter in SW. > >> > >> Do you think does it makes more clear to refer as TCP SYN filter? Or > >> SYN filter is clear enough? > >> > > > > Ok, I will change to " TCP SYN filter " to make it more clear > > > >>> > >>> Signed-off-by: Wenzhuo Lu > >>> Signed-off-by: wei zhao1 > >> > >> Can you please update sign-off to your actual name? > >> > > > > Ok, I will change to " Signed-off-by: Wei Zhao " > > > >>> --- > >>> drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++++++++++-- > >>> drivers/net/ixgbe/ixgbe_ethdev.h | 2 ++ > >>> 2 files changed, 12 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > >>> b/drivers/net/ixgbe/ixgbe_ethdev.c > >>> index edc9b22..7f10cca 100644 > >>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c > >>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > >>> @@ -1287,6 +1287,8 @@ eth_ixgbe_dev_init(struct rte_eth_dev > *eth_dev) > >>> memset(filter_info->fivetuple_mask, 0, > >>> sizeof(uint32_t) * IXGBE_5TUPLE_ARRAY_SIZE); > >>> > >>> + /* initialize SYN filter */ > >>> + filter_info->syn_info =3D 0; > >> > >> can it be an option to memset all filter_info? (and of course move > >> list init after memset) > >> > > > > Maybe, change to the following code? > > > > memset(filter_info, 0, sizeof(struct ixgbe_filter_info)); > > TAILQ_INIT(&filter_info->fivetuple_list); > > > > But that wiil mix /* initialize ether type filter */ and /* initialize > > 5tuple filter list */ two process together, Because struct ixgbe_filte= r_info > store two type info of ether and 5tuple. >=20 > I see filter info consist of different filter types, but as far as I can = see they are > not used before this memset, so what is the problem of cleaning all struc= t? >=20 > Currently memset a sub-set of struct, and assigns zero to other field exp= licitly, > and rest remains undefined and unused. I am suggesting memset whole > structure and get rid of zero assignment. >=20 Ok, do as your suggestion in v3. > > So, not to change ? > > > > struct ixgbe_filter_info { > > uint8_t ethertype_mask; /* Bit mask for every used ethertype filter > */ > > /* store used ethertype filters*/ > > struct ixgbe_ethertype_filter > ethertype_filters[IXGBE_MAX_ETQF_FILTERS]; > > /* Bit mask for every used 5tuple filter */ > > uint32_t fivetuple_mask[IXGBE_5TUPLE_ARRAY_SIZE]; > > struct ixgbe_5tuple_filter_list fivetuple_list; > > /* store the SYN filter info */ > > uint32_t syn_info; > > }; > > > > > <...>