From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wei.zhao1@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 356EF1150
 for <dev@dpdk.org>; Fri,  3 Feb 2017 02:21:49 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga101.jf.intel.com with ESMTP; 02 Feb 2017 17:21:49 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,326,1477983600"; d="scan'208";a="220775327"
Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87])
 by fmsmga004.fm.intel.com with ESMTP; 02 Feb 2017 17:21:48 -0800
Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.72]) by
 KMSMSX152.gar.corp.intel.com ([169.254.11.37]) with mapi id 14.03.0248.002;
 Fri, 3 Feb 2017 09:21:47 +0800
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: zhao wei <wei.zhao1@gmail.com>
Thread-Topic: [dpdk-dev] [PATCH v1] net/ixgbe: add more check in n-tuple filter
Thread-Index: AQHSdSoNcAOs8UIua0+1SYN7l75qzqFFdmGAgBEWcJA=
Date: Fri, 3 Feb 2017 01:21:46 +0000
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA0203FC25@PGSMSX103.gar.corp.intel.com>
References: <1485142340-49032-1-git-send-email-wei.zhao1@intel.com>
 <0909b05d-2058-b51a-f974-f2d686392a5d@intel.com>
In-Reply-To: <0909b05d-2058-b51a-f974-f2d686392a5d@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.30.20.205]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: add more check in n-tuple
 filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Feb 2017 01:21:50 -0000

Hi,  Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, January 23, 2017 8:23 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: zhao wei <wei.zhao1@gmail.com>
> Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: add more check in n-tuple
> filter
>=20
> On 1/23/2017 3:32 AM, Wei Zhao wrote:
> > Add more check on the mask of src_addr, dst_addr and next_proto_id in
> > n-tuple filter rule pattern parser.If do not add such check, it maybe
> > cause error in pattern parser.
> >
> > Signed-off-by: zhao wei <wei.zhao1@gmail.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_flow.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > b/drivers/net/ixgbe/ixgbe_flow.c index 82aceed..8f78eee 100644
> > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > @@ -331,7 +331,10 @@ cons_parse_ntuple_filter(const struct
> rte_flow_attr *attr,
> >  	    ipv4_mask->hdr.packet_id ||
> >  	    ipv4_mask->hdr.fragment_offset ||
> >  	    ipv4_mask->hdr.time_to_live ||
> > -	    ipv4_mask->hdr.hdr_checksum) {
> > +	    ipv4_mask->hdr.hdr_checksum ||
> > +	    !ipv4_mask->hdr.next_proto_id ||
> > +	    !ipv4_mask->hdr.dst_addr ||
> > +	    !ipv4_mask->hdr.src_addr ||) {
>=20
> The '||' at the end seems extra.
>=20
> Also can you please confirm your sign off?
>=20
> >  			rte_flow_error_set(error,
> >  			EINVAL, RTE_FLOW_ERROR_TYPE_ITEM,
> >  			item, "Not supported by ntuple filter");
> >

This patch has been change to suspended on patchwork net.
Thank you.