From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 721D72C35 for ; Mon, 6 Mar 2017 08:44:35 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2017 23:44:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,252,1484035200"; d="scan'208";a="1105214848" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga001.jf.intel.com with ESMTP; 05 Mar 2017 23:44:33 -0800 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 6 Mar 2017 15:44:15 +0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.72]) by PGSMSX109.gar.corp.intel.com ([169.254.14.172]) with mapi id 14.03.0248.002; Mon, 6 Mar 2017 15:44:14 +0800 From: "Zhao1, Wei" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH 2/2] net/ixgbe: add mac type check for all filters Thread-Index: AQHShcycpsd7TpDSyUCAnHLaRVOb2aFs3F6AgBqwoAA= Date: Mon, 6 Mar 2017 07:44:14 +0000 Message-ID: References: <1486971319-59788-1-git-send-email-wei.zhao1@intel.com> <30c77873-18e6-9d2e-65d2-201c534ec554@intel.com> In-Reply-To: <30c77873-18e6-9d2e-65d2-201c534ec554@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: add mac type check for all filters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 07:44:36 -0000 Hi, Ferruh > -----Original Message----- > From: Yigit, Ferruh > Sent: Saturday, February 18, 2017 12:01 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: add mac type check for all > filters >=20 > On 2/13/2017 7:35 AM, Wei Zhao wrote: > > All kinds of filter need to hardware mac type check to make sure the > > hardware support that type of fliter. > > If not, it may cause serious issue. > > > > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") > > Fixes: 672be56d76a2 ("net/ixgbe: parse n-tuple filter") > > Fixes: eb3539fc8550 ("net/ixgbe: parse ethertype filter") > > Fixes: 429f6ebb42cc ("net/ixgbe: parse TCP SYN filter") > > > > Signed-off-by: Wei Zhao > > Signed-off-by: Wenzhuo Lu > > --- > > drivers/net/ixgbe/ixgbe_flow.c | 129 > > +++++++++++++++++++++-------------------- > > 1 file changed, 65 insertions(+), 64 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c > > b/drivers/net/ixgbe/ixgbe_flow.c index 5a634d3..f414fa8 100644 > > --- a/drivers/net/ixgbe/ixgbe_flow.c > > +++ b/drivers/net/ixgbe/ixgbe_flow.c > > @@ -84,11 +84,12 @@ cons_parse_ntuple_filter(const struct rte_flow_attr > *attr, > > struct rte_eth_ntuple_filter *filter, > > struct rte_flow_error *error); > > static int > > -ixgbe_parse_ntuple_filter(const struct rte_flow_attr *attr, > > - const struct rte_flow_item pattern[], > > - const struct rte_flow_action actions[], > > - struct rte_eth_ntuple_filter *filter, > > - struct rte_flow_error *error); > > +ixgbe_parse_ntuple_filter(struct rte_eth_dev *dev, > > + const struct rte_flow_attr *attr, > > + const struct rte_flow_item pattern[], > > + const struct rte_flow_action actions[], > > + struct rte_eth_ntuple_filter *filter, > > + struct rte_flow_error *error); >=20 > Hi Wei, >=20 > You don't need these function declarations at all. What do you think > removing these first, in a separate patch, and won't need to update them > here? >=20 > Also it is possible to remove all function declarations if you move > "ixgbe_flow_ops" at the end of the file, that would be something I prefer= , > but it is your call. >=20 > Thanks, > Ferruh Sorry for late reply, I have just find your mail just now. I think your suggestion is very good from code style, but this patch is a = fix patch set for a P2 issue. So, it is not focus on code style. code style can be changed in a separate patch if we need to and not mix them together?