From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2C9D92BAE for ; Mon, 24 Apr 2017 05:15:53 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2017 20:15:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,242,1488873600"; d="scan'208";a="93305593" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga006.fm.intel.com with ESMTP; 23 Apr 2017 20:15:52 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.175]) by PGSMSX101.gar.corp.intel.com ([169.254.1.174]) with mapi id 14.03.0319.002; Mon, 24 Apr 2017 11:15:51 +0800 From: "Zhao1, Wei" To: Yuanhan Liu , Thomas Monjalon CC: "dev@dpdk.org" , "Ananyev, Konstantin" , "Mcnamara, John" , "Lu, Wenzhuo" , "Liu, Yu Y" Thread-Topic: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset Thread-Index: AQHSqTm8K6Xc/Z+bh0WPnxNjoB7PqKGtRo6AgAplLjCAFbSeAIAAugdggACayYCAAGSYgIAAjhsA//+C4oCABDoGAIAAmeOQ Date: Mon, 24 Apr 2017 03:15:50 +0000 Message-ID: References: <1490866456-52241-1-git-send-email-wei.zhao1@intel.com> <1581788.2CBIGuQB5e@xps> <7495505.68D2QY7hX0@xps> <20170424020120.GC11512@yliu-dev.sh.intel.com> In-Reply-To: <20170424020120.GC11512@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Apr 2017 03:15:54 -0000 Hi, yuanhan & thomas > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Monday, April 24, 2017 10:01 AM > To: Thomas Monjalon > Cc: Zhao1, Wei ; dev@dpdk.org; Ananyev, > Konstantin ; Mcnamara, John > ; Lu, Wenzhuo ; Liu, > Yu Y > Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for = port > reset >=20 > On Fri, Apr 21, 2017 at 11:28:37AM +0200, Thomas Monjalon wrote: > > > Maybe I should add some words in doc\guides\nics\i40e.rst to Record > > > which configurations are saved and restored by the PMD driver in > > > reset function. Which not list in that are recognized as not saved > > > and restored by default. OTHER NIC for this feature can add similar > > > record in their xxx.rst. > > > > No, when defining a generic API in ethdev, we must define the same > > behaviour for every drivers. >=20 > Agreed. That was my point. >=20 > --yliu >=20 > > Please check how to make the behaviour consistent and documented in > > ethdev. We may need to document your new function and start/stop also. Maybe I should record these reset and restore info in some doc in rte layer= . And we have only implement this feature in i40e NIC by now.