From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4377E1B214 for ; Tue, 10 Oct 2017 03:45:57 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2017 18:45:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,502,1500966000"; d="scan'208";a="160800222" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by fmsmga005.fm.intel.com with ESMTP; 09 Oct 2017 18:45:55 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.203]) by PGSMSX104.gar.corp.intel.com ([169.254.3.185]) with mapi id 14.03.0319.002; Tue, 10 Oct 2017 09:45:54 +0800 From: "Zhao1, Wei" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v7 1/2] net/i40e: queue region set and flush Thread-Index: AQHTOQU6YpthxcvGPUWQAQzvicq8kaLLQyyAgBEdfXA= Date: Tue, 10 Oct 2017 01:45:52 +0000 Message-ID: References: <1506672718-39160-1-git-send-email-wei.zhao1@intel.com> <1506676584-41030-1-git-send-email-wei.zhao1@intel.com> <1506676584-41030-2-git-send-email-wei.zhao1@intel.com> <9BB6961774997848B5B42BEC655768F810E83C80@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810E83C80@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 1/2] net/i40e: queue region set and flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 01:45:58 -0000 HI, jingjing I will rework code as your comments in v8. > -----Original Message----- > From: Wu, Jingjing > Sent: Friday, September 29, 2017 8:23 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH v7 1/2] net/i40e: queue region set and flu= sh >=20 >=20 > > + /* update the local VSI info with updated queue map */ > > + (void)rte_memcpy(&vsi->info.tc_mapping, &ctxt.info.tc_mapping, > > + sizeof(vsi->info.tc_mapping)); > > + (void)rte_memcpy(&vsi->info.queue_mapping, > > + &ctxt.info.queue_mapping, > > + sizeof(vsi->info.queue_mapping)); > (void) can be omitted. >=20 > [......] > > +static int > > +i40e_queue_region_display_all_info(struct i40e_pf *pf, uint16_t > > +port_id) { > Not only the function name changes from "get info" to "display info". You > may also need to change the command name. >=20 > But, what I like is changing the keep the "get", but change the function = to > return the a struct which contains the info, and user can call it. Otherw= ise it is > only used for show. >=20 > [.....] > > +enum rte_pmd_i40e_queue_region_op { > > + RTE_PMD_I40E_REGION_UNDEFINED, > > + RTE_PMD_I40E_QUEUE_REGION_SET, /**< add queue region set > */ > > + RTE_PMD_I40E_REGION_FLOWTYPE_SET, /**< add pf region > pctype set */ > > + /*** add queue region user priority set */ >=20 > I think you missed my comments in last mail. NOT "***" but "**", please > read > http://www.dpdk.org/doc/guides/contributing/documentation.html#doxyg > en-guidelines >=20 > > + RTE_PMD_I40E_USER_PRIORITY_REGION_SET, > > + /** > > + * ALL configuration about queue region from up layer > > + * at first will only keep in DPDK softwarestored in driver, > > + * only after " FLUSH_ON ", it commit all configuration to HW. > > + * Because PMD had to set hardware configuration at a time, so > > + * it will record all up layer command at first. > > + */ > > + RTE_PMD_I40E_RSS_QUEUE_REGION_ALL_FLUSH_ON, > > + /** > > + * "FLUSH_OFF " is just clean all configuration about queue > > + * region just now, and restore all to DPDK i40e driver default > > + * config when start up. > > + */ > > + RTE_PMD_I40E_RSS_QUEUE_REGION_ALL_FLUSH_OFF, > > + RTE_PMD_I40E_RSS_QUEUE_REGION_INFO_GET, > > + RTE_PMD_I40E_QUEUE_REGION_OP_MAX > > +}; > > + > > #define RTE_PMD_I40E_DDP_NAME_SIZE 32 > > > > /** > > @@ -146,6 +173,27 @@ struct rte_pmd_i40e_ptype_mapping { }; > > > > /** > > + * Queue region related information. > > + */ > > +struct rte_i40e_rss_region_conf { > > + /*** the region id for this configuration */ >=20 >=20 >=20 > > + uint8_t region_id; > > + /** the pctype or hardware flowtype of packet, > > + * the specific index for each type has been defined > > + * in file i40e_type.h as enum i40e_filter_pctype. > > + */ > > + uint8_t hw_flowtype; > > + /*** the start queue index for this region */ > > + uint8_t queue_start_index; > > + /*** the total queue number of this queue region */ > > + uint8_t queue_num; > > + /*** the packet's user priority for this region */ > > + uint8_t user_priority; > > + /*** Option types of queue region */ > > + enum rte_pmd_i40e_queue_region_op op; >=20 > The same *** -> ** >=20 > Thanks > Jingjing