From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: Ori Kam <orika@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc: update flow filting document
Date: Wed, 31 Jan 2018 02:22:01 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07CA91FB@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <AM4PR05MB1476C3A005E37001C9311AA7DBE40@AM4PR05MB1476.eurprd05.prod.outlook.com>
Hi, Ori Kam
A new v3 has been committed just now, thank you for your review work.
https://dpdk.org/dev/patchwork/patch/34742/
> -----Original Message-----
> From: Ori Kam [mailto:orika@mellanox.com]
> Sent: Tuesday, January 30, 2018 5:22 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> Subject: RE: [PATCH v2] doc: update flow filting document
>
> Hi Wei,
>
> You have a typo in the patch subject and comment, It should be filtering
>
>
> Ori
> > -----Original Message-----
> > From: Wei Zhao [mailto:wei.zhao1@intel.com]
> > Sent: Tuesday, January 30, 2018 9:45 AM
> > To: dev@dpdk.org
> > Cc: Ori Kam <orika@mellanox.com>; stable@dpdk.org;
> > john.mcnamara@intel.com; Wei Zhao <wei.zhao1@intel.com>
> > Subject: [PATCH v2] doc: update flow filting document
> >
> > This patch will update example application of flow_filting document.
> > It add Tx queues configuration related comment.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >
> > ---
> >
> > v2:
> > -change code indentation style.
> > ---
> > doc/guides/sample_app_ug/flow_filtering.rst | 108
> ++++++++++++++++++-
> > ---------
> > 1 file changed, 72 insertions(+), 36 deletions(-)
> >
> > diff --git a/doc/guides/sample_app_ug/flow_filtering.rst
> > b/doc/guides/sample_app_ug/flow_filtering.rst
> > index 725dcb4..b4a1dd7 100644
> > --- a/doc/guides/sample_app_ug/flow_filtering.rst
> > +++ b/doc/guides/sample_app_ug/flow_filtering.rst
> > @@ -167,44 +167,65 @@ application is shown below:
> > struct rte_eth_conf port_conf = {
> > .rxmode = {
> > .split_hdr_size = 0,
> > - /**< Header Split disabled */
> > - .header_split = 0,
> > - /**< IP checksum offload disabled */
> > - .hw_ip_checksum = 0,
> > - /**< VLAN filtering disabled */
> > - .hw_vlan_filter = 0,
> > - /**< Jumbo Frame Support disabled */
> > - .jumbo_frame = 0,
> > - /**< CRC stripped by hardware */
> > - .hw_strip_crc = 1,
> > + .ignore_offload_bitfield = 1,
> > + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> > + },
> > + .txmode = {
> > + .offloads =
> > + DEV_TX_OFFLOAD_VLAN_INSERT |
> > + DEV_TX_OFFLOAD_IPV4_CKSUM |
> > + DEV_TX_OFFLOAD_UDP_CKSUM |
> > + DEV_TX_OFFLOAD_TCP_CKSUM |
> > + DEV_TX_OFFLOAD_SCTP_CKSUM |
> > + DEV_TX_OFFLOAD_TCP_TSO,
> > },
> > };
> > + struct rte_eth_txconf txq_conf;
> > + struct rte_eth_rxconf rxq_conf;
> > + struct rte_eth_dev_info dev_info;
> >
> > printf(":: initializing port: %d\n", port_id);
> > ret = rte_eth_dev_configure(port_id,
> > - nr_queues, nr_queues, &port_conf);
> > + nr_queues, nr_queues, &port_conf);
> > if (ret < 0) {
> > rte_exit(EXIT_FAILURE,
> > ":: cannot configure device: err=%d, port=%u\n",
> > ret, port_id);
> > }
> >
> > + rte_eth_dev_info_get(port_id, &dev_info);
> > + rxq_conf = dev_info.default_rxconf;
> > + rxq_conf.offloads = port_conf.rxmode.offloads;
> > /* only set Rx queues: something we care only so far */
> > for (i = 0; i < nr_queues; i++) {
> > ret = rte_eth_rx_queue_setup(port_id, i, 512,
> > - rte_eth_dev_socket_id(port_id),
> > - NULL,
> > - mbuf_pool);
> > + rte_eth_dev_socket_id(port_id),
> > + &rxq_conf,
> > + mbuf_pool);
> > if (ret < 0) {
> > - rte_exit(EXIT_FAILURE,
> > - ":: Rx queue setup failed: err=%d, port=%u\n",
> > - ret, port_id);
> > + rte_exit(EXIT_FAILURE,
> > + ":: Rx queue setup failed: err=%d,
> > + port=%u\n",
> > + ret, port_id);
> > }
> > }
> >
> > + txq_conf = dev_info.default_txconf;
> > + txq_conf.offloads = port_conf.txmode.offloads;
> >
> > - rte_eth_promiscuous_enable(port_id);
> > + for (i = 0; i < nr_queues; i++) {
> > + ret = rte_eth_tx_queue_setup(port_id, i, 512,
> > + rte_eth_dev_socket_id(port_id),
> > + &txq_conf);
> > + if (ret < 0) {
> > + rte_exit(EXIT_FAILURE,
> > + ":: Tx queue setup failed: err=%d,
> > + port=%u\n",
> > + ret, port_id);
> > + }
> > + }
> >
> > + rte_eth_promiscuous_enable(port_id);
> > ret = rte_eth_dev_start(port_id);
> > if (ret < 0) {
> > rte_exit(EXIT_FAILURE, @@ -223,20 +244,21 @@ The Ethernet
> port
> > is configured with default settings using the .. code-block:: c
> >
> > struct rte_eth_conf port_conf = {
> > - .rxmode = {
> > - .split_hdr_size = 0,
> > - /**< Header Split disabled */
> > - .header_split = 0,
> > - /**< IP checksum offload disabled */
> > - .hw_ip_checksum = 0,
> > - /**< VLAN filtering disabled */
> > - .hw_vlan_filter = 0,
> > - /**< Jumbo Frame Support disabled */
> > - .jumbo_frame = 0,
> > - /**< CRC stripped by hardware */
> > - .hw_strip_crc = 1,
> > - },
> > - };
> > + .rxmode = {
> > + .split_hdr_size = 0,
> > + .ignore_offload_bitfield = 1,
> > + .offloads = DEV_RX_OFFLOAD_CRC_STRIP,
> > + },
> > + .txmode = {
> > + .offloads =
> > + DEV_TX_OFFLOAD_VLAN_INSERT |
> > + DEV_TX_OFFLOAD_IPV4_CKSUM |
> > + DEV_TX_OFFLOAD_UDP_CKSUM |
> > + DEV_TX_OFFLOAD_TCP_CKSUM |
> > + DEV_TX_OFFLOAD_SCTP_CKSUM |
> > + DEV_TX_OFFLOAD_TCP_TSO,
> > + },
> > + };
> >
> > ret = rte_eth_dev_configure(port_id, nr_queues, nr_queues,
> > &port_conf);
> > if (ret < 0) {
> > @@ -244,23 +266,37 @@ The Ethernet port is configured with default
> > settings using the
> > ":: cannot configure device: err=%d, port=%u\n",
> > ret, port_id);
> > }
> > + rte_eth_dev_info_get(port_id, &dev_info);
> > + rxq_conf = dev_info.default_rxconf;
> > + rxq_conf.offloads = port_conf.rxmode.offloads;
> >
> > -For this example we are configuring number of rx queues that are
> > connected to -a single port.
> > +For this example we are configuring number of rx and tx queues that are
> > +connected to a single port.
> >
> > .. code-block:: c
> >
> > for (i = 0; i < nr_queues; i++) {
> > ret = rte_eth_rx_queue_setup(port_id, i, 512,
> > rte_eth_dev_socket_id(port_id),
> > - NULL,
> > + &rxq_conf,
> > mbuf_pool);
> > if (ret < 0) {
> > rte_exit(EXIT_FAILURE,
> > ":: Rx queue setup failed: err=%d, port=%u\n",
> > ret, port_id);
> > }
> > - }
> > + }
> > +
> > + for (i = 0; i < nr_queues; i++) {
> > + ret = rte_eth_tx_queue_setup(port_id, i, 512,
> > + rte_eth_dev_socket_id(port_id),
> > + &txq_conf);
> > + if (ret < 0) {
> > + rte_exit(EXIT_FAILURE,
> > + ":: Tx queue setup failed: err=%d, port=%u\n",
> > + ret, port_id);
> > + }
> > + }
> >
> > In the next step we create and apply the flow rule. which is to send
> packets
> > with destination ip equals to 192.168.1.1 to queue number 1. The detail
> > --
> > 2.9.3
next prev parent reply other threads:[~2018-01-31 2:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 7:32 [dpdk-dev] [PATCH] " Wei Zhao
2018-01-30 7:44 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-01-30 9:22 ` Ori Kam
2018-01-31 2:22 ` Zhao1, Wei [this message]
2018-01-31 2:12 ` [dpdk-dev] [PATCH v3] doc: update flow filtering document Wei Zhao
2018-01-31 6:50 ` Zhang, Helin
2018-01-31 17:24 ` Ferruh Yigit
2018-02-05 15:31 ` Mcnamara, John
2018-02-06 14:18 ` Ferruh Yigit
2018-02-07 8:07 ` Zhao1, Wei
2018-02-07 7:37 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07CA91FB@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=orika@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).