From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 39EED1BB50; Wed, 4 Apr 2018 07:12:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 22:12:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,404,1517904000"; d="scan'208";a="188486961" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by orsmga004.jf.intel.com with ESMTP; 03 Apr 2018 22:12:09 -0700 Received: from pgsmsx101.gar.corp.intel.com ([169.254.1.195]) by KMSMSX153.gar.corp.intel.com ([169.254.5.46]) with mapi id 14.03.0319.002; Wed, 4 Apr 2018 13:12:08 +0800 From: "Zhao1, Wei" To: "Zhang, Qi Z" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: add flow RSS queue index check Thread-Index: AQHTy8ZFtekt6izot0iQslGEPBycX6PvdOQAgACaX/A= Date: Wed, 4 Apr 2018 05:12:08 +0000 Message-ID: References: <1522811927-46772-1-git-send-email-wei.zhao1@intel.com> <039ED4275CED7440929022BC67E706115318212C@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115318212C@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: add flow RSS queue index check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 05:12:13 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, April 4, 2018 11:59 AM > To: Zhao1, Wei ; dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/i40e: add flow RSS queue index check >=20 >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Wednesday, April 4, 2018 11:19 AM > > To: dev@dpdk.org; stable@dpdk.org > > Cc: Zhang, Qi Z ; Zhao1, Wei > > > > Subject: [PATCH] net/i40e: add flow RSS queue index check > > > > There need a queue index check for RSS queue region in order to aviod > > error from configuration. > > > > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > > Signed-off-by: Wei Zhao > > Tested-by: Peng Yuan >=20 > Please add Cc: stable@dpdk.org here. >=20 > > --- > > drivers/net/i40e/i40e_flow.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index f3e8c5f..4e86ecb 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -4249,6 +4249,20 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > > *dev, > > return -rte_errno; > > } > > > > + for (i =3D 0; i < rss->num; i++) { > > + for (j =3D 0; j < rss_info->num; j++) { > > + if (rss->queue[i] =3D=3D rss_info- > >queue[j]) > > + break; > > + } > > + if (j =3D=3D rss_info->num) { > > + rte_flow_error_set(error, EINVAL, > > + > RTE_FLOW_ERROR_TYPE_ACTION, > > + act, > > + "no valid queues"); > > + return -rte_errno; > > + } > > + } >=20 > Is it necessary to add this check inside the big loop ? Ok, I will commit v2 later. >=20 > Btw, the function of i40e_flow_parse_rss_action looks too big and without > enough comment >=20 > It's better to use sub-function or add some comment before each code bloc= k > to make it more readable. >=20 > Regards > Qi >=20 >=20 > > + > > for (i =3D 0; i < info->queue_region_number; i++) { > > if (info->region[i].queue_num =3D=3D rss->num > && > > info->region[i].queue_start_index =3D=3D > > -- > > 2.7.5