From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5131C23A for ; Mon, 7 May 2018 08:30:38 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 May 2018 23:30:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,373,1520924400"; d="scan'208";a="37357610" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by fmsmga007.fm.intel.com with ESMTP; 06 May 2018 23:30:36 -0700 Received: from pgsmsx101.gar.corp.intel.com ([169.254.1.211]) by KMSMSX154.gar.corp.intel.com ([169.254.12.43]) with mapi id 14.03.0319.002; Mon, 7 May 2018 14:30:35 +0800 From: "Zhao1, Wei" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "adrien.mazarguil@6wind.com" Thread-Topic: [PATCH] net/i40e: fix flow RSS key array error Thread-Index: AQHT5cfFASiRNXc78E+N51pAu5zB5qQjR1gAgACGvCA= Date: Mon, 7 May 2018 06:30:34 +0000 Message-ID: References: <1525671240-38485-1-git-send-email-wei.zhao1@intel.com> <039ED4275CED7440929022BC67E70611531AD5BE@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611531AD5BE@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 06:30:38 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, May 7, 2018 2:28 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: adrien.mazarguil@6wind.com > Subject: RE: [PATCH] net/i40e: fix flow RSS key array error >=20 >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Monday, May 7, 2018 1:34 PM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z ; adrien.mazarguil@6wind.com; > > Zhao1, Wei > > Subject: [PATCH] net/i40e: fix flow RSS key array error > > > > This is a bug introduced into RSS key array span. > > > > Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API") >=20 > Is this correct fix line? Looks like a bug already exist at beginning. Be= low > definition is obviously wrong >=20 > uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX > > I40E_PFQF_HKEY_MAX_INDEX ? > I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX)= + > 1 * > sizeof(uint32_t)]; /* Hash key. */' Yes, this is as adrien.mazarguil request. >=20 > > Signed-off-by: Wei Zhao > > --- > > drivers/net/i40e/i40e_ethdev.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.h > > b/drivers/net/i40e/i40e_ethdev.h index 2cccc4f..4dd50eb 100644 > > --- a/drivers/net/i40e/i40e_ethdev.h > > +++ b/drivers/net/i40e/i40e_ethdev.h > > @@ -886,7 +886,7 @@ struct i40e_rte_flow_rss_conf { > > struct rte_flow_action_rss conf; /**< RSS parameters. */ > > uint16_t queue_region_conf; /**< Queue region config flag */ > > uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX > > I40E_PFQF_HKEY_MAX_INDEX ? > > - I40E_VFQF_HKEY_MAX_INDEX : > I40E_PFQF_HKEY_MAX_INDEX) > > + 1 * > > + I40E_VFQF_HKEY_MAX_INDEX : > I40E_PFQF_HKEY_MAX_INDEX > > + 1) * > > sizeof(uint32_t)]; /* Hash key. */ > > uint16_t queue[I40E_MAX_Q_PER_TC]; /**< Queues indices to use. > */ > > }; > > -- > > 2.7.5