* [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error
@ 2018-05-07 5:34 Wei Zhao
2018-05-07 6:27 ` Zhang, Qi Z
2018-05-07 6:40 ` Zhang, Qi Z
0 siblings, 2 replies; 6+ messages in thread
From: Wei Zhao @ 2018-05-07 5:34 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, adrien.mazarguil, Wei Zhao
This is a bug introduced into RSS key array span.
Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/i40e/i40e_ethdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
index 2cccc4f..4dd50eb 100644
--- a/drivers/net/i40e/i40e_ethdev.h
+++ b/drivers/net/i40e/i40e_ethdev.h
@@ -886,7 +886,7 @@ struct i40e_rte_flow_rss_conf {
struct rte_flow_action_rss conf; /**< RSS parameters. */
uint16_t queue_region_conf; /**< Queue region config flag */
uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX > I40E_PFQF_HKEY_MAX_INDEX ?
- I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX) + 1 *
+ I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t)]; /* Hash key. */
uint16_t queue[I40E_MAX_Q_PER_TC]; /**< Queues indices to use. */
};
--
2.7.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error
2018-05-07 5:34 [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error Wei Zhao
@ 2018-05-07 6:27 ` Zhang, Qi Z
2018-05-07 6:30 ` Zhao1, Wei
2018-05-07 6:40 ` Zhang, Qi Z
1 sibling, 1 reply; 6+ messages in thread
From: Zhang, Qi Z @ 2018-05-07 6:27 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: adrien.mazarguil
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, May 7, 2018 1:34 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; adrien.mazarguil@6wind.com; Zhao1,
> Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: fix flow RSS key array error
>
> This is a bug introduced into RSS key array span.
>
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
Is this correct fix line? Looks like a bug already exist at beginning. Below definition is obviously wrong
uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX > I40E_PFQF_HKEY_MAX_INDEX ?
I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX) + 1 *
sizeof(uint32_t)]; /* Hash key. */
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
> index 2cccc4f..4dd50eb 100644
> --- a/drivers/net/i40e/i40e_ethdev.h
> +++ b/drivers/net/i40e/i40e_ethdev.h
> @@ -886,7 +886,7 @@ struct i40e_rte_flow_rss_conf {
> struct rte_flow_action_rss conf; /**< RSS parameters. */
> uint16_t queue_region_conf; /**< Queue region config flag */
> uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX >
> I40E_PFQF_HKEY_MAX_INDEX ?
> - I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX)
> + 1 *
> + I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX
> + 1) *
> sizeof(uint32_t)]; /* Hash key. */
> uint16_t queue[I40E_MAX_Q_PER_TC]; /**< Queues indices to use. */ };
> --
> 2.7.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error
2018-05-07 6:27 ` Zhang, Qi Z
@ 2018-05-07 6:30 ` Zhao1, Wei
2018-05-07 6:35 ` Zhang, Qi Z
0 siblings, 1 reply; 6+ messages in thread
From: Zhao1, Wei @ 2018-05-07 6:30 UTC (permalink / raw)
To: Zhang, Qi Z, dev; +Cc: adrien.mazarguil
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Monday, May 7, 2018 2:28 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: adrien.mazarguil@6wind.com
> Subject: RE: [PATCH] net/i40e: fix flow RSS key array error
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, May 7, 2018 1:34 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; adrien.mazarguil@6wind.com;
> > Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [PATCH] net/i40e: fix flow RSS key array error
> >
> > This is a bug introduced into RSS key array span.
> >
> > Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
>
> Is this correct fix line? Looks like a bug already exist at beginning. Below
> definition is obviously wrong
>
> uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX >
> I40E_PFQF_HKEY_MAX_INDEX ?
> I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX) +
> 1 *
> sizeof(uint32_t)]; /* Hash key. */'
Yes, this is as adrien.mazarguil request.
>
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.h
> > b/drivers/net/i40e/i40e_ethdev.h index 2cccc4f..4dd50eb 100644
> > --- a/drivers/net/i40e/i40e_ethdev.h
> > +++ b/drivers/net/i40e/i40e_ethdev.h
> > @@ -886,7 +886,7 @@ struct i40e_rte_flow_rss_conf {
> > struct rte_flow_action_rss conf; /**< RSS parameters. */
> > uint16_t queue_region_conf; /**< Queue region config flag */
> > uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX >
> I40E_PFQF_HKEY_MAX_INDEX ?
> > - I40E_VFQF_HKEY_MAX_INDEX :
> I40E_PFQF_HKEY_MAX_INDEX)
> > + 1 *
> > + I40E_VFQF_HKEY_MAX_INDEX :
> I40E_PFQF_HKEY_MAX_INDEX
> > + 1) *
> > sizeof(uint32_t)]; /* Hash key. */
> > uint16_t queue[I40E_MAX_Q_PER_TC]; /**< Queues indices to use.
> */
> > };
> > --
> > 2.7.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error
2018-05-07 6:30 ` Zhao1, Wei
@ 2018-05-07 6:35 ` Zhang, Qi Z
0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Qi Z @ 2018-05-07 6:35 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: adrien.mazarguil
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, May 7, 2018 2:31 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org
> Cc: adrien.mazarguil@6wind.com
> Subject: RE: [PATCH] net/i40e: fix flow RSS key array error
>
>
>
> > -----Original Message-----
> > From: Zhang, Qi Z
> > Sent: Monday, May 7, 2018 2:28 PM
> > To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> > Cc: adrien.mazarguil@6wind.com
> > Subject: RE: [PATCH] net/i40e: fix flow RSS key array error
> >
> >
> >
> > > -----Original Message-----
> > > From: Zhao1, Wei
> > > Sent: Monday, May 7, 2018 1:34 PM
> > > To: dev@dpdk.org
> > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; adrien.mazarguil@6wind.com;
> > > Zhao1, Wei <wei.zhao1@intel.com>
> > > Subject: [PATCH] net/i40e: fix flow RSS key array error
> > >
> > > This is a bug introduced into RSS key array span.
> > >
> > > Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow
> > > API")
> >
> > Is this correct fix line? Looks like a bug already exist at beginning.
> > Below definition is obviously wrong
> >
> > uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX >
> > I40E_PFQF_HKEY_MAX_INDEX ?
> > I40E_VFQF_HKEY_MAX_INDEX :
> > I40E_PFQF_HKEY_MAX_INDEX) +
> > 1 *
> > sizeof(uint32_t)]; /* Hash key. */'
>
> Yes, this is as adrien.mazarguil request.
OK, the wrong code is part of the patch.
Thanks
Qi
>
> >
> > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > ---
> > > drivers/net/i40e/i40e_ethdev.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/i40e/i40e_ethdev.h
> > > b/drivers/net/i40e/i40e_ethdev.h index 2cccc4f..4dd50eb 100644
> > > --- a/drivers/net/i40e/i40e_ethdev.h
> > > +++ b/drivers/net/i40e/i40e_ethdev.h
> > > @@ -886,7 +886,7 @@ struct i40e_rte_flow_rss_conf {
> > > struct rte_flow_action_rss conf; /**< RSS parameters. */
> > > uint16_t queue_region_conf; /**< Queue region config flag */
> > > uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX >
> > I40E_PFQF_HKEY_MAX_INDEX ?
> > > - I40E_VFQF_HKEY_MAX_INDEX :
> > I40E_PFQF_HKEY_MAX_INDEX)
> > > + 1 *
> > > + I40E_VFQF_HKEY_MAX_INDEX :
> > I40E_PFQF_HKEY_MAX_INDEX
> > > + 1) *
> > > sizeof(uint32_t)]; /* Hash key. */
> > > uint16_t queue[I40E_MAX_Q_PER_TC]; /**< Queues indices to use.
> > */
> > > };
> > > --
> > > 2.7.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error
2018-05-07 5:34 [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error Wei Zhao
2018-05-07 6:27 ` Zhang, Qi Z
@ 2018-05-07 6:40 ` Zhang, Qi Z
2018-05-08 1:56 ` Zhang, Helin
1 sibling, 1 reply; 6+ messages in thread
From: Zhang, Qi Z @ 2018-05-07 6:40 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: adrien.mazarguil
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, May 7, 2018 1:34 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; adrien.mazarguil@6wind.com; Zhao1,
> Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: fix flow RSS key array error
>
> This is a bug introduced into RSS key array span.
>
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error
2018-05-07 6:40 ` Zhang, Qi Z
@ 2018-05-08 1:56 ` Zhang, Helin
0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Helin @ 2018-05-08 1:56 UTC (permalink / raw)
To: Zhang, Qi Z, Zhao1, Wei, dev; +Cc: adrien.mazarguil
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Monday, May 7, 2018 2:40 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: adrien.mazarguil@6wind.com
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, May 7, 2018 1:34 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; adrien.mazarguil@6wind.com;
> > Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [PATCH] net/i40e: fix flow RSS key array error
> >
> > This is a bug introduced into RSS key array span.
> >
> > Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-08 1:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 5:34 [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error Wei Zhao
2018-05-07 6:27 ` Zhang, Qi Z
2018-05-07 6:30 ` Zhao1, Wei
2018-05-07 6:35 ` Zhang, Qi Z
2018-05-07 6:40 ` Zhang, Qi Z
2018-05-08 1:56 ` Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).