From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C72B81E2C2; Tue, 12 Jun 2018 04:49:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2018 19:49:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,212,1526367600"; d="scan'208";a="66233237" Received: from pgsmsx112.gar.corp.intel.com ([10.108.55.201]) by orsmga002.jf.intel.com with ESMTP; 11 Jun 2018 19:49:09 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.131]) by PGSMSX112.gar.corp.intel.com ([169.254.3.76]) with mapi id 14.03.0319.002; Tue, 12 Jun 2018 10:49:08 +0800 From: "Zhao1, Wei" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR Thread-Index: AQHT/LA6sEDUxUT4+kinmmmuqa/+f6RbaeMAgACGXdD//34agIAAhs1w Date: Tue, 12 Jun 2018 02:49:08 +0000 Message-ID: References: <1528189935-34943-1-git-send-email-wei.zhao1@intel.com> <1528189935-34943-3-git-send-email-wei.zhao1@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B7E83F7@shsmsx102.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B7E8415@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B7E8415@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 02:49:12 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Tuesday, June 12, 2018 10:42 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Tuesday, June 12, 2018 10:31 AM > > To: Lu, Wenzhuo ; dev@dpdk.org > > Cc: stable@dpdk.org > > Subject: RE: [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR > > > > Hi, wenzhuo > > > > > -----Original Message----- > > > From: Lu, Wenzhuo > > > Sent: Tuesday, June 12, 2018 10:26 AM > > > To: Zhao1, Wei ; dev@dpdk.org > > > Cc: stable@dpdk.org > > > Subject: RE: [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR > > > > > > Hi Wei, > > > > > > > > > > -----Original Message----- > > > > From: Zhao1, Wei > > > > Sent: Tuesday, June 5, 2018 5:12 PM > > > > To: dev@dpdk.org > > > > Cc: Lu, Wenzhuo ; stable@dpdk.org; Zhao1, > > > > Wei > > > > Subject: [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR > > > > > > > > In IP mode FDIR, X550 can support not only 4 tuple parameters but > > > > also vlan tci in protocol, so add this feature to flow parser. > > > > > > > > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") > > > > > > > > Signed-off-by: Wei Zhao > > > > --- >=20 > > > > > > > item =3D next_no_void_pattern(pattern, item); > > > > - if (item->type !=3D RTE_FLOW_ITEM_TYPE_IPV4) { > > > > + if (item->type !=3D RTE_FLOW_ITEM_TYPE_IPV4 && > > > > + item->type !=3D RTE_FLOW_ITEM_TYPE_VLAN) > > > { > > > > rte_flow_error_set(error, > > > > EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, > > > > item, "Not supported by ntuple filter"); > > > Really confused. I see the above code is already wrapped by " if > > > (item->type =3D=3D RTE_FLOW_ITEM_TYPE_VLAN) {". You want to support > > double vlan? > > > > No, I have get a report that some use the following mode > > sendp([Ether(dst=3D"A0:36:9F:BD:5D:B0")/Dot1Q(vlan=3D1)/IP(src=3D"192.1= 68.0. > > 1",d st=3D"192.168.0.2",tos=3D2,ttl=3D40)/UDP(dport=3D23, > > sport=3D22)/Raw('x'*100)],iface=3D"enp3s0f0",count=3D10) > > to test fdir IP mode. > > In order to support this, we need this patch. > I can understand the change in ' ixgbe_parse_fdir_filter_normal' is to su= pport > this case. > What I cannot understand is the above change. The original code is alread= y > for the case vlan + IPv4. >=20 If we do not change code as this way, as we do not add " item->type !=3D RT= E_FLOW_ITEM_TYPE_VLAN ". Even there is code which support VLAN in the following code, but it will "= return -rte_errno; " first when user using=20 Ether/ Dot1Q(vlan=3D1)/IP()/UDP mode packet, this error is caused by missin= g " item->type !=3D RTE_FLOW_ITEM_TYPE_VLAN".