From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 548921E25; Mon, 8 Oct 2018 11:49:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2018 02:49:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,356,1534834800"; d="scan'208";a="90114461" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga003.jf.intel.com with ESMTP; 08 Oct 2018 02:49:15 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.13]) by PGSMSX107.gar.corp.intel.com ([169.254.7.83]) with mapi id 14.03.0319.002; Mon, 8 Oct 2018 17:49:13 +0800 From: "Zhao1, Wei" To: Luca Boccassi , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "stable@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set Thread-Index: AQHUJc72WSpAu5LXWUy0rlaWPplFZaUVdlxQgAAV9VA= Date: Mon, 8 Oct 2018 09:49:12 +0000 Message-ID: References: <20180727172607.16890-1-bluca@debian.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 09:49:18 -0000 Add Qi for discussion. > -----Original Message----- > From: Zhao1, Wei > Sent: Monday, October 8, 2018 4:43 PM > To: 'Luca Boccassi' ; dev@dpdk.org > Cc: Lu, Wenzhuo ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en= is > set >=20 > Hi, Luca Boccassi >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Luca Boccassi > > Sent: Saturday, July 28, 2018 1:26 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Luca Boccassi > > ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en > > is set > > > > rx_drop_en is an optimization that does nothing on single-queue > > devices like e1000. Do not force applications that do not care to > > select per-devices >=20 > And aslo, eth_em_rx_queue_setup support set up of multiple queues for > EM device. >=20 > > optimizations flags by returning an error, just log it and carry on. >=20 > rx_drop_en is a flag to enable receive packets drop when insufficient rec= eive > descriptors exist to write the packet into system memory. > if we delete this parameter check protection, it may be misleading some > applications for this point, why does not give some requirement for prope= r > usage of this? I do not suggest for this change. > You can also refer to function eth_igb_rx_queue_setup(), igb device suppo= rt > rx_drop_en set, so we do not have a such parameter check. >=20 > > > > Fixes: 805803445a02 ("e1000: support EM devices (also known as > > e1000/e1000e)") > > Cc: stable@dpdk.org > > > > Signed-off-by: Luca Boccassi > > --- > > drivers/net/e1000/em_rxtx.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c > > index a6b3e92a6..81dc41efb 100644 > > --- a/drivers/net/e1000/em_rxtx.c > > +++ b/drivers/net/e1000/em_rxtx.c > > @@ -1416,12 +1416,13 @@ eth_em_rx_queue_setup(struct rte_eth_dev > *dev, > > } > > > > /* > > - * EM devices don't support drop_en functionality > > + * EM devices don't support drop_en functionality. > > + * It's an optimization that does nothing on single-queue devices, > > + * so just log the issue and carry on. > > */ > > if (rx_conf->rx_drop_en) { > > - PMD_INIT_LOG(ERR, "drop_en functionality not supported > > by " > > + PMD_INIT_LOG(NOTICE, "drop_en functionality not > > supported by " > > "device"); > > - return -EINVAL; > > } > > > > /* Free memory prior to re-allocation if needed. */ > > -- > > 2.18.0