From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/ipv4_multicast: enable multicast promiscuous for all port
Date: Wed, 17 Oct 2018 08:09:17 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07E5068D@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <1539762086-15569-1-git-send-email-wei.zhao1@intel.com>
By the way, I think the maintainer's opinion is important for this change,
but there is no maintainer name for this example in file MAINTAINERS!
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, October 17, 2018 3:41 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] examples/ipv4_multicast: enable multicast promiscuous for
> all port
>
> This example has not been enable for receiving multicast packet, so it will
> drop multicast packet. Users must send packet with ether MAC destination
> address the same as pf port MAC address, in order to forward packet
> successfully, but this is an example for forwarding ipv4 multicastpacket. So
> calling function
> rte_eth_promiscuous_enable() or rte_eth_allmulticast_enable() can enable
> promiscuous mode of all multicast packet. And aslo, DPDK has rte API
> function of rte_eth_dev_set_mc_addr_list() for setting specific multicast
> filter table for specific multicast IP address, but this example do not support
> this configuration, so it need to be enable multicast promiscuous mode
> instead.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> examples/ipv4_multicast/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ipv4_multicast/main.c
> b/examples/ipv4_multicast/main.c index 6530d48..4073a49 100644
> --- a/examples/ipv4_multicast/main.c
> +++ b/examples/ipv4_multicast/main.c
> @@ -773,7 +773,7 @@ main(int argc, char **argv)
> qconf->tx_queue_id[portid] = queueid;
> queueid++;
> }
> -
> + rte_eth_allmulticast_enable(portid);
> /* Start device */
> ret = rte_eth_dev_start(portid);
> if (ret < 0)
> --
> 2.7.5
next prev parent reply other threads:[~2018-10-17 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 7:41 Wei Zhao
2018-10-17 8:09 ` Zhao1, Wei [this message]
2018-10-24 8:11 ` Zhao1, Wei
2018-10-24 8:50 ` Wang, Dong1
2018-10-25 2:07 ` Zhao1, Wei
2018-10-29 2:01 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07E5068D@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).