From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 14F041B3AF; Tue, 23 Oct 2018 11:37:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2018 02:37:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,415,1534834800"; d="scan'208";a="80880092" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by fmsmga008.fm.intel.com with ESMTP; 23 Oct 2018 02:37:53 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.13]) by KMSMSX152.gar.corp.intel.com ([169.254.11.48]) with mapi id 14.03.0319.002; Tue, 23 Oct 2018 17:37:52 +0800 From: "Zhao1, Wei" To: "Iremonger, Bernard" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "stable@dpdk.org" , "Peng, Yuan" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS Thread-Index: AQHUad8f52cWFqowOUaI/N0nXNYhUKUqjpeAgAIFPLA= Date: Tue, 23 Oct 2018 09:37:52 +0000 Message-ID: References: <1540194565-40052-1-git-send-email-wei.zhao1@intel.com> <8CEF83825BEC744B83065625E567D7C260D14A10@IRSMSX107.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D14A10@IRSMSX107.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 09:37:57 -0000 Hi, Iremonger Bernard > -----Original Message----- > From: Iremonger, Bernard > Sent: Monday, October 22, 2018 6:45 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhang, Qi Z ; stable@dpdk.org; Peng, Yuan > ; Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: support more types for flow > RSS >=20 > Hi Zhao, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao > > Sent: Monday, October 22, 2018 8:49 AM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z ; stable@dpdk.org; Peng, Yuan > > ; Zhao1, Wei > > Subject: [dpdk-dev] [PATCH] app/testpmd: support more types for flow > > RSS > > > > Some user and tester require flow RSS to support more types, so and > > "all" and >=20 > typo in commit message "and "all" " should be "add "all"" Yes, I will commit v2 for that.=20 Thank you! >=20 > > "none" to make configuration more easy for users. > > > > Signed-off-by: Wei Zhao > > --- > > app/test-pmd/config.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > > bf3cd0a..f068da1 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd/config.c > > @@ -74,6 +74,10 @@ static const struct { }; > > > > const struct rss_type_info rss_type_table[] =3D { > > + { "all", ETH_RSS_IP | ETH_RSS_TCP | > > + ETH_RSS_UDP | ETH_RSS_SCTP | > > + ETH_RSS_L2_PAYLOAD }, > > + { "none", 0 }, > > { "ipv4", ETH_RSS_IPV4 }, > > { "ipv4-frag", ETH_RSS_FRAG_IPV4 }, > > { "ipv4-tcp", ETH_RSS_NONFRAG_IPV4_TCP }, > > -- > > 2.7.5 >=20 > The "all" and "none" options are already documented in testpmd. > This looks like a fix, if so should there be a fixes line? >=20 Not a fix, this is used by rte_flow command line, not old CLI. > Regards, >=20 > Bernard. >=20