From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5D6344F94 for ; Wed, 14 Nov 2018 10:57:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2018 01:57:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,232,1539673200"; d="scan'208";a="106141458" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by fmsmga004.fm.intel.com with ESMTP; 14 Nov 2018 01:57:44 -0800 Received: from pgsmsx101.gar.corp.intel.com ([169.254.1.244]) by PGSMSX102.gar.corp.intel.com ([169.254.6.33]) with mapi id 14.03.0415.000; Wed, 14 Nov 2018 17:57:43 +0800 From: "Zhao1, Wei" To: Ophir Munk , "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "dev@dpdk.org" , "Peng, Yuan" CC: Asaf Penso , Shahaf Shuler , Thomas Monjalon , Olga Shern , Yongseok Koh Thread-Topic: [PATCH v1] app/testpmd: set default RSS key as NULL Thread-Index: AQHUc42KKl7n13UNvk+JpU+G+ZKXoKVOzRbQgAA/+ZCAAAdV8A== Date: Wed, 14 Nov 2018 09:57:42 +0000 Message-ID: References: <1541260478-4621-1-git-send-email-ophirmu@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: set default RSS key as NULL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 09:57:48 -0000 > -----Original Message----- > From: Ophir Munk [mailto:ophirmu@mellanox.com] > Sent: Wednesday, November 14, 2018 5:20 PM > To: Zhao1, Wei ; Lu, Wenzhuo > ; Wu, Jingjing ; Iremonger, > Bernard ; dev@dpdk.org; Peng, Yuan > > Cc: Asaf Penso ; Shahaf Shuler > ; Thomas Monjalon ; > Olga Shern ; Yongseok Koh > Subject: RE: [PATCH v1] app/testpmd: set default RSS key as NULL >=20 > Hi Zhao, > The patch which causes your crash is already reverted (see [1]). > You can find it with head of next-net or in RC3 (once it is issued). > Please re-test your case after applying the reverting patch. >=20 > Regards, > Ophir >=20 > [1] > Commit 8773db152033 ("app/testpmd: revert setting default RSS") Get, Thanks. >=20 > > -----Original Message----- > > From: Zhao1, Wei [mailto:wei.zhao1@intel.com] > > Sent: Wednesday, November 14, 2018 7:25 AM > > To: Ophir Munk ; Lu, Wenzhuo > > ; Wu, Jingjing ; > > Iremonger, Bernard ; dev@dpdk.org; > Peng, > > Yuan > > Cc: Asaf Penso ; Shahaf Shuler > > ; Thomas Monjalon ; > Olga > > Shern ; Yongseok Koh > > Subject: RE: [PATCH v1] app/testpmd: set default RSS key as NULL > > > > Hi, Ophir Munk > > > > Peng yuan has find this problem with patch , if you use the > > following test step, You will find the problem. > > She is using i40e nic. > > > > ./x86_64-native-linuxapp-gcc/app/testpmd -c 1ffff -n 4 - -i > > --nb-cores=3D8 -- > > rxq=3D4 --txq=3D4 --port-topology=3Dchained ............... > > testpmd> start > > testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp > > testpmd> end key 67108863 / end > > Segmentation fault (core dumped) > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ophir Munk > > > Sent: Saturday, November 3, 2018 11:55 PM > > > To: Lu, Wenzhuo ; Wu, Jingjing > > > ; Iremonger, Bernard > > > ; dev@dpdk.org > > > Cc: Asaf Penso ; Shahaf Shuler > > > ; Thomas Monjalon ; > > Olga > > > Shern ; Ophir Munk ; > > > Yongseok Koh > > > Subject: [dpdk-dev] [PATCH v1] app/testpmd: set default RSS key as > > > NULL > > > > > > When creating an RSS rule without specifying a key (see [1]) it is > > > expected that the device will use the default key. > > > A NULL key is uded to indicate to a PMD it should use its default > > > key, however testpmd assigns a non-NULL dummy key (see [2]) instead. > > > This does not enable testing any PMD behavior when the RSS key is > > > not specified. This commit fixes this limitation by setting key to NU= LL. > > > > > > [1] > > > RSS rule example without specifying a key: > > > flow create 0 ingress / end actions rss queues 0 1 end / > > > end [2] Testpmd default key assignment: > > > .key=3D "testpmd's default RSS hash key, " > > > "override it for better balancing" > > > > > > Signed-off-by: Ophir Munk > > > --- > > > v1: Initial version > > > > > > app/test-pmd/cmdline_flow.c | 15 ++------------- > > > 1 file changed, 2 insertions(+), 13 deletions(-) > > > > > > diff --git a/app/test-pmd/cmdline_flow.c > > > b/app/test-pmd/cmdline_flow.c index 23ea7cc..91e2e35 100644 > > > --- a/app/test-pmd/cmdline_flow.c > > > +++ b/app/test-pmd/cmdline_flow.c > > > @@ -3248,26 +3248,15 @@ static int comp_vc_action_rss_queue(struct > > > context *, const struct token *, > > > .func =3D RTE_ETH_HASH_FUNCTION_DEFAULT, > > > .level =3D 0, > > > .types =3D rss_hf, > > > - .key_len =3D sizeof(action_rss_data->key), > > > + .key_len =3D 0, > > > .queue_num =3D RTE_MIN(nb_rxq, > > > ACTION_RSS_QUEUE_NUM), > > > - .key =3D action_rss_data->key, > > > + .key =3D NULL, > > > .queue =3D action_rss_data->queue, > > > }, > > > - .key =3D "testpmd's default RSS hash key, " > > > - "override it for better balancing", > > > .queue =3D { 0 }, > > > }; > > > for (i =3D 0; i < action_rss_data->conf.queue_num; ++i) > > > action_rss_data->queue[i] =3D i; > > > - if (!port_id_is_invalid(ctx->port, DISABLED_WARN) && > > > - ctx->port !=3D (portid_t)RTE_PORT_ALL) { > > > - struct rte_eth_dev_info info; > > > - > > > - rte_eth_dev_info_get(ctx->port, &info); > > > - action_rss_data->conf.key_len =3D > > > - RTE_MIN(sizeof(action_rss_data->key), > > > - info.hash_key_size); > > > - } > > > action->conf =3D &action_rss_data->conf; > > > return ret; > > > } > > > -- > > > 1.8.3.1