From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C2E8B1B148; Wed, 2 Jan 2019 02:53:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jan 2019 17:53:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,429,1539673200"; d="scan'208";a="113483312" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga008.fm.intel.com with ESMTP; 01 Jan 2019 17:53:34 -0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.64]) by PGSMSX101.gar.corp.intel.com ([169.254.1.84]) with mapi id 14.03.0415.000; Wed, 2 Jan 2019 09:53:33 +0800 From: "Zhao1, Wei" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Lu, Wenzhuo" , "Peng, Yuan" Thread-Topic: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter Thread-Index: AQHUnBiPSFcCRrqdOEeqLHCYGSbZd6Was/oAgACPZUA= Date: Wed, 2 Jan 2019 01:53:32 +0000 Message-ID: References: <1545025982-2065-1-git-send-email-wei.zhao1@intel.com> <1545716688-34608-1-git-send-email-wei.zhao1@intel.com> <1545716688-34608-2-git-send-email-wei.zhao1@intel.com> <039ED4275CED7440929022BC67E706115331096D@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115331096D@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 01:53:37 -0000 Hi, qi =20 > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, January 2, 2019 9:19 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; Lu, Wenzhuo ; Peng, Yuan > > Subject: RE: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter >=20 > HI Wei: >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Tuesday, December 25, 2018 1:45 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Lu, Wenzhuo ; Zhang, Qi Z > > ; Peng, Yuan ; Zhao1, Wei > > > > Subject: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter > > > > There is need for users to use flexible byte filter on x550. > > x550 support IP mode and tunnel mode flexible byte filter. > > tunnel mode flexible byte filter is used for vxlan packets and so on. > > It can be used combined with FDIR tunnel filter. > > By now, ixgbe PMD flow parer code do not support tunnel mode flexible > > byte filter for x550, So I have to enable it in function > ixgbe_parse_fdir_filter_tunnel(). > > Although IP mode flexible byte filter parser is support in function > > ixgbe_parse_fdir_filter_normal(), but some flow like "flow create 0 > > ingress pattern raw pattern is 0xab / end actions queue index 3 / end" > > need to be support, so parser code also need change a little. > > This patch enable all of these feature. >=20 > I would suggest to divide this patch into 3 patches 1. more accurate inpu= t set > mask setup (include all changes in ixgbe_fdir.c) 2. support flexbyte with= out IP > layer (include changes in ixgbe_parse_fdir_filter_normal) 3. support flex= byte > in tunnel mode (include changes in ixgbe_parse_fdir_flilter_tunnel) >=20 > Btw, please make sure to sync the acceptable flow pattern/action descript= ion > above function ixgbe_parse_fdir_filter_xxxxx to their new behaviors There will be 4 patch in this set, because there is other for flow_cmdline = parser, is that ok? >=20 > Thanks > Qi