From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF
Date: Thu, 17 Jan 2019 09:23:36 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07EA16E1@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8wJ2hwxBErBhO1hnP=RfebrQkF+MFuyiN90YLxeV9DFmA@mail.gmail.com>
From: David Marchand [mailto:david.marchand@redhat.com]
Sent: Wednesday, January 16, 2019 4:29 PM
To: Zhao1, Wei <wei.zhao1@intel.com>
Cc: dev@dpdk.org; dpdk stable <stable@dpdk.org>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF
On Wed, Jan 16, 2019 at 6:08 AM Wei Zhao <wei.zhao1@intel.com<mailto:wei.zhao1@intel.com>> wrote:
There is need to enable promiscuous mode enable on VF,
pf host should also enable to support that.
Zhao Wei (3):
net/ixgbe: promiscuous mode enable on VF
net/ixgbe: enable promiscous mode on PF host
net/ixgbe: update API version
drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++
drivers/net/ixgbe/ixgbe_ethdev.h | 1 +
drivers/net/ixgbe/ixgbe_pf.c | 79 +++++++++++++++++++++++++++++-----------
3 files changed, 79 insertions(+), 22 deletions(-)
--
2.7.5
This series looks more about a missing feature than a proper fix.
We have a new pf/vf api supported in this series and a new behaviour for promiscuous.
This is not stable material to me unless you expose a clear problem that this series wants to address.
Yes, this a new feature enable related, but this patch set will not introduce problem, because vf
promiscuous mode is close by default, this set is just send out for request from users that want to use
vf promiscuous. They will open it in their APP. NOT only ixgbe, but also other NIC vf HAS SUPPORT this feature.
--
David Marchand
next prev parent reply other threads:[~2019-01-17 9:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 4:42 Wei Zhao
2019-01-16 4:42 ` [dpdk-dev] [PATCH 1/3] net/ixgbe: " Wei Zhao
2019-01-16 4:42 ` [dpdk-dev] [PATCH 2/3] net/ixgbe: enable promiscous mode on PF host Wei Zhao
2019-01-16 4:42 ` [dpdk-dev] [PATCH 3/3] net/ixgbe: update API version Wei Zhao
2019-01-16 5:01 ` [dpdk-dev] [PATCH v2 0/3] net/ixgbe: promiscuous mode enable on VF Wei Zhao
2019-01-16 5:01 ` [dpdk-dev] [PATCH v2 1/3] " Wei Zhao
2019-02-13 3:35 ` Zhang, Qi Z
2019-02-13 3:36 ` Zhao1, Wei
2019-01-16 5:01 ` [dpdk-dev] [PATCH v2 2/3] net/ixgbe: enable promiscuous mode on PF host Wei Zhao
2019-02-13 3:41 ` Zhang, Qi Z
2019-02-13 3:42 ` Zhao1, Wei
2019-01-16 5:02 ` [dpdk-dev] [PATCH v2 3/3] net/ixgbe: update API version Wei Zhao
2019-02-13 3:43 ` Zhang, Qi Z
2019-02-14 1:22 ` Zhao1, Wei
2019-02-13 7:18 ` [dpdk-dev] [PATCH v3 0/2] net/ixgbe: promiscuous mode enable on VF Wei Zhao
2019-02-13 7:18 ` [dpdk-dev] [PATCH v3 1/2] " Wei Zhao
2019-03-01 7:53 ` Zhang, Qi Z
2019-03-08 3:18 ` Zhao1, Wei
2019-02-13 7:18 ` [dpdk-dev] [PATCH v3 2/2] net/ixgbe: add VF promiscuous mode support when PF as host Wei Zhao
2019-03-08 2:46 ` [dpdk-dev] [PATCH v4 0/2] net/ixgbe: promiscuous mode enable on VF Wei Zhao
2019-03-08 2:46 ` [dpdk-dev] [PATCH v4 1/2] " Wei Zhao
2019-03-08 2:46 ` [dpdk-dev] [PATCH v4 2/2] net/ixgbe: add VF promiscuous mode support when PF as host Wei Zhao
2019-03-08 5:45 ` [dpdk-dev] [PATCH v4 0/2] net/ixgbe: promiscuous mode enable on VF Zhang, Qi Z
2019-01-16 8:28 ` [dpdk-dev] [PATCH 0/3] " David Marchand
2019-01-17 9:23 ` Zhao1, Wei [this message]
2019-01-16 18:59 ` Stephen Hemminger
2019-01-17 9:27 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07EA16E1@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).