From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 188F31B11F; Wed, 13 Feb 2019 04:36:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2019 19:36:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,364,1544515200"; d="scan'208";a="146379847" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by fmsmga001.fm.intel.com with ESMTP; 12 Feb 2019 19:36:07 -0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.6]) by PGSMSX108.gar.corp.intel.com ([169.254.8.83]) with mapi id 14.03.0415.000; Wed, 13 Feb 2019 11:36:02 +0800 From: "Zhao1, Wei" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Lu, Wenzhuo" Thread-Topic: [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF Thread-Index: AQHUrVw5GUFZvK9l3k2jQSNPL7MzFqXcuV0AgACGS/A= Date: Wed, 13 Feb 2019 03:36:02 +0000 Message-ID: References: <1547613775-58027-1-git-send-email-wei.zhao1@intel.com> <1547614920-59680-1-git-send-email-wei.zhao1@intel.com> <1547614920-59680-2-git-send-email-wei.zhao1@intel.com> <039ED4275CED7440929022BC67E7061153333BB6@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153333BB6@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 03:36:09 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, February 13, 2019 11:35 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; Lu, Wenzhuo > Subject: RE: [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF >=20 >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Wednesday, January 16, 2019 1:02 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Lu, Wenzhuo ; Zhang, Qi Z > > ; Zhao1, Wei > > Subject: [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF > > > > There is need to enable two ops of promiscuous_enable and > > promiscuous_disable on VF. > > > > Fixes: af75078fece3 ("first public release") >=20 > I think this is not a fix, we just add some feature not be implemented. >=20 > Btw, you need to update doc/guides/nics/features/ixgbe_vf.ini Ok, I will update in v3 >=20 > > > > Signed-off-by: Wei Zhao > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index 91ba620..e8a2c6e 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -260,6 +260,8 @@ static int > > ixgbevf_dev_rx_queue_intr_disable(struct > > rte_eth_dev *dev, static void ixgbevf_set_ivar_map(struct ixgbe_hw > > *hw, int8_t direction, > > uint8_t queue, uint8_t msix_vector); static > void > > ixgbevf_configure_msix(struct rte_eth_dev *dev); > > +static void ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev); > > +static void ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev); > > static void ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev); > > static void ixgbevf_dev_allmulticast_disable(struct rte_eth_dev *dev); > > > > @@ -596,6 +598,8 @@ static const struct eth_dev_ops > ixgbevf_eth_dev_ops =3D { > > .xstats_get_names =3D ixgbevf_dev_xstats_get_names, > > .dev_close =3D ixgbevf_dev_close, > > .dev_reset =3D ixgbevf_dev_reset, > > + .promiscuous_enable =3D ixgbevf_dev_promiscuous_enable, > > + .promiscuous_disable =3D ixgbevf_dev_promiscuous_disable, > > .allmulticast_enable =3D ixgbevf_dev_allmulticast_enable, > > .allmulticast_disable =3D ixgbevf_dev_allmulticast_disable, > > .dev_infos_get =3D ixgbevf_dev_info_get, > > @@ -8290,6 +8294,22 @@ ixgbe_dev_udp_tunnel_port_del(struct > > rte_eth_dev *dev, } > > > > static void > > +ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev) { > > + struct ixgbe_hw *hw =3D > > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > + > > + hw->mac.ops.update_xcast_mode(hw, > > IXGBEVF_XCAST_MODE_PROMISC); } > > + > > +static void > > +ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev) { > > + struct ixgbe_hw *hw =3D > > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > + > > + hw->mac.ops.update_xcast_mode(hw, > IXGBEVF_XCAST_MODE_NONE); } > > + > > +static void > > ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev) { > > struct ixgbe_hw *hw =3D > > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > -- > > 2.7.5