From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C03E120BD for ; Mon, 25 Feb 2019 03:28:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2019 18:28:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,409,1544515200"; d="scan'208";a="117488768" Received: from pgsmsx111.gar.corp.intel.com ([10.108.55.200]) by orsmga007.jf.intel.com with ESMTP; 24 Feb 2019 18:28:37 -0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.6]) by PGSMSX111.gar.corp.intel.com ([169.254.2.192]) with mapi id 14.03.0415.000; Mon, 25 Feb 2019 10:28:36 +0800 From: "Zhao1, Wei" To: Gareth Bradshaw , "dev@dpdk.org" Thread-Topic: RSS hashing support on ixgbevf Thread-Index: AdTKopqCsb3ibv9cRHC7JUXhx03KmQCDSekQ Date: Mon, 25 Feb 2019 02:28:35 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] RSS hashing support on ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 02:28:40 -0000 Hi, Gareth Bradshaw What you said is not a missing or code bug, because ixgbe do not support= vf port to config his own RSS hash type. It is control by his pf host, it has the same hash type enable configuratio= n as his pf host, so we do not need to expose That in vf code by " dev_info->flow_type_rss_offloads =3D IXGBE_RSS_OFFLOAD= _ALL; " in ixgbevf_dev_info_get. But you can make a reference of i40evf_dev_info_get(), it has " dev_info->f= low_type_rss_offloads =3D ...........", that because=20 I40evf can control his own hash type, and not related to his pf host. These NICs are different in this point. =20 =20 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gareth Bradshaw > Sent: Friday, February 22, 2019 8:01 PM > To: dev@dpdk.org > Subject: [dpdk-dev] RSS hashing support on ixgbevf >=20 > Hi all, >=20 > Does the IXGBE PMD support RSS in the VF? The value of > "dev_info.flow_type_rss_offloads" is 0 for ixgbevf_dev_info_get and > triggers the "invalid argument" check added to rte_eth_dev_configure > (@line 1243). >=20 > The PF equivalent (ixbge_dev_info_get) sets flow_type_rss_offloads to > IXGBE_RSS_OFFLOAD_ALL. >=20 > Wondering if it's just a missing field in dev_info as the eth_dev_ops str= uct for > IXBGEVF exposes the same RSS ops as the PF: >=20 > static const struct eth_dev_ops ixgbevf_eth_dev_ops =3D { > ... > .reta_update =3D ixgbe_dev_rss_reta_update, > .reta_query =3D ixgbe_dev_rss_reta_que= ry, > .rss_hash_update =3D ixgbe_dev_rss_hash_update, > .rss_hash_update =3D ixgbe_dev_rss_hash_update, > .rss_hash_conf_get =3D ixgbe_dev_rss_hash_conf_get, > .rss_hash_conf_get =3D ixgbe_dev_rss_hash_conf_get, > }; >=20 > Thanks > Gareth >=20 >=20 > Technology Strategist > Vectra.AI