From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6164827D for ; Fri, 8 Mar 2019 07:35:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2019 22:35:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,454,1544515200"; d="scan'208";a="150411594" Received: from pgsmsx112-dag.png.intel.com (HELO PGSMSX112.gar.corp.intel.com) ([10.108.55.234]) by fmsmga004.fm.intel.com with ESMTP; 07 Mar 2019 22:35:21 -0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.210]) by PGSMSX112.gar.corp.intel.com ([169.254.3.114]) with mapi id 14.03.0415.000; Fri, 8 Mar 2019 14:35:20 +0800 From: "Zhao1, Wei" To: David Harton , "dev@dpdk.org" , "Lu, Wenzhuo" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef Thread-Index: AQHU1DC8U2nIDIsEMEuKqXAypfzHnKYBSJ4g Date: Fri, 8 Mar 2019 06:35:19 +0000 Message-ID: References: <20190306152355.1697-1-dharton@cisco.com> In-Reply-To: <20190306152355.1697-1-dharton@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 06:35:23 -0000 Hi, David Harton > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton > Sent: Wednesday, March 6, 2019 11:24 PM > To: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, > Konstantin > Cc: David Harton > Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for > ixgbvef >=20 > ixgevf vlan strip and extend capabilities were removed when migrating to = the > bit flags implementation. >=20 > Restoring the capbility to enable these offloads at configuration time. >=20 > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > Signed-off-by: David Harton > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxt= x.c > index e92a70fb3..95c32257c 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev > *dev) > DEV_RX_OFFLOAD_TCP_CKSUM | > DEV_RX_OFFLOAD_KEEP_CRC | > DEV_RX_OFFLOAD_JUMBO_FRAME | > + DEV_RX_OFFLOAD_VLAN_FILTER | > + DEV_RX_OFFLOAD_VLAN_EXTEND | > DEV_RX_OFFLOAD_SCATTER; >=20 Why do we set DEV_RX_OFFLOAD_VLAN_EXTEND for ixgbevf ? =20 It seems Ixgbevf do not support this configuration. Only pf does. But this ixgbe_get_rx_port_offloads () is used by both vf and pf.=20 > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; >=20 > - if (ixgbe_is_vf(dev) =3D=3D 0) > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > - DEV_RX_OFFLOAD_VLAN_EXTEND); > - > /* > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > IOV > * mode. > -- > 2.19.1