From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4934FA054F; Mon, 1 Mar 2021 15:22:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C310922A2A9; Mon, 1 Mar 2021 15:22:10 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id BE48340041 for ; Mon, 1 Mar 2021 15:22:09 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id d12so9057060pfo.7 for ; Mon, 01 Mar 2021 06:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=PyG7H8Ae10NAESB1zzchsa5AEJLai9pDIAtqSRxEoEI=; b=ABIbXetNfmrfswCAqXZyE32T7FQvUvw/XebDuBa2c26Z/yB5XqRgDp/0TsBuPzr+3u B9wJ5buymuhVv7ksskyB0VHNs5wTLU+SOeHvcKtGd+p90Tq11i9ZDDXiOFPnXev0uii6 aqM6kD8qMM7Qen0Xjmq46vABHyFfIuvwas6iEwAwbZWySlliWkyGAaO+QTDftNNPcQuT smvcmlQensIj4gHnCHBeyfht4Mcr+ROc0pURcqm0FMArTmMCZlC2fulvEyrmVCisWsqB U+b3LsTgT+gNVJKTye67bQO6wh70Q4xOBZoWOO3xgeY0pIE0nZZdNpWuzE0sOehIkhw1 ZIKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=PyG7H8Ae10NAESB1zzchsa5AEJLai9pDIAtqSRxEoEI=; b=t7ObYuxxSvhcajhsajPIMS9hTkHzHFztf4knZZdhyi7Ysev7LG1dsCjMULLBWkPv12 f3TUs6Vyn5diBVpMstEPazt165Y6i7NoFWMiI3Kyu8xc7EgEXc9Vs15PS/cH203/xw0M 49AixUwBUUA+gVfvizEIEYURdKowncmmzvvfe6EKVQM4Lv1d2U/53iHYYp3/hHUC9lsN R4TY8lwUOuQ6+B8i6PKskMuHFs3GayjNV5vKau9X4QZXDQ6/jDws4RlulUNvnOAsPtTw DuYQ5HYUvQwjJut8c1QsgqLkUX4FeStH1lq9gEYs+8Vb6g2u0hqhoRkMXMowUMyYvoXU tqKA== X-Gm-Message-State: AOAM5326bDqJ0cfHB0IG0JOV6QoFPRyIxAalkHJiPgSxKDLqcbReJBXU rkf+AYLVqsATfhvm9/O4ANoPJhTsmxviRg== X-Google-Smtp-Source: ABdhPJw+79g7FKlNuBcTTC1XOYwPrjD9nxNFKTGoKq6ovYdNI+jnDATinmINFf5rBe4vVlH8Bb+3jg== X-Received: by 2002:a05:6a00:ad1:b029:1ec:c826:55aa with SMTP id c17-20020a056a000ad1b02901ecc82655aamr14949157pfl.26.1614608528957; Mon, 01 Mar 2021 06:22:08 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:f9bf:8758:4635:1c1c? ([2600:1700:6b0:fde0:f9bf:8758:4635:1c1c]) by smtp.gmail.com with ESMTPSA id n184sm8127535pfd.205.2021.03.01.06.22.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Mar 2021 06:22:08 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) From: Andrew Boyer In-Reply-To: <20210228125353.2436562-8-thomas@monjalon.net> Date: Mon, 1 Mar 2021 09:22:05 -0500 Cc: dev , ncopa@alpinelinux.org, Anatoly Burakov , Stephen Hemminger , Long Li , Jay Zhou , Timothy McDaniel , Rasesh Mody , Shahed Shaikh , Maxime Coquelin , Chenbo Xia , Xiao Wang Content-Transfer-Encoding: 7bit Message-Id: References: <20190313170657.16688-1-ncopa@alpinelinux.org> <20210228125353.2436562-1-thomas@monjalon.net> <20210228125353.2436562-8-thomas@monjalon.net> To: Thomas Monjalon X-Mailer: Apple Mail (2.3608.120.23.2.4) Subject: Re: [dpdk-dev] [PATCH v6 07/17] drivers: replace page size definitions with function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Feb 28, 2021, at 7:53 AM, Thomas Monjalon wrote: > > The page size is often retrieved from the macro PAGE_SIZE. > If PAGE_SIZE is not defined, it is either using hard coded default, > or getting the system value from the UNIX-only function sysconf(). > > Such definitions are replaced with the generic function > rte_mem_page_size() defined for each supported OS. > > Removing PAGE_SIZE definitions will fix dlb drivers for musl libc, > because #ifdef checks were missing, causing redefinition errors. > > Signed-off-by: Thomas Monjalon > --- > drivers/bus/pci/linux/pci_vfio.c | 9 ++------- > drivers/bus/vmbus/linux/vmbus_uio.c | 4 ++-- > drivers/bus/vmbus/private.h | 5 +---- > drivers/bus/vmbus/rte_vmbus_reg.h | 2 +- > drivers/bus/vmbus/vmbus_common_uio.c | 4 ++-- > drivers/crypto/virtio/virtio_pci.h | 3 ++- > drivers/event/dlb/dlb.c | 7 +++++-- > drivers/event/dlb/dlb_priv.h | 2 -- > drivers/event/dlb/pf/base/dlb_osdep.h | 2 +- > drivers/event/dlb/pf/dlb_main.h | 5 +---- > drivers/event/dlb/pf/dlb_pf.c | 10 ++++++---- > drivers/event/dlb2/dlb2_priv.h | 2 -- > drivers/event/dlb2/pf/base/dlb2_osdep.h | 2 +- > drivers/event/dlb2/pf/dlb2_main.h | 5 +---- > drivers/event/dlb2/pf/dlb2_pf.c | 8 ++++---- > drivers/net/bnx2x/ecore_fw_defs.h | 18 ++++++++++++------ > drivers/net/ionic/ionic_lif.c | 25 ++++++++++++++----------- > drivers/net/ionic/ionic_main.c | 3 ++- > drivers/net/ionic/ionic_osdep.h | 2 +- > drivers/net/netvsc/hn_rndis.c | 12 ++++++------ > drivers/net/netvsc/hn_rxtx.c | 10 ++++++---- > drivers/net/netvsc/hn_var.h | 9 +++------ > drivers/net/virtio/virtio.h | 2 +- > drivers/net/virtio/virtio_ethdev.c | 6 +++--- > drivers/net/virtio/virtio_ethdev.h | 4 ---- > drivers/vdpa/ifc/ifcvf_vdpa.c | 17 +++++++---------- > 26 files changed, 84 insertions(+), 94 deletions(-) > OK for net/ionic Acked-by: Andrew Boyer