From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8F8E042528;
	Wed,  6 Sep 2023 11:24:09 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 794DF402AE;
	Wed,  6 Sep 2023 11:24:09 +0200 (CEST)
Received: from smtpbgjp3.qq.com (smtpbgjp3.qq.com [54.92.39.34])
 by mails.dpdk.org (Postfix) with ESMTP id 2D04D4029E
 for <dev@dpdk.org>; Wed,  6 Sep 2023 11:24:06 +0200 (CEST)
X-QQ-mid: bizesmtp77t1693992235t2osnfzg
Received: from LAPTOP96V0OHHN ( [183.81.182.182])
 by bizesmtp.qq.com (ESMTP) with 
 id ; Wed, 06 Sep 2023 17:23:54 +0800 (CST)
X-QQ-SSF: 00400000000000D0F000000A0000000
X-QQ-FEAT: rLH4ENEDMW/7s7aoIL0E78bYDlV9bTRRWtWNrdCC/dNOXI1XFp9yooWncQKNr
 DAxRhbfmPEjcnKib81HBQhSXJSCEn6aMi/WKrEJakyv1d2I+iq/7P7hm+sHwzVTVCKkmQNc
 1XueZS2HPUz+lwd+QEYZ2UFZ/e6OtG0PyFpA9nnvGoub94xXdtWj8k6bzbAwHi2r7cCfmNm
 gNSbnZR/Sh5FOj3+g0uAF4K0GQzuaYgjh+no1xr2PirUkPaML50qSpJ8g7DldZf4PKHL9+m
 OJg6WYZdxcE+v+XUlBXioEFbM7HWEQI9hvyWBBWV3N7ObDbUgLGHijlK2/+W0vQLsr9ATrh
 J105HHXDA4g8R+s9ncXIsJqIbKM+fUCUCo4M/JWuiRH+RG186NgrGHgRi9MQFk8Nt0COAcK
 UNsohCzOBkI=
X-QQ-GoodBg: 2
X-BIZMAIL-ID: 9958315243937622536
From: "11" <caowenbo@mucse.com>
To: "'Ferruh Yigit'" <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <andrew.rybchenko@oktetlabs.ru>,
 <yaojun@mucse.com>
References: <20230901023050.40893-1-caowenbo@mucse.com>
 <20230901023050.40893-6-caowenbo@mucse.com>
 <86934600-d1e3-ad3d-991c-dff0461ddb97@amd.com>
In-Reply-To: <86934600-d1e3-ad3d-991c-dff0461ddb97@amd.com>
Subject: RE: [PATCH v6 5/8] net/rnp add reset code for Chip Init process
Date: Wed, 6 Sep 2023 17:23:55 +0800
Message-ID: <A453AB1F5E21DF49+00d001d9e0a3$dcb1a120$9614e360$@mucse.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Content-Language: zh-cn
Thread-Index: AQI30P9XUj3aWZJ7n+uYhLh06w3v0AGhZs++AeTFD/GvNXJngA==
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:mucse.com:qybglogicsvrgz:qybglogicsvrgz5a-0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi  Ferruh,

Please see the below comment.

Regards Wenbo.
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: 2023=E5=B9=B49=E6=9C=885=E6=97=A5 23:46
> To: Wenbo Cao <caowenbo@mucse.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; andrew.rybchenko@oktetlabs.ru;
> yaojun@mucse.com
> Subject: Re: [PATCH v6 5/8] net/rnp add reset code for Chip Init =
process
>=20
> On 9/1/2023 3:30 AM, Wenbo Cao wrote:
> > we must get the shape info of nic from Firmware for
>=20
> What is "shape info"?
>=20
For the nic 4/8 port mode or one-pcie-one port, media type fiber or =
copper, 10G/1G
"shape info" words may be confused.
> > reset. so the related codes is first get firmware info and then =
reset
> > the chip
> >
>=20
> Is there a specific reason to have "Chip Init" start with uppercase, =
if not please
> make all lowercase, also ':' after domain, like "net/rnp:'.
"Chip Init" is don't have any special meaning, will change the to =
lowercase.