From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A06DA052B; Thu, 30 Jul 2020 04:25:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CD3E2BB9; Thu, 30 Jul 2020 04:25:14 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 926CA2BB8 for ; Thu, 30 Jul 2020 04:25:13 +0200 (CEST) IronPort-SDR: UdPrgetb1orsDTL/PW4SBGowXoB80X6ckaOtWy6yjSrxVkTj3vRojPPQk3jJmxFG3rZUjvy/Fy nkfzHAtj37qg== X-IronPort-AV: E=McAfee;i="6000,8403,9697"; a="236392816" X-IronPort-AV: E=Sophos;i="5.75,412,1589266800"; d="scan'208";a="236392816" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2020 19:25:12 -0700 IronPort-SDR: 897oC9I2FhMmMYj2koHoluc0uK/Q6H0J1esyv3DOM8e4TZ78E6OSSA8Kx7OZu7MhL70CWqxwpd f8WCTlX7ajDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,412,1589266800"; d="scan'208";a="272788683" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 29 Jul 2020 19:25:12 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jul 2020 19:25:12 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jul 2020 19:25:11 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.22]) by shsmsx102.ccr.corp.intel.com ([169.254.2.43]) with mapi id 14.03.0439.000; Thu, 30 Jul 2020 10:25:08 +0800 From: "Zhang, Yuying" To: "dev@dpdk.org" , "olivier.matz@6wind.com" , "Zhang, Qi Z" , "Yang, Qiming" CC: David Marchand Thread-Topic: [PATCH v3 1/1] net: fix bad checksum in offloaded TSOv6 packets Thread-Index: AQHWZhVvMdODXYuZlUKmTo+EIDob+qkfY+SQ Date: Thu, 30 Jul 2020 02:25:07 +0000 Message-ID: References: <20200728085531.204296-1-yuying.zhang@intel.com> <20200730020043.17546-1-yuying.zhang@intel.com> In-Reply-To: <20200730020043.17546-1-yuying.zhang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/1] net: fix bad checksum in offloaded TSOv6 packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Yuying > Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B30=1B$BF|=1B(B 10:01 > To: dev@dpdk.org; olivier.matz@6wind.com; Zhang, Qi Z > ; Yang, Qiming > Cc: Zhang, Yuying ; David Marchand > > Subject: [PATCH v3 1/1] net: fix bad checksum in offloaded TSOv6 packets >=20 > The rte_net_intel_cksum_flags_prepare() function prepares the pseudoheade= r > checksum in packet data when doing checksum or TSO offload. >=20 > It does nothing when no checksum offload flag is set in mbuf. But in case= of a > IPv6/TCP TSO packet, it is not mandatory to have a checksum flag. We also= need > to check the PKT_TX_TCP_SEG flag in addition to checksum flags to fix off= load > preparation for such packets. >=20 > Fixes: 520059a41aa9 ("net: check fragmented headers in non-debug as well"= ) >=20 > Signed-off-by: Yuying Zhang > Acked-by: Olivier Matz > Reviewed-by: David Marchand > --- > lib/librte_net/rte_net.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_net/rte_net.h b/lib/librte_net/rte_net.h index > 1edc283a4..94b06d9ee 100644 > --- a/lib/librte_net/rte_net.h > +++ b/lib/librte_net/rte_net.h > @@ -125,7 +125,7 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, > uint64_t ol_flags) > * Mainly it is required to avoid fragmented headers check if > * no offloads are requested. > */ > - if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK))) > + if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK | > PKT_TX_TCP_SEG))) > return 0; >=20 > if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) > -- > 2.25.1 Please drop this patch since it has been merged into dpdk-next-net/master. I am so sorry.