From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA003A052A; Wed, 27 Jan 2021 18:40:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1519140FDD; Wed, 27 Jan 2021 18:40:11 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id C88B2140FD3 for ; Wed, 27 Jan 2021 18:40:09 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id a20so1679303pjs.1 for ; Wed, 27 Jan 2021 09:40:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ujZ8RfTkP3Hb1bh1uv6UWFJs3MmYJTBitdHyvAEEgTg=; b=J8Wj61Wvc3X5aq/NawSUavmwYQGrrhYB3DXWJ6MigUcVEzqK50ElNcCRCYwCyVt3VF R/S7s3MZiQ7QOS4t3SoXYVk7kNM3PR9XsXq/dqd9XdmM7HWkOjHiZ7E7WzM3fBvx4ypY /gLVT2UBGLZw8mfhcHCe63/Y6gNDAeP2saxzCh58RRGi1+VwPE3NxyoZVdUod2DHx2ug Hh0QHsSFJ2UUcwsD3JVuj2lQnnzhhgujBgYwfmQ3zgI7KvE9gHGZiYhGnwvw+6IHifso zkrW2dtDw61nY1Ekw/TeCOePRt7O7bVFv4e6c/BWC61+jhgkaGhuG6YWM0s9OOLeGurz HqFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ujZ8RfTkP3Hb1bh1uv6UWFJs3MmYJTBitdHyvAEEgTg=; b=JXi0IG/v9UV9PSXtEVsFIVY+sfCYRkhnZt1o90I0761UNCUOmMZcOWdgXXh+HPykqU ulwCynmnfc1j06F/xtyg+D3CjKyOiLUs2bJB6Kzi0702EE7YciDnSWDj3xS3qySncjgj 7N1Ouvuutc9yWAhG8pHBJBmbRFs6fsoabDFmTY5jwMNR7hLm5HRW9ypgRa8jwj9oAMZ0 MqrH+pnmayxJR/PJSR2z3nKQdnygHLAstxZgX+WemYIufixD96u7OxRf+t7wPW5HLuqo M4IOi1nNvOaMWxpWvPd2AdW3zph6049kF6+LqGTtpkHx+mBMmXIGjrVI/U9J8/Hvfex9 NdKQ== X-Gm-Message-State: AOAM533dQVB4PMvOOVw+r5+RBNVjXtU0JJpktghRlqTFw4254sbE4uOS yuMQxr6KWyMqmfCf4kxtuuYdoQ== X-Google-Smtp-Source: ABdhPJyS1OYcapltFF2/FxUN4nOK5yzOROQyrF7/QnyHnIxiuww2hyItj5WtHbRDqv2OjAj/JhdKew== X-Received: by 2002:a17:902:8b89:b029:e0:6c0:dea8 with SMTP id ay9-20020a1709028b89b02900e006c0dea8mr12501676plb.28.1611769208969; Wed, 27 Jan 2021 09:40:08 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:8db4:403d:f1a5:aac2? ([2600:1700:6b0:fde0:8db4:403d:f1a5:aac2]) by smtp.gmail.com with ESMTPSA id o14sm3481805pgr.44.2021.01.27.09.40.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jan 2021 09:40:08 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) From: Andrew Boyer In-Reply-To: <48cdfe00-6dae-4b8b-082d-9501f24438f0@intel.com> Date: Wed, 27 Jan 2021 12:40:06 -0500 Cc: dev@dpdk.org, Alfredo Cardigliano Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210118203508.1332-1-aboyer@pensando.io> <20210118203508.1332-5-aboyer@pensando.io> <48cdfe00-6dae-4b8b-082d-9501f24438f0@intel.com> To: Ferruh Yigit X-Mailer: Apple Mail (2.3608.120.23.2.4) Subject: Re: [dpdk-dev] [PATCH 04/13] net/ionic: add an array-size macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Jan 27, 2021, at 12:22 PM, Ferruh Yigit = wrote: >=20 > On 1/18/2021 8:34 PM, Andrew Boyer wrote: >> Using the IONIC_ARRAY_SIZE() macro makes the code clearer. >> Signed-off-by: Andrew Boyer >=20 > There is already 'RTE_DIM' macro for it (in = 'lib/librte_eal/include/rte_common.h'), what do you think using it = instead of creating a new one? >=20 Ah, I got fooled by NICVF_ARRAY_SIZE(), EFX_ARRAY_SIZE(), and friends. = Will happily switch to RTE_DIM(). -Andrew=