From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0F3E5B0C0 for ; Thu, 12 Jun 2014 11:18:26 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 12 Jun 2014 02:18:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,463,1400050800"; d="scan'208";a="546749823" Received: from fmsmsx103.amr.corp.intel.com ([10.19.9.34]) by fmsmga001.fm.intel.com with ESMTP; 12 Jun 2014 02:18:09 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX103.amr.corp.intel.com (10.19.9.34) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 12 Jun 2014 02:18:08 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.209]) with mapi id 14.03.0123.003; Thu, 12 Jun 2014 17:18:06 +0800 From: "Cao, Waterman" To: Hiroshi Shimamoto , "dev@dpdk.org" Thread-Topic: [PATCH] kni: compatibility with RHEL 7 Thread-Index: Ac+GFYgZQNUE4XZ9T8WGQjHt6QzWkAACMzxQ Date: Thu, 12 Jun 2014 09:18:06 +0000 Message-ID: References: <7F861DC0615E0C47A872E6F3C5FCDDBD0110E674@BPXM14GP.gisp.nec.co.jp> In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD0110E674@BPXM14GP.gisp.nec.co.jp> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: Hayato Momma Subject: Re: [dpdk-dev] [PATCH] kni: compatibility with RHEL 7 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jun 2014 09:18:27 -0000 Hi Shimamoto, Can you give details about Linux Kernel version and complier version? Because we tried to build code in the Redhat 7.0 before, but we don't mee= t this issue. Please see information as the following: Linux kernel 3.10.0-54.0.1.el7.x86_64 RHEL70BETA_64 GCC 4.8.2 ICC: 14.0.0 Thanks Waterman=20 =20 -----Original Message----- >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hiroshi Shimamoto >Sent: Thursday, June 12, 2014 4:10 PM >To: dev@dpdk.org >Cc: Hayato Momma >Subject: [dpdk-dev] [PATCH] kni: compatibility with RHEL 7 > >From: Hiroshi Shimamoto > >Compilation in RHEL7 is failed. This fixes the build issue. > >RHEL7 has skb_set_hash, the kernel version is 3.10 though. >Don't define skb_set_hash for RHEL7. > >Signed-off-by: Hiroshi Shimamoto >Reviewed-by: Hayato Momma >--- > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librt= e_eal/linuxapp/kni/ethtool/igb/kcompat.h >index 4c27d5d..b4de6e2 100644 >--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h >+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h >@@ -3843,6 +3843,9 @@ static inline struct sk_buff *__kc__vlan_hwaccel_put= _tag(struct sk_buff *skb, #endif /* >=3D 3.10.0 */ >=20 > #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,14,0) ) >+ >+#if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >=3D=20 >+RHEL_RELEASE_VERSION(7,0))) >+ > #ifdef NETIF_F_RXHASH > #define PKT_HASH_TYPE_L3 0 > static inline void >@@ -3851,6 +3854,8 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __alwa= ys_unused int type) > skb->rxhash =3D hash; > } > #endif /* NETIF_F_RXHASH */ >+#endif /* < RHEL7 */ >+ > #endif /* < 3.14.0 */ >=20 > #endif /* _KCOMPAT_H_ */ >-- >1.9.1 >