From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A6E557F5C for ; Fri, 10 Oct 2014 05:02:08 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 09 Oct 2014 20:06:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,689,1406617200"; d="scan'208";a="586457206" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 09 Oct 2014 20:09:29 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 9 Oct 2014 20:09:29 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.204]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.190]) with mapi id 14.03.0195.001; Fri, 10 Oct 2014 11:09:26 +0800 From: "Cao, Waterman" To: "Patel, Rashmin N" , Navakanth M , "stephen@networkplumber.org" Thread-Topic: vmxnet3 pmd dev restart Thread-Index: AQHP4yxSjpkRDKpe4UWsGM+i7HH8S5wmslyAgAEbvQCAANlP0A== Date: Fri, 10 Oct 2014 03:09:25 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] vmxnet3 pmd dev restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Oct 2014 03:02:10 -0000 Hi Rashmin, We found similar issue when we start/stop vmnet dev several time. (> 3 tim= es) It happens kernel panic, and sometimes kernel will occur core dump. Let me know if you want to submit patch to fix it. =20 Thanks Waterman=20 -----Original Message----- >From: Patel, Rashmin N=20 >Sent: Friday, October 10, 2014 6:07 AM >To: Navakanth M; stephen@networkplumber.org; Cao, Waterman >Cc: dev@dpdk.org >Subject: RE: vmxnet3 pmd dev restart > >I just quickly looked into the code and instead of releasing memory or sim= ply set it to NULL (patch:=20 > http://thread.gmane.org/gmane.comp.networking.dpdk.devel/4683), you can z= ero it out and it should work perfectly, you can give it a quick try. > >//rte_free(ring->buf_info); >memset(ring->buf_info, 0x0, ring->size*sizeof(vmxnet3_buf_info_t)); > >This will not free the memory from heap but just wipe it out to 0x0, provi= ded that we freed all the mbuf(s) pointed by each buf_info->m pointers. Hen= ce you won't need to reallocate it when you start device after this stop. > >Thanks, >Rashmin > >-----Original Message----- >From: Navakanth M [mailto:navakanthdev@gmail.com] >Sent: Wednesday, October 08, 2014 10:11 PM >To: stephen@networkplumber.org; Patel, Rashmin N; Cao, Waterman >Cc: dev@dpdk.org >Subject: Re: vmxnet3 pmd dev restart > >I had tried with Stephen's patch but after stop is done and when we call s= tart it crashed at vmxnet3_dev_start()-> >vmxnet3_dev_rxtx_init()->vmxnet3_post_rx_bufs() as buf_info is freed and i= s not allocated again. buf_info is allocated in >vmxnet3_dev_rx_queue_setup() which would be called once at the initializat= ion only. >I also tried not freeing buf_info in stop but then i see different issue a= fter start, packets are not received due to check while (rcd->gen =3D=3D rx= q->comp_ring.gen) { in vmxnet3_recv_pkts() > >Waterman, Have you got chance to test stop and start of vmnet dev if so di= d you notice any issue similar to this? > >Thanks >Navakanth > >On Thu, Oct 9, 2014 at 12:46 AM, Patel, Rashmin N wrote: >> Yes I had a local copy working with couple of lines fix. But someone els= e, I think Stephen added a fix patch for the same, and I assume if it's bee= n merged, should be working, so did not follow up later. >> >> I don't have a VMware setup handy at moment but I think Waterman would h= ave more information about testing that patch if he has found any issue wit= h it. >> >> Thanks, >> Rashmin >> >> -----Original Message----- >> From: Navakanth M [mailto:navakanthdev@gmail.com] >> Sent: Wednesday, October 08, 2014 4:14 AM >> To: dev@dpdk.org; Patel, Rashmin N >> Subject: Re: vmxnet3 pmd dev restart >> >> Hi Rashmin >> >> I have come across your reply in following post that you have worked on = this problem and would submit the patch for it. >> Can you please share information on the changes you worked on or patch l= og if you had submitted any for it? >> http://thread.gmane.org/gmane.comp.networking.dpdk.devel/4683 >> >> Thanks >> Navakanth >> >> On Tue, Sep 30, 2014 at 1:44 PM, Navakanth M wr= ote: >>> Hi >>> >>> I am using DPDKv1.7.0 running on Vmware Esxi 5.1 and am trying to=20 >>> reset the port which uses pmd_vmnet3 library functions from below=20 >>> function calls. >>> rte_eth_dev_stop >>> rte_eth_dev_start >>> >>> Doing this, i face panic while rte_free(ring->buf_info) in=20 >>> Vmxnet3_cmd_ring_release(). >>> I have gone through following thread but the patch mentioned didn't=20 >>> help rather it crashed in start function while accessing buf_info in=20 >>> vmxnet3_post_rx_bufs. I see this buf_info is allocated in queue setup=20 >>> functions which are called at initialization. >>> http://thread.gmane.org/gmane.comp.networking.dpdk.devel/4683 >>> >>> I tried not freeing it and then rx packets are not received due to=20 >>> mismatch in while (rcd->gen =3D=3D rxq->comp_ring.gen) in >>> vmxnet3_recv_pkts() >>> >>> To reset the device port, is this the right way what i am doing? >>> Or do I have to call vmxnet3_dev_tx_queue_setup() >>> vmxnet3_dev_rx_queue_setup() once stop is called? I have checked=20 >>> recent patches and threads but did not get much information on this. >>> >>> Thanks >>> Navakanth