From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <junjie.j.chen@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id ACADB239 for <dev@dpdk.org>; Fri, 29 Dec 2017 07:52:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Dec 2017 22:52:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,474,1508828400"; d="scan'208";a="190599240" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 28 Dec 2017 22:52:30 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 28 Dec 2017 22:52:30 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.159]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Fri, 29 Dec 2017 14:52:29 +0800 From: "Chen, Junjie J" <junjie.j.chen@intel.com> To: "Yang, Zhiyong" <zhiyong.yang@intel.com>, "yliu@fridaylinux.org" <yliu@fridaylinux.org>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self Thread-Index: AQHTgE2HPANTmQyIbkujAuZ728bwpaNZVW2AgACNCgA= Date: Fri, 29 Dec 2017 06:52:28 +0000 Message-ID: <AA85A5A5E706C44BACB0BEFD5AC08BF6313272EA@SHSMSX101.ccr.corp.intel.com> References: <1514542463-146522-1-git-send-email-junjie.j.chen@intel.com> <E182254E98A5DA4EB1E657AC7CB9BD2A8B01CB02@BGSMSX101.gar.corp.intel.com> In-Reply-To: <E182254E98A5DA4EB1E657AC7CB9BD2A8B01CB02@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjZmNzEyZDAtNTYwYi00NzA5LTlhY2EtZDUwMDQzMDg3NjAyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJFNXJIbkswVEFicW00QUV5TDVhbDExNHJBOVlRMDhCUUhHZGZsTVpadFFmUmFhOVdcL0ozYU93cFB2TGZaY0tiXC8ifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 29 Dec 2017 06:52:33 -0000 Thanks Zhiyong Updated in v2. > -----Original Message----- > From: Yang, Zhiyong > Sent: Friday, December 29, 2017 2:27 PM > To: Chen, Junjie J <junjie.j.chen@intel.com>; yliu@fridaylinux.org; > maxime.coquelin@redhat.com > Cc: dev@dpdk.org; Chen, Junjie J <junjie.j.chen@intel.com> > Subject: RE: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to= self >=20 > Hi Junjie, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Junjie Chen > > Sent: Friday, December 29, 2017 6:14 PM > > To: yliu@fridaylinux.org; maxime.coquelin@redhat.com > > Cc: dev@dpdk.org; Chen, Junjie J <junjie.j.chen@intel.com> > > Subject: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to > > self > > > > ARP packets are not dropped when dest vdev is itself, which breaks RX > > ring inconspicuously. > > > If you are fixing a bug, it's better to write one fixline before SOB tha= t can > describe which commit caused the issue. > For example, > Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API") >=20 > Thanks > Zhiyong >=20 > > Signed-off-by: Junjie Chen <junjie.j.chen@intel.com> > > --- > ... > <snip>