From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 312DE8E69 for ; Wed, 18 Apr 2018 04:43:15 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 19:43:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="44137673" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 17 Apr 2018 19:43:12 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 17 Apr 2018 19:43:12 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 17 Apr 2018 19:43:11 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.40]) by shsmsx102.ccr.corp.intel.com ([169.254.2.79]) with mapi id 14.03.0319.002; Wed, 18 Apr 2018 10:43:10 +0800 From: "Chen, Junjie J" To: "Richardson, Bruce" , Thomas Monjalon CC: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function Thread-Index: AQHT0iPIOG/HbFQzn0WC2IrO8qovXaQEc8UAgAAarACAAUq7EA== Date: Wed, 18 Apr 2018 02:43:09 +0000 Message-ID: References: <20180412051636.240746-1-junjie.j.chen@intel.com> <1852475.4XxgDvW1hG@xps> <20180417145734.GA89464@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180417145734.GA89464@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmJmYmY3Y2UtNTJjMC00MGY4LTkwNTEtMzcyMjNhMDgzMmZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJMekJWU2tNN0p3UjEzdU9KeVNOUEFyY2JhV2JMUEtXVjBzWExRWSttbWZVXC9uZlJVbmRVak9VVkszSU1jNzF3TiJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 02:43:16 -0000 Thanks to point this out. I agree for the title change. Do you want me to send v2 patch? Or you can handle it when committing?=20 > > > Sometimes gcc does not inline the function despite keyword *inline*, > > > we obeserve rte_movX is not inline when doing performance profiling, > > > so use *always_inline* keyword to force gcc to inline the function. > > > > > > Signed-off-by: Chen, Junjie > > > --- > > > .../common/include/arch/x86/rte_memcpy.h | 22 > +++++++++++----------- > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > The title should start with "eal/x86:" > > Something like that: > > eal/x86: force inlining of memcpy sub-functions > > > > Bruce, Konstantin, any review of the content/optimization? > > > No objection here. >=20 > Acked-by: Bruce Richardson